Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/17 12:57 PM, Borislav Petkov wrote: > On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: >> If the buffer is allocated on the stack then there is no guarantee that > static global is not allocated on the stack. Okay, Just tried static global with CONFIG_VMAP_STACK=y and I

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

2017-10-30 Thread Brian King
On 10/30/2017 03:37 PM, Bart Van Assche wrote: > On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote: >> On 10/17/2017 01:19 AM, Hannes Reinecke wrote: >>> On 10/17/2017 12:49 AM, Bart Van Assche wrote: [ ... ] >>> >>> Not sure if this is a valid conversion. >>> Originally the driver would

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

2017-10-30 Thread Bart Van Assche
On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote: > On 10/17/2017 01:19 AM, Hannes Reinecke wrote: > > On 10/17/2017 12:49 AM, Bart Van Assche wrote: > > > [ ... ] > > > > Not sure if this is a valid conversion. > > Originally the driver would allocate a single buffer; with this buffer > > we

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: > If the buffer is allocated on the stack then there is no guarantee that static global is not allocated on the stack. > I can certainly move the allocation outside, but then it may increase the > code size in other functions. If its

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/2017 12:21 PM, Borislav Petkov wrote: ... Useless forward declarations. Actually its helpful in other patches. I was trying to avoid making too many code movement in other patches to eliminate the forward declarations. I guess I can fix in v7. static struct psp_device

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Sun, Oct 29, 2017 at 03:48:25PM -0500, Brijesh Singh wrote: > AMD's new Secure Encrypted Virtualization (SEV) feature allows the > memory contents of virtual machines to be transparently encrypted with a > key unique to the VM. The programming and management of the encryption > keys are handled

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-10-30 Thread Romain Izard
2017-10-29 21:39 GMT+01:00 Stephan Müller : > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by the

Re: [PATCH RESEND 1/4] crypto: caam: add caam-dma node to SEC4.0 device tree binding

2017-10-30 Thread Kim Phillips
On Mon, 30 Oct 2017 15:46:51 +0200 Horia Geantă wrote: > += > +CAAM DMA Node > + > +Child node of the crypto node that enables the use of the DMA > capabilities > +of the CAAM by a stand-alone

[PATCH RESEND 3/4] crypto: caam: add functionality used by the caam_dma driver

2017-10-30 Thread Horia Geantă
From: Radu Alexe The caam_dma is a memcpy DMA driver based on the DMA functionality of the CAAM hardware block. It creates a DMA channel for each JR of the CAAM. This patch adds functionality that is used by the caam_dma that is not yet part of the JR driver. Signed-off-by:

[PATCH RESEND 4/4] dma: caam: add dma memcpy driver

2017-10-30 Thread Horia Geantă
From: Radu Alexe This module introduces a memcpy DMA driver based on the DMA capabilities of the CAAM hardware block. CAAM DMA is a platform driver that is only probed if the device is defined in the device tree. The driver creates a DMA channel for each JR of the CAAM. This

[PATCH RESEND 2/4] arm64: dts: ls1012a: add caam-dma node

2017-10-30 Thread Horia Geantă
From: Radu Alexe Signed-off-by: Radu Alexe --- arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi index

[PATCH RESEND 1/4] crypto: caam: add caam-dma node to SEC4.0 device tree binding

2017-10-30 Thread Horia Geantă
From: Radu Alexe Signed-off-by: Radu Alexe --- .../devicetree/bindings/crypto/fsl-sec4.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt

[PATCH RESEND 0/4] add CAAM DMA memcpy driver

2017-10-30 Thread Horia Geantă
From: Radu Alexe This patch-set introduces a new DMA memcpy driver based on the DMA capabilities of the CAAM crypto engine. Because of this dependency the included commits target various parts of the kernel tree. Patch 1. Since the CAAM DMA driver is a platform driver it is

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Harald, On 30 October 2017 at 18:58, Harald Freudenberger wrote: > On 10/27/2017 07:04 PM, PrasannaKumar Muralidharan wrote: >> User is able to select a chosen rng by writing its name to rng_current >> but there is no way to reset it without unbinding the rng. Let

[PATCH] staging: ccree: fix 64 bit scatter/gather DMA ops

2017-10-30 Thread Gilad Ben-Yossef
Fix a wrong offset used in splitting a 64 DMA address to MSB/LSB parts needed for scatter/gather HW descriptors causing operations relying on them to fail on 64 bit platforms. Fixes: c6f7f2f4591f ("staging: ccree: refactor LLI access macros") Reported-by: Stuart Yoder

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

2017-10-30 Thread Harald Freudenberger
On 10/27/2017 07:04 PM, PrasannaKumar Muralidharan wrote: > User is able to select a chosen rng by writing its name to rng_current > but there is no way to reset it without unbinding the rng. Let user > write "" to rng_current and delesect the chosen rng. > > Signed-off-by: PrasannaKumar

Re: [PATCH 0/4] add CAAM DMA memcpy driver

2017-10-30 Thread Vinod Koul
On Fri, Oct 27, 2017 at 12:20:32PM +, Horia Geantă wrote: > On 10/27/2017 2:36 PM, Koul, Vinod wrote: > >> On 10/26/2017 1:01 PM, Radu Alexe wrote: > >>> This patch-set introduces a new DMA memcpy driver based on the DMA > >>> capabilities of the CAAM crypto engine. Because of this dependency

Re: [PATCH] hw_random: core: Remove unnecessary new line in MODULE_PARM_DESC

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Herbert, On 30 October 2017 at 12:23, Herbert Xu wrote: > On Thu, Oct 26, 2017 at 10:00:29PM +0530, PrasannaKumar Muralidharan wrote: >> While using MODULE_PARM_DESC there is a new line which is not required. >> Remove it. >> >> Signed-off-by: PrasannaKumar

Re: [PATCH] hw_random: Include device.h instead of declaring struct device

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Herbert, On 30 October 2017 at 12:22, Herbert Xu wrote: > On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: >> Include linux/device.h instead of declaring struct device. >> >> Signed-off-by: PrasannaKumar Muralidharan

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Harald, On 30 October 2017 at 13:40, Harald Freudenberger wrote: > That's a really good idea. I also thought about something like that. Do you mind reviewing the code? Thanks, PrasannaKumar

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

2017-10-30 Thread Harald Freudenberger
On 10/27/2017 07:04 PM, PrasannaKumar Muralidharan wrote: > User is able to select a chosen rng by writing its name to rng_current > but there is no way to reset it without unbinding the rng. Let user > write "" to rng_current and delesect the chosen rng. > > Signed-off-by: PrasannaKumar

Crypto Fixes for 4.14

2017-10-30 Thread Herbert Xu
Hi Linus: This push fixes an objtool regression. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Jason A. Donenfeld (1): crypto: x86/chacha20 - satisfy stack validation 2.0 arch/x86/crypto/chacha20-avx2-x86_64.S |4 ++--

Re: [PATCH] hw_random: core: Remove unnecessary new line in MODULE_PARM_DESC

2017-10-30 Thread Herbert Xu
On Thu, Oct 26, 2017 at 10:00:29PM +0530, PrasannaKumar Muralidharan wrote: > While using MODULE_PARM_DESC there is a new line which is not required. > Remove it. > > Signed-off-by: PrasannaKumar Muralidharan Please stop sending pointless patches like this. Thanks,

Re: [PATCH] hw_random: Include device.h instead of declaring struct device

2017-10-30 Thread Herbert Xu
On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: > Include linux/device.h instead of declaring struct device. > > Signed-off-by: PrasannaKumar Muralidharan Nack. We should not include a header file when a simple forward declaration is