Re: [PATCH v2] dm: switch dm-verity to async hash crypto API

2017-02-17 Thread Gilad Ben-Yossef
Hi Milan, Thank you for the review and testing. On Fri, Feb 17, 2017 at 3:00 PM, Milan Broz <gmazyl...@gmail.com> wrote: > On 02/06/2017 02:58 PM, Gilad Ben-Yossef wrote: >> Use of the synchronous digest API limits dm-verity to using pure >> CPU based algorithm providers

[PATCH] crypto: fix typo in doc

2017-02-13 Thread Gilad Ben-Yossef
Fix a single letter typo in api-skcipher.rst. Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> --- Documentation/crypto/api-skcipher.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/crypto/api-skcipher.rst b/Documentation/crypto/api-skcipher.rst

Re: [RFC PATCH v4] IV Generation algorithms for dm-crypt

2017-02-07 Thread Gilad Ben-Yossef
plain64, Qemu Virt platform Arm64) and it works just fine. Tested-by: Gilad Ben-Yossef <gi...@benyossef.com> Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru

Re: [PATCH] dm: switch dm-verity to async hash crypto API

2017-02-06 Thread Gilad Ben-Yossef
dback. Supporting multiple outstanding async requests is a great idea. I will look into supporting it. Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru

[PATCH v2] dm: switch dm-verity to async hash crypto API

2017-02-06 Thread Gilad Ben-Yossef
time when a lot of concurrent file accesses are made to the protected volume. Move DM_VERITY to the asynchronous hash API. Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> CC: Eric Biggers <ebigge...@gmail.com> CC: Ondrej Mosnáček <omosnacek+linux-cry...@gmail.com> --- Th

[PATCH] dm: switch dm-verity to async hash crypto API

2017-01-24 Thread Gilad Ben-Yossef
real0m 33.96s user0m 1.10s sys 0m 8.00s All measurements done on a dual core Zynq ZC706 development board with an Armv7 processors. Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> --- drivers/md/dm-verity-fec.c| 4 +- drivers/md/dm-verity-target.c

Re: [RFC PATCH v3] crypto: Add IV generation algorithms

2017-01-19 Thread Gilad Ben-Yossef
On Thu, Jan 19, 2017 at 6:42 AM, Binoy Jayan <binoy.ja...@linaro.org> wrote: > Hi Gilad, > > On 18 January 2017 at 20:51, Gilad Ben-Yossef <gi...@benyossef.com> wrote: >> I have some review comments and a bug report - > > Thank you very much for testing this

Re: [RFC PATCH v3] crypto: Add IV generation algorithms

2017-01-18 Thread Gilad Ben-Yossef
sg_out, Also, where do the scatterlist src2 and dst2 that you use sg_set_page() get sg_init_table() called on? I couldn't figure it out... Last but not least, when performing the following sequence on Arm64 (on latest Qemu Virt platform) - 1. cryptsetup luksFormat fs3.img 2. cryptsetup open --type luk

Re: Is the asynchronous hash crypto API asynchronous?

2017-01-09 Thread Gilad Ben-Yossef
15:45:37 CET schrieb Gilad Ben-Yossef: > > Hi Gilad, > >> ahash_request_set_callback(req, 0, NULL, NULL); > >> >> Would anyone be kind enough to enlighten me? > > The documentation got out of sync with the real world. I will file a patch for > t

Is the asynchronous hash crypto API asynchronous?

2017-01-08 Thread Gilad Ben-Yossef
us except that will not work with the code example in api-intro.rst. So... I am totally confused. The documentation claims this is an asynchronous interface, but then its own code examples beg to differ and actual implementations varies. Would anyone be kind enough to enlighten me? Many thanks, Gi

Re: [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-03 Thread Gilad Ben-Yossef
w. > Good idea. I wanted to test the patch but alas it does not apply cleanly. You seem to have a blank line at the end of files and other small transgressions that makes checkpatch grumpy. Also... > > Not-signed-off-by: Binoy Jayan <binoy.ja...@linaro.org> What is N

<    4   5   6   7   8   9