On 10/14/2015 07:30 AM, Dan Streetman wrote:
> On Wed, Oct 14, 2015 at 10:27 AM, Herbert Xu
> <herb...@gondor.apana.org.au> wrote:
>> On Thu, Oct 08, 2015 at 01:45:51PM -0700, Haren Myneni wrote:
>>>
>>> This patch adds CRC generation and validation sup
-by: Haren Myneni <ha...@us.ibm.com>
---
Changes in V2:
Added CRC and validation support in 842 SW compression/ decompression
Changes in v3:
Whitespace format changes
drivers/crypto/nx/nx-842-powernv.c |4 ++--
drivers/crypto/nx/nx-842-pseries.c |8 ++--
lib/842
-by: Haren Myneni <ha...@us.ibm.com>
---
Changes in V2:
Added CRC and validation support in 842 SW compression/ decompression
drivers/crypto/nx/nx-842-powernv.c |4 ++--
drivers/crypto/nx/nx-842-pseries.c |8 ++--
lib/842/842.h |2 ++
lib/842/842_comp
Hi,
This patch allows nx842 coprocessor to add CRC for compression and
check the computed CRC value for uncompression. Please let me know
if you have any comments.
Thanks
Haren
commit d0b34d2e3ed41e7ec2afdbd654f0dd7716e4d4c0
Author: Haren Myneni <ha...@us.ibm.com>
Date: Sat Sep 12 01
NX842 coprocessor sets bit 3 if queue is overflow. It is just for
information to the user. So the driver prints this informative message
and ignores it.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
diff --git a/arch/powerpc/include/asm/icswx.h b/arch/powerpc/include/asm/icswx.h
NX842 coprocessor sets 3rd bit in CR register with XER[S0] which is
nothing to do with NX request. Since this bit can be set with other
valuable return status, mast this bit.
One of other bits (INITIATED, BUSY or REJECTED) will be returned for
any given NX request.
Signed-off-by: Haren Myneni
On 12/07/2015 11:34 AM, Dan Streetman wrote:
> On Sun, Dec 6, 2015 at 2:46 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote:
>>
>> NX842 coprocessor sets bit 3 if queue is overflow. It is just for
>> information to the user. So the driver prints this informa
] value.
One of other bits (INITIATED, BUSY or REJECTED) will be returned for
any given NX request.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
diff --git a/arch/powerpc/include/asm/icswx.h b/arch/powerpc/include/asm/icswx.h
index 9f8402b..27e588f 100644
--- a/arch/powerpc/include/asm/icswx.h
On 12/12/2015 04:05 PM, Segher Boessenkool wrote:
> On Sat, Dec 12, 2015 at 03:01:26PM -0800, Haren Myneni wrote:
>> On 12/12/2015 12:43 AM, Segher Boessenkool wrote:
>>> On Fri, Dec 11, 2015 at 07:30:29PM -0800, Haren Myneni wrote:
>>>> NX842 coprocessor sets 3rd
On 12/12/2015 12:43 AM, Segher Boessenkool wrote:
> On Fri, Dec 11, 2015 at 07:30:29PM -0800, Haren Myneni wrote:
>> NX842 coprocessor sets 3rd bit in CR register with XER[S0] which is
>> nothing to do with NX request. On powerpc, XER[S0] will be set if
>> overflow in FPU an
to freeing co-processor structs for initialization
failures and exit, both send and receive windows have to closed
for VAS.
The last 2 patches adds configuring and invoking VAS, and also
checking P9 NX specific errors that are provided in co-processor
status block (CSB) for failures.
Haren
[PATCH 3/5] crypto/nx: Create nx842_delete_coproc function
Move deleting coprocessor info upon exit or failure to
nx842_delete_coproc().
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 25 -
1 file changed, 12 insertions(
[PATCH 2/5] crypto/nx: Create nx842_cfg_crb function
Configure CRB is moved to nx842_cfg_crb() so that it can be
used for icswx function and VAS function which will be added
later.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.
[PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function
nx842_powernv_function is points to nx842_icswx_function and
will be point to VAS function which will be added later for
P9 NX support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-pow
requests, we use only hight priority FIFOs in kernel.
Each NX request will be communicated to VAS using copy/paste
instructions with vas_copy_crb() / vas_paste_crb() functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
arch/powerpc/include/asm/vas.h | 2 +
drivers/crypto/nx/K
[PATCH 5/5] crypto/nx: Add P9 NX specific error codes for 842 engine
This patch adds changes for checking P9 specific 842 engine
error codes. These errros are reported in co-processor status
block (CSB) for failures.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
arch/powerpc/inclu
and testing with
VAS changes.
Haren Myneni (5):
crypto/nx: Rename nx842_powernv_function as icswx function
crypto/nx: Create nx842_cfg_crb function
crypto/nx: Create nx842_delete_coproc function
crypto/nx: Add P9 NX support for 842 compression engine.
crypto/nx: Add P9 NX specific error codes
[PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c265a5f..4cfd225 100644
--- a/MAINTAINERS
+++ b/MAINT
Michael, Thanks for the review and comments.
On 04/04/2017 03:55 AM, Michael Ellerman wrote:
> Hi Haren,
>
> A few comments ...
>
> Haren Myneni <ha...@linux.vnet.ibm.com> writes:
>
>> diff --git a/arch/powerpc/include/asm/vas.h b/arch/powerpc/include/asm/v
Updating coprocessor list is moved to nx842_add_coprocs_list().
This function will be used for both icswx and VAS functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
This patch adds changes for checking P9 specific 842 engine
error codes. These errros are reported in coprocessor status
block (CSB) for failures.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
arch/powerpc/include/asm/icswx.h | 3 +++
drivers/crypto/nx/nx-842-powernv.
such as priority
and compatible properties.
- Incorporate review comments from Michael Ellerman.
- Other minor issues found during HW testing.
Haren Myneni (6):
crypto/nx842: Rename nx842_powernv_function as icswx function
crypto/nx: Create nx842_configure_crb function
crypto
. For compression /
decompression requests, we use only hight priority FIFOs in kernel.
Each NX request will be communicated to VAS using copy/paste
instructions with vas_copy_crb() / vas_paste_crb() functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/Kconfig
Configure CRB is moved to nx842_configure_crb() so that it can
be used for icswx and VAS exec functions. VAS function will be
added later with P9 support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 57 +-
Rename nx842_powernv_function to nx842_powernv_exec.
nx842_powernv_exec points to nx842_exec_icswx and
will be point to VAS exec function which will be added later
for P9 NX support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.
On 07/18/2017 11:06 AM, Sukadev Bhattiprolu wrote:
> Nicholas Piggin [nicholas.pig...@gmail.com] wrote:
>> On Mon, 17 Jul 2017 16:43:19 -0700
>> Haren Myneni <ha...@linux.vnet.ibm.com> wrote:
>>
>>> [PATCH V2 0/6] Enable NX 842 compression engine on Power9
>
On 07/17/2017 11:53 PM, Ram Pai wrote:
> On Mon, Jul 17, 2017 at 04:50:38PM -0700, Haren Myneni wrote:
>>
>> This patch adds P9 NX support for 842 compression engine. Virtual
>> Accelerator Switchboard (VAS) is used to access 842 engine on P9.
>>
>> For each
Configure CRB is moved to nx842_configure_crb() so that it can
be used for icswx and VAS exec functions. VAS function will be
added later with P9 support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 57 +-
Move deleting coprocessors info upon exit or failure to
nx842_delete_coprocs().
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/crypto/nx/
Updating coprocessor list is moved to nx842_add_coprocs_list().
This function will be used for both icswx and VAS functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
in nx842_poernv_crypto_init/exit_vas().
- Changes for the new device-tree NX properties such as priority
and compatible properties.
- Incorporated review comments from Michael Ellerman.
- Other minor issues found during HW testing.
Haren Myneni (6):
crypto/nx842: Rename
Rename nx842_powernv_function to nx842_powernv_exec.
nx842_powernv_exec points to nx842_exec_icswx and
will be point to VAS exec function which will be added later
for P9 NX support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.
This patch adds changes for checking P9 specific 842 engine
error codes. These errros are reported in coprocessor status
block (CSB) for failures.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
arch/powerpc/include/asm/icswx.h | 3 +++
drivers/crypto/nx/nx-842-powernv.
. For compression /
decompression requests, we use only hight priority FIFOs in kernel.
Each NX request will be communicated to VAS using copy/paste
instructions with vas_copy_crb() / vas_paste_crb() functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/Kconfig
On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote:
>>> +
>>> + ret = -EINVAL;
>>> + if (coproc && coproc->vas.rxwin) {
>>> + wmem->txwin = nx842_alloc_txwin(coproc);
>>
>> this is wrong. the workmem is scratch
is executing.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 149 +
1 file changed, 68 insertions(+), 81 deletions(-)
diff --git a/drivers/crypto/nx/nx-842-powernv.c
b/drivers/crypto/nx/nx-842-powernv.c
index e
[PATCH 2/2] crypto/nx: Do not initialize workmem allocation
We are using percpu send window on P9 NX (powerNV) instead of opening /
closing per each crypto session. Means txwin is removed from workmem.
So we do not need to initialize workmem for each request.
Signed-off-by: Haren Myneni <
On 09/01/2017 04:29 AM, Michael Ellerman wrote:
> Hi Dan,
>
> Thanks for reviewing this series.
>
> Dan Streetman <ddstr...@ieee.org> writes:
>> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com>
>> wrote:
>>> On 0
On 08/29/2017 06:58 AM, Dan Streetman wrote:
> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni <ha...@linux.vnet.ibm.com>
> wrote:
>>
>> This patch adds P9 NX support for 842 compression engine. Virtual
>> Accelerator Switchboard (VAS) is used to access 842 engine o
On 08/29/2017 02:57 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2017-08-29 at 14:54 -0700, Haren Myneni wrote:
>> Opening send window for each crypto transform (crypto_alloc,
>> compression/decompression, ..., crypto_free) so that does not have to
>> wait for the previous cop
On 09/02/2017 09:17 AM, Dan Streetman wrote:
> On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote:
>> On 08/29/2017 06:58 AM, Dan Streetman wrote:
>>> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni <ha...@linux.vnet.ibm.com>
>>>
On 08/31/2017 06:40 AM, Dan Streetman wrote:
> On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni <ha...@linux.vnet.ibm.com>
> wrote:
>> Thanks MIchael and Dan for your review comments.
>>
>>
>> On 08/29/2017 06:32 AM, Dan Streetman wrote:
>>> On Mon,
On 08/31/2017 06:31 AM, Dan Streetman wrote:
> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com>
> wrote:
>> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote:
>>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote:
>>
Move deleting coprocessors info upon exit or failure to
nx842_delete_coprocs().
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/crypto/nx/
. For compression /
decompression requests, we use only hight priority FIFOs in kernel.
Each NX request will be communicated to VAS using copy/paste
instructions with vas_copy_crb() / vas_paste_crb() functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
Reviewed-by: Ram Pai <linux...@u
This patch adds changes for checking P9 specific 842 engine
error codes. These errros are reported in coprocessor status
block (CSB) for failures.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
arch/powerpc/include/asm/icswx.h | 3 +++
drivers/crypto/nx/nx-842-powernv.
Send window is opened / closed for each crypto session.
So initializes txwin in workmem.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx
Updating coprocessor list is moved to nx842_add_coprocs_list().
This function will be used for both icswx and VAS functions.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Configure CRB is moved to nx842_configure_crb() so that it can
be used for icswx and VAS exec functions. VAS function will be
added later with P9 support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 57 +-
Rename nx842_powernv_function to nx842_powernv_exec.
nx842_powernv_exec points to nx842_exec_icswx and
will be point to VAS exec function which will be added later
for P9 NX support.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.
and compatible properties.
- Incorporated review comments from Michael Ellerman.
- Other minor issues found during HW testing.
Haren Myneni (7):
crypto/nx: Rename nx842_powernv_function as icswx function
crypto/nx: Create nx842_configure_crb function
crypto/nx: Create nx842_delete_coprocs
Thanks MIchael and Dan for your review comments.
On 08/29/2017 06:32 AM, Dan Streetman wrote:
> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman <m...@ellerman.id.au> wrote:
>> Hi Haren,
>>
>> Some comments inline ...
>>
>> Haren Myneni <ha...@lin
Sorry for my mistake. Thanks.
Acked-by: Haren Myneni <ha...@us.ibm.com>
On 11/14/2017 06:32 AM, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> Trivial fix to spelling mistake in pr_err error message text. Also
> fix spelling mistake in proceed
and normal FIFOs.
Signed-off-by: Haren Myneni <ha...@us.ibm.com>
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-api.h
index d886a5b..ff61e4b 100644
--- a/arch/powerpc/include/asm/opal-api.h
+++ b/arch/powerpc/include/asm/opal-api.h
@@ -206,7 +206,8 @@
#
54 matches
Mail list logo
