[PATCH] crypto: Correct kzalloc error test

From: Julia Lawall [EMAIL PROTECTED] Normally, kzalloc returns NULL or a valid pointer value, not a value to be tested using IS_ERR. Signed-off-by: Julia Lawall [EMAIL PROTECTED] --- diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c --- a/crypto/cryptd.c 2008-04-16 13:27:56.0 +0200 +++ b

[PATCH 3/12] crypto: Correct size given to memset

From: Julia Lawall ju...@diku.dk Memset should be given the size of the structure, not the size of the pointer. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ type T; T *x; expression E; @@ memset(x, E, sizeof( + * x)) // /smpl Signed-off

[PATCH 2/8] crypto: Use ERR_CAST

From: Julia Lawall ju...@diku.dk Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more clear what is the purpose of the operation, which otherwise looks like a no-op. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ type T; T x

[PATCH 3/4] drivers/crypto/ixp4xx_crypto.c: convert GFP_KERNEL to GFP_ATOMIC

From: Julia Lawall julia.law...@lip6.fr The function is called with locks held and thus should not use GFP_KERNEL. The semantic patch that makes this report is available in scripts/coccinelle/locks/call_kern.cocci. More information about semantic patching is available at http://coccinelle.lip6

[PATCH] drivers/crypto/amcc/crypto4xx_core.c: move up err_request_irq label

From: Julia Lawall julia.law...@lip6.fr Move the err_request_irq error label up to reflect that tasklet_init and irq_of_parse_and_map have taken place. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/crypto/amcc/crypto4xx_core.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] crypto: use ERR_CAST

From: Julia Lawall julia.law...@lip6.fr Replace PTR_ERR followed by ERR_PTR by ERR_CAST, to be more concise. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression err,x; @@ - err = PTR_ERR(x); if (IS_ERR(x

[PATCH 3/5] arch/x86/crypto/camellia_glue.c: convert comma to semicolon

From: Julia Lawall julia.law...@lip6.fr Replace a comma between expression statements by a semicolon. A simplified version of the semantic patch that performs this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ expression e1,e2,e; type T; identifier i; @@ e1 -, +; e2

[PATCH 2/5] crypto/camellia_generic.c: convert comma to semicolon

From: Julia Lawall julia.law...@lip6.fr Replace a comma between expression statements by a semicolon. A simplified version of the semantic patch that performs this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ expression e1,e2,e; type T; identifier i; @@ e1 -, +; e2

Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to semicolon

On Sat, 10 Aug 2013, Joe Perches wrote: On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote: Replace a comma between expression statements by a semicolon. [] This patch is separate from the others because the code appears to be machine-generated. It may have once been machine

[PATCH 2/2] crypto/camellia_generic.c: adjust code alignment

From: Julia Lawall julia.law...@lip6.fr Adjust alignment in automatically generated code. If this code will not be regenerated in the future, it may as well look nice. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- This patch was generated from the result of the previous one, which

[PATCH 1/2] arch/x86/crypto/camellia_glue.c: adjust code alignment

From: Julia Lawall julia.law...@lip6.fr Adjust alignment in automatically generated code. If this code will not be regenerated in the future, it may as well look nice. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- This patch was generated from the result of the previous one, which

Re: [PATCH 1/2] arch/x86/crypto/camellia_glue.c: adjust code alignment

On Wed, 14 Aug 2013, Herbert Xu wrote: On Sat, Aug 10, 2013 at 07:34:36PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Adjust alignment in automatically generated code. If this code will not be regenerated in the future, it may as well look nice. Signed-off

[PATCH 2/2] crypto/camellia_generic.c: replace commas by semicolons and adjust code alignment

From: Julia Lawall julia.law...@lip6.fr Adjust alignment and replace commas by semicolons in automatically generated code. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- crypto/camellia_generic.c | 48 +++--- 1 file changed, 24 insertions(+), 24

[PATCH 1/2] arch/x86/crypto/camellia_glue.c: replace commas by semicolons and adjust code alignment

From: Julia Lawall julia.law...@lip6.fr Adjust alignment and replace commas by semicolons in automatically generated code. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- arch/x86/crypto/camellia_glue.c | 48 1 file changed, 24 insertions(+), 24

Re: [PATCH v2] crypto: memzero_explicit - make sure to clear out sensitive data

such occurences in the crypto subsytem as well. Julia Lawall provided the following Coccinelle program: @@ type T; identifier x; @@ T x; ... when exists when any -memset +memzero_explicit (x, -0, ...) ... when != x when strict

Re: [PATCH 1/2] scripts/coccinelle: catch freeing cryptographic structures via kfree

On Mon, 17 Nov 2014, Konstantin Khlebnikov wrote: Structures allocated by crypto_alloc_* must be freed using crypto_free_*. Signed-off-by: Konstantin Khlebnikov k.khlebni...@samsung.com --- scripts/coccinelle/free/crypto_free.cocci | 45 + 1 file changed,

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

+// Comments: There are false positives in crypto/ where they are actually freed. I didn't really understand this comment. I ran the semantic patch and got around 10 results, but it wasn't clear to me how to see which were false positives. I would suggest to extend the rule a little bit to

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote: On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall julia.law...@lip6.fr wrote: +// Comments: There are false positives in crypto/ where they are actually freed. I didn't really understand this comment. I ran the semantic patch and got

[PATCH 7/8] crypto: replace memset by memzero_explicit

From: Julia Lawall ju...@diku.dk Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr

[PATCH 2/8] sparc64: replace memset by memzero_explicit

From: Julia Lawall ju...@diku.dk Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr

[PATCH 6/8] crypto: replace memset by memzero_explicit

From: Julia Lawall ju...@diku.dk Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr

[PATCH 3/8] crypto: replace memset by memzero_explicit

From: Julia Lawall ju...@diku.dk Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr

[PATCH 7/8 v2] crypto: replace memset by memzero_explicit

From: Julia Lawall julia.law...@lip6.fr Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http

[PATCH 6/8 v2] crypto: replace memset by memzero_explicit

From: Julia Lawall julia.law...@lip6.fr Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http

[PATCH 3/8 v2] crypto: replace memset by memzero_explicit

From: Julia Lawall julia.law...@lip6.fr Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http

[PATCH 2/8 v2] sparc64: replace memset by memzero_explicit

From: Julia Lawall julia.law...@lip6.fr Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http

[PATCH 0/8] replace memset by memzero_explicit

Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; local idexpression e;

[PATCH 0/15] don't export static symbol

These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on static functions. This was done using the following semantic patch: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@

[PATCH 4/15] crypto: don't export static symbol

From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL_GPL; @@ -EXPORT_SYMBOL_GPL(f); // /smpl Signed-off

[PATCH 7/9] crypto: constify pci_error_handlers structures

This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- There are no dependencies between these patches. drivers/cryp

[PATCH 0/9] constify pci_error_handlers structures

Constify never-modified pci_error_handlers structures. --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- drivers/misc/genwqe/card_base.c |2 +- drivers/net/ethernet/cavium/liquidio/lio_main.c |2 +- drivers/net/ethernet/sfc/efx.c |2 +-

[PATCH] crypto: constify drbg_state_ops structures

The drbg_state_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- crypto/drbg.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/drbg.c b/crypto/drbg.c

Re: crypto: algif_skcipher - Require setkey before accept(2)

On Fri, 25 Dec 2015, Herbert Xu wrote: > On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > > Lines 766, 767 don't look correct at all. > > Thanks Julia. I have sent an updated patch in the original thread. > I wonder why I haven't received the original kbuild

Re: crypto: algif_skcipher - Require setkey before accept(2)

Lines 766, 767 don't look correct at all. julia On Thu, 24 Dec 2015, kbuild test robot wrote: > In-Reply-To: <20151224093902.ga8...@gondor.apana.org.au> > > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > Hi Herbert, > > [auto build

Re: [PATCH 9/26] eCryptfs: Use skcipher and shash

Maybe the goto on line 1726 needs a preceding mutex_unlock? julia On Mon, 25 Jan 2016, kbuild test robot wrote: > Hi Herbert, > > [auto build test WARNING on net/master] > [also build test WARNING on v4.4 next-20160122] > [if your patch is applied to the wrong git tree, please drop us a note to

[PATCH 0/5] Use dma_pool_zalloc

Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ type T; T *d; expression e; statement S; @@ d = -dma_pool_alloc +dma_pool_zalloc (...);

[PATCH] fix itnull.cocci warnings

The first argument to list_for_each_entry cannot be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Harsh Jain <ha...@chelsio.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- This code comes from

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

It looks like >cmdr_lock should be released at line 512 if it has not been released otherwise. The lock was taken at line 438. julia -- Forwarded message -- Date: Fri, 14 Apr 2017 22:21:44 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Jul

Re: [PATCH v11 4/5] LRNG - enable compile (fwd)

test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v11 4/5] LRNG - enable compile CC: kbuild-...@01.org In-Reply-To: <2619717.m11260e...@positron.chronox.de> TO: "Stephan Müller" <smuel...@chronox.de> C

[PATCH] fix ptr_ret.cocci warnings

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Stephan Müller <smuel...@chronox.de> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- Not very important

Re: [PATCH 2/2] crypto: engine - Permit to enqueue skcipher request

Please check whether an unlock is needed before line 454. julia -- Forwarded message -- Date: Wed, 24 May 2017 12:16:29 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 2/2] cr

[cryptodev:master 77/100] drivers/crypto/ccp/ccp-debugfs.c:303:3-9: preceding lock on line 299 (fwd)

Please check whether a lock is needed before line 303. julia -- Forwarded message -- Date: Mon, 19 Jun 2017 17:34:11 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [cryptodev:master 77/100] dr

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc

tis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > - eliminate parentheses around the first argument > > drivers/staging/ccree/ssi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

Re: [Outreachy kernel] [PATCH] Staging: ccree: Use kcalloc instead of kzalloc

On Thu, 14 Sep 2017, Srishti Sharma wrote: > Use kcalloc instead of kzalloc to check for overflow before > multiplication. Done using the following semantic patch by > coccinelle. > > http://coccinelle.lip6.fr/rules/kzalloc.cocci > > Signed-off-by: Srishti Sharma > --- >

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Srishti Sharma

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, 9 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > > > >> Return the return value of a function directly, instead of first saving

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, 9 Sep 2017, Srishti Sharma wrote: > Return the return value of a function directly, instead of first saving it in > a variable and then returning it. This change was made using the following Your commit message should respect the 80 character limit. The above is one very long line. >

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. Coccinelle is not always perfect about pretty printing, so you have to watch out for it. > > @@ > local idexpression ret; > expression e; > @@ > > -ret

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: Merge assignment with return

t; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v4: > -Edit commit message so that it respects 80 character limit > -Remove unneeded blank lines > -Remove declarations of variables that are not used

Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, 11 Sep 2017, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. You need to give more evidence of why this is the case. How is the variable used? I guess this comes from checkpatch, but checkpatch has only a local view of things, and doesn't

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, 11 Sep 2017, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > >> The use of volatile for the variable monitor_lock is unnecessary. > >> > >> Signed-off-by: Srishti

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

On Thu, 7 Sep 2017, Srishti Sharma wrote: > Edited comment to make it more comprehensible. > > Signed-off-by: Srishti Sharma > --- > Changes in v2: > - Make comment more comprehensible , instead of just correcting typos. > drivers/staging/ccree/ssi_cipher.c | 4 +++- >

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

On Wed, 6 Sep 2017, Srishti Sharma wrote: > > > On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma > wrote: > Correct spelling of counter in comment . > > Signed-off-by: Srishti Sharma > --- >  

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

On Thu, 7 Sep 2017, Srishti Sharma wrote: > On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Thu, 7 Sep 2017, Srishti Sharma wrote: > > > >> Remove local variable inflight_counter ,as it is nev

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

On Thu, 7 Sep 2017, Srishti Sharma wrote: > Remove local variable inflight_counter ,as it is never used. "counter ,as" -> "counter, as" > Signed-off-by: Srishti Sharma > --- > Changes in v3: > - There was no longer a need to make the comment more comprehensible as >

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: Merge assignment with return

On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Srishti Sharma

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable.

One last detail. The subject line above is not in the same format as that of all of the other subject lines one commits affecting this file. You can use git log --oneline to see what others have done. It is not really possible to guess correctly. However, one does not generally include the

Re: [Outreachy kernel] [PATCH v5] Staging: ccree: Remove unused variable.

On Thu, 7 Sep 2017, Srishti Sharma wrote: > Remove the local variable inflight_counter as it is never used. > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v5: > - Correct the format of t

Re: [PATCH] crypto: Use zeroing memory allocator instead of allocator/memset

On Sun, 31 Dec 2017, Himanshu Jha wrote: > On Sun, Dec 31, 2017 at 07:46:09AM -0800, Joe Perches wrote: > > On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote: > > > Use dma_zalloc_coherent for allocating zeroed > > > memory and remove unnecessary memset function. > > > > > > Done using

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Fri, 30 Mar 2018, Joe Perches wrote: > On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote: > > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > > This patch fixes the clang warning of extraneous parentheses, with the > > >

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Thu, 29 Mar 2018, Varsha Rao wrote: > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > This patch fixes the clang warning of extraneous parentheses, with the > > > following coccinelle script. > > > > > > @@ > > > identifier i;

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Sat, 31 Mar 2018, Varsha Rao wrote: > On Sat, Mar 31, 2018 at 11:48 AM, Julia Lawall wrote: > > On Thu, 29 Mar 2018, Varsha Rao wrote: > > > >> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > >> > > >> > On Wed, 2018-03-28 at 23

Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record (fwd)

ctx is dereferenced on line 258 but has been freed on line 229. julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:05:25 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v11

Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig (fwd)

Please check the indentation on line 1655. thanks, julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:15:36 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v11 crypto 12/12] c