Re: [PATCH v12 1/9] iomap: Fix sparse endian check warnings

2018-03-18 Thread Luc Van Oostenryck
) > +#define mmio_write32be(val, port) \ > + __raw_writel((u32 __force)cpu_to_be32(val), port) > #endif I think that in this sort of replacement, it's better to not split the lines (even if larger than 80, that's it). -- Luc Van Oostenryck

Re: [PATCH v14 02/10] iomap: Add big endian sparse annotations to mmio_{read|write}XXbe()

2018-03-22 Thread Luc Van Oostenryck
On Thu, Mar 22, 2018 at 11:16:55AM -0600, Logan Gunthorpe wrote: > Sparse produces a few warnings of the form: > > lib/iomap.c:84:9: warning: cast to restricted __be16 > > (The kbuild robot has recently started running such checks) Reviewed-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com>

Re: [PATCH v13 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

2018-03-21 Thread Luc Van Oostenryck
and code analysis tools alike. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Kate Stewart <kstew...@linuxfoundation.org> > Cc: Greg Kroah-Hartman <gre...