Re: [PATCH v2 1/3] Documentation: devicetree: add Freescale RNGC binding

2017-07-17 Thread Martin Kaiser
Hi, I'd like to pick this up and get the rngc driver merged finally. Thus wrote Rob Herring (r...@kernel.org): > The MXC name is still not dead? looks like no. There's still CONFIG_ARCH_MXC etc. The other similar rng driver is called mxc-rnga.c so it makes sense to use mxc-rngc. > > 1 file

[PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2017-07-17 Thread Martin Kaiser
ch has no driver implementation in Freescales kernel. However as it turns out, the driver for the RNGC works fine on the (at least) i.MX25. So, they seem to be somewhat compatible. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx>

[PATCH v3 1/3] Documentation: devicetree: add Freescale RNGC binding

2017-07-17 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add binding documentation for the Freescale RNGC found on some i.MX2/3 SoCs. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v3: - add compatibl

[PATCH v3 2/3] ARM: i.MX25: add RNGC node to dtsi

2017-07-17 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add a devicetree entry for the Random Number Generator Version C (RNGC). Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v3: - remove clock-names

Re: [PATCH v2 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2017-07-17 Thread Martin Kaiser
Dear all, looking for a Freescale RNGB/C driver, I came across this old mail thread. It seems the review got stuck and the driver was never merged. This mail is the latest conversation I could find. I would like to pick up this work and prepare the RNGC driver for merging into the mailine

Re: [PATCH v2 2/3] ARM: i.MX25: add RNGC node to dtsi

2017-07-17 Thread Martin Kaiser
Dear all, I'd like to pick this up and get the rgnc driver merged. Thus wrote Shawn Guo (shawn...@kernel.org): > > + rng: rng@53fb { > > + compatible = "fsl,imx25-rng"; > > + reg = <0x53fb 0x4000>; > > +

[PATCH v4 2/3] ARM: i.MX25: add RNGC node to dtsi

2017-07-20 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add a devicetree entry for the Random Number Generator Version C (RNGC). Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v4: none Changes in v3: -

[PATCH v4 1/3] Documentation: devicetree: add Freescale RNGC binding

2017-07-20 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add binding documentation for the Freescale RNGC found on some i.MX2/3 SoCs. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v4: none Changes in v3:

[PATCH v4 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2017-07-20 Thread Martin Kaiser
ch has no driver implementation in Freescales kernel. However as it turns out, the driver for the RNGC works fine on the (at least) i.MX25. So, they seem to be somewhat compatible. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx>

[PATCH v6 3/3] hwrng: add a driver for Freescale RNGC

2017-07-23 Thread Martin Kaiser
<s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v6: - get rid of mxc: rename the .c file and the kconfig option - update the kconfig help text - rename structs, functi

[PATCH v6 2/3] ARM: i.MX25: add RNGB node to dtsi

2017-07-23 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add a devicetree entry for the Random Number Generator Version B (RNGB). The driver for RNGC supports version B as well. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.

[PATCH v6 1/3] Documentation: devicetree: add Freescale RNGC binding

2017-07-23 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add binding documentation for the Freescale RNGC found on some i.MX2/3 SoCs. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v6: - be more precise a

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2017-07-19 Thread Martin Kaiser
Hi PrasannaKumar, thanks for taking the time to review my submission. Thus wrote PrasannaKumar Muralidharan (prasannatsmku...@gmail.com): > Please combine above 2 comments. ok, I'll do this. > > + > > +/* > > + * Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG) > > [...]

[PATCH v5 1/3] Documentation: devicetree: add Freescale RNGC binding

2017-07-20 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add binding documentation for the Freescale RNGC found on some i.MX2/3 SoCs. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v5: none Changes in v

[PATCH v5 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2017-07-20 Thread Martin Kaiser
ch has no driver implementation in Freescales kernel. However as it turns out, the driver for the RNGC works fine on the (at least) i.MX25. So, they seem to be somewhat compatible. Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kais

[PATCH v5 2/3] ARM: i.MX25: add RNGC node to dtsi

2017-07-20 Thread Martin Kaiser
From: Steffen Trumtrar <s.trumt...@pengutronix.de> Add a devicetree entry for the Random Number Generator Version C (RNGC). Signed-off-by: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- Changes in v5: none Changes in v4: n

Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static

2018-01-23 Thread Martin Kaiser
esume); > static const struct of_device_id imx_rngc_dt_ids[] = { > { .compatible = "fsl,imx25-rngb", .data = NULL, }, You're right. The vast majority of other drivers uses a static SIMPLE_DEV_PM_OPS(), so should we. Reviewed-by: Martin Kaiser <mar...@kaiser.cx>

[PATCH] hwrng: imx-rngc: simplify the power management definitions

2018-01-11 Thread Martin Kaiser
be included in the kernel. Mark them as __maybe_unused to clarify that this is intended behaviour. With these modifications in place, we don't need the #ifdefs for power management any more. Signed-off-by: Martin Kaiser <mar...@kaiser.cx> --- drivers/char/hw_random/imx-rngc.c | 13 +++---