Re: [PATCH] Revert "crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64"

ISA ARM > Segment none > > Revert it for now. > > Signed-off-by: Fabio Estevam Acked-by: Logan Gunthorpe

[PATCH v17 3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v17 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Revie

[PATCH v17 2/7] parisc: iomap: introduce io{read|write}64

Add support for io{read|write}64() functions in parisc architecture. These are pretty straightforward copies of similar functions which make use of readq and writeq. Also, indicate that the lo_hi and hi_lo variants of these functions are not provided by this architecture. Signed-off-by: Logan

[PATCH v17 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v17 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v17 0/7] Add io{read|write}64 to io-64-atomic headers

* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) Logan Gunthorpe (7): iomap: Use non-raw io functions for io{read|write}XXbe parisc: iomap: introduce io{read|write}64 iomap: introduce io{read|write}64_{lo_hi|hi_lo} io-64-nonatomic: add io{read|write

[PATCH v17 1/7] iomap: Use non-raw io functions for io{read|write}XXbe

code did not annotate correctly. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Kate Stewart <kstew...@linuxfoundation.org> Cc: Philippe Ombredanne <pombreda...@nexb.com> Cc: Greg Kroah-Hartman <gre...@linuxfounda

[PATCH v17 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shev

[PATCH v16 2/7] parisc: iomap: introduce io{read|write}64

Add support for io{read|write}64() functions in parisc architecture. These are pretty straightforward copies of similar functions which make use of readq and writeq. Also, indicate that the lo_hi and hi_lo variants of these functions are not provided by this architecture. Signed-off-by: Logan

[PATCH v16 0/7] Add io{read|write}64 to io-64-atomic headers

drastically different) -- Logan Gunthorpe (7): iomap: Use non-raw io functions for io{read|write}XXbe parisc: iomap: introduce io{read|write}64 iomap: introduce io{read|write}64_{lo_hi|hi_lo} io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros ntb: ntb_hw_intel: use io-64-nonatomic

[PATCH v16 3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v16 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Revie

[PATCH v16 1/7] iomap: Use non-raw io functions for io{read|write}XXbe

code did not annotate correctly. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Kate Stewart <kstew...@linuxfoundation.org> Cc: Philippe Ombredanne <pombreda...@nexb.com> Cc: Greg Kroah-Hartman <gre...@linuxfounda

[PATCH v16 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v16 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v16 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shev

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

On 4/4/2018 4:38 AM, Michael Ellerman wrote: What's the plan for getting it merged? Seems we don't have one? Yeah, so far there is no plan. I'm not really sure who's attention I need to get or how to get it. Given it touches two arches and generic stuff and drivers and crypto, it's a bit

[PATCH v15 9/9] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shev

[PATCH v15 2/9] parisc: iomap: introduce io{read|write}64

Add support for io{read|write}64() functions in parisc architecture. These are pretty straightforward copies of similar functions which make use of readq and writeq. Also, indicate that the lo_hi and hi_lo variants of these functions are not provided by this architecture. Signed-off-by: Logan

[PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

a patch to adjust this - Fixed some mistakes with a couple of the defines in io-64-nonatomic* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) -- Logan Gunthorpe (9): iomap: Use non-raw io functions for io{read|write}XXbe parisc: iomap: introduce io{read

[PATCH v15 7/9] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v15 1/9] iomap: Use non-raw io functions for io{read|write}XXbe

code did not annotate correctly. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Kate Stewart <kstew...@linuxfoundation.org> Cc: Philippe Ombredanne <pombreda...@nexb.com> Cc: Greg Kroah-Hartman <gre...@linuxfounda

[PATCH v15 6/9] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v15 8/9] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Revie

[PATCH v15 3/9] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v15 5/9] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v15 4/9] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

Re: [PATCH v13 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

On 26/03/18 01:50 PM, Arnd Bergmann wrote: > I wouldn't expect it to matter: the byte swap is almost always much > cheaper compared to the actual bus access for the MMIO, and I > would also guess that modern compilers can eliminate the double > byte swap on architectures where writel() is an

Re: [PATCH v13 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

On 26/03/18 04:53 AM, Arnd Bergmann wrote: > On most architectures, this is not important: > - For x86, the stores are aways atomic and no additional barriers > are needed, so the two are the same > - For ARM (both 32 and 64-bit), powerpc and many others, we don't > use the generic iowrite()

Re: [PATCH v14 02/10] iomap: Add big endian sparse annotations to mmio_{read|write}XXbe()

On 3/22/2018 11:27 AM, Luc Van Oostenryck wrote: On Thu, Mar 22, 2018 at 11:16:55AM -0600, Logan Gunthorpe wrote: Sparse produces a few warnings of the form: lib/iomap.c:84:9: warning: cast to restricted __be16 (The kbuild robot has recently started running such checks) Reviewed-by: Luc Van

[PATCH v14 10/10] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shev

[PATCH v14 08/10] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v14 00/10] Add io{read|write}64 to io-64-atomic headers

drastically different) -- Logan Gunthorpe (10): iomap: Use correct endian conversion function in mmio_writeXXbe iomap: Add big endian sparse annotations to mmio_{read|write}XXbe() parisc: iomap: introduce io{read|write}64 powerpc: io.h: move iomap.h include so that it can use readq/writeq

[PATCH v14 04/10] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v14 07/10] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v14 02/10] iomap: Add big endian sparse annotations to mmio_{read|write}XXbe()

, the output of __raw_readX() and the input of __raw_writeX() must be cast with the __force keyword to supress the invalid warning. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc:

[PATCH v14 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

() and cpu_to_beXX() are both functionally implemented as either null operations or swabXX operations there was no noticable bug here. But it is confusing for both developers and code analysis tools alike. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Luc Van Oost

[PATCH v14 05/10] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v14 09/10] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Revie

Re: [PATCH v13 00/10] Add io{read|write}64 to io-64-atomic headers

On 21/03/18 11:40 AM, Andy Shevchenko wrote: > The first patches that I didn't reviewed before makes sense to me, the > rest (at the end) FWIW, > > Reviewed-by: Andy Shevchenko Great, thanks! Logan

[PATCH v13 09/10] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Cc: And

[PATCH v13 06/10] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v13 08/10] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v13 02/10] iomap: Fix sparse endian check warnings

be marked as such seeing the endianness is indeterminate. Thus, the output of __raw_readX() and the input of __raw_writeX() must be cast with the __force keyword to supress the invalid warning. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc

[PATCH v13 07/10] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v13 10/10] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason

[PATCH v13 05/10] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v13 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

() and cpu_to_beXX() are both functionally implemented as either null operations or swabXX operations there was no noticable bug here. But it is confusing for both developers and code analysis tools alike. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Philippe Ombredanne <

[PATCH v13 00/10] Add io{read|write}64 to io-64-atomic headers

when iomap.h was included. Thus I've included a patch to adjust this - Fixed some mistakes with a couple of the defines in io-64-nonatomic* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) -- Logan Gunthorpe (10): iomap: Use correct endian conversion

Re: [PATCH v12 1/9] iomap: Fix sparse endian check warnings

Hi Luc, Thanks for the feedback. I'll try to address your points in a v13 shortly. Logan On 18/03/18 10:13 AM, Luc Van Oostenryck wrote: > it looks correct but if you should explain why the warning > is not a valid one. Once done, you can then explain what problem > you have fixed instead of

[PATCH v12 8/9] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Cc: And

[PATCH v12 9/9] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Per a nit from Andy Shevchenko, the include list is also made alphabetical. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason

[PATCH v12 2/9] parisc: iomap: introduce io{read|write}64

Add support for io{read|write}64() functions in parisc architecture. These are pretty straightforward copies of similar functions which make use of readq and writeq. Also, indicate that the lo_hi and hi_lo variants of these functions are not provided by this architecture. Signed-off-by: Logan

[PATCH v12 1/9] iomap: Fix sparse endian check warnings

. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Philippe Ombredanne <pombreda...@nexb.com> Cc: Kate Stewart <kstew...@linuxfoundation.org> --- lib/iomap.c | 10

[PATCH v12 6/9] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v12 0/9] Add io{read|write}64 to io-64-atomic headers

-nonatomic* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) -- Logan Gunthorpe (9): iomap: Fix sparse endian check warnings parisc: iomap: introduce io{read|write}64 powerpc: io.h: move iomap.h include so that it can use readq/writeq defs powerpc

[PATCH v12 3/9] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v12 4/9] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v12 5/9] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v12 7/9] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

Re: [PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

On 06/03/18 04:57 AM, Andy Shevchenko wrote: On Tue, Mar 6, 2018 at 1:46 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: On Tue, Mar 06, 2018 at 12:48:29PM +0200, Andy Shevchenko wrote: On Mon, Mar 5, 2018 at 9:08 PM, Logan Gunthorpe <log...@deltatee.com> wrot

Re: [PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

On 06/03/18 05:37 AM, Horia Geantă wrote: On 3/5/2018 9:08 PM, Logan Gunthorpe wrote: Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 functions in non-64bit cases in favour of the new common io-64-nonatomic-lo-hi header. To be consistent with CAAM engine HW spec: in case

[PATCH v11 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v11 0/7] Add io{read|write}64 to io-64-atomic headers

by Horia. (earlier versions were drastically different) -- Logan Gunthorpe (7): powerpc: io.h: move iomap.h include so that it can use readq/writeq defs powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo} iomap: introduce io{read|write}64_{lo_hi|hi_lo} io-64-nonatomic: add io{read

[PATCH v11 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason <jdma...@kudzu.us> --- drivers/ntb/hw/mscc/ntb_hw_swit

[PATCH v11 3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v11 2/7] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc:

[PATCH v11 1/7] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v10 8/8] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason <jdma...@kudzu.us> --- drivers/ntb/hw/mscc/ntb_hw_swit

[PATCH v10 0/8] Add io{read|write}64 to io-64-atomic headers

the appropriate functions seeing readq/writeq were not defined when iomap.h was included. Thus I've included a patch to adjust this - Fixed some mistakes with a couple of the defines in io-64-nonatomic* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) Logan Gunthorpe

[PATCH v10 1/8] drm/tilcdc: ensure nonatomic iowrite64 is not used

this change, this patchset would inadvertantly change the behaviour of the tilcdc driver. [1] lkml.kernel.org/r/cak8p3a2hho_zcnstzq7hmwsz5la5thu19fwzpun16imnyyn...@mail.gmail.com Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc

[PATCH v10 4/8] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v10 3/8] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v10 5/8] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v10 2/8] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v10 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

/ written to first, followed by the upper address. Indeed the I/O accessors in CAAM driver currently don't follow the spec, however this is a good opportunity to fix the code. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc:

[PATCH v10 6/8] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

Re: [PATCH v9 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

On 04/01/18 12:25 AM, Horia Geantă wrote: +#include Typo: lo-hi should be used instead (see previous patch versions). Please add in the commit message the explanation (which was there in v8 but removed in v9): To be consistent with CAAM engine HW spec: in case of 64-bit registers,

[PATCH v9 6/8] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v9 0/8] Add io{read|write}64 to io-64-atomic headers

* headers - Fixed a typo noticed by Horia. (earlier versions were drastically different) Logan Gunthorpe (8): drm/tilcdc: ensure nonatomic iowrite64 is not used powerpc: io.h: move iomap.h include so that it can use readq/writeq defs powerpc: iomap.c: introduce io{read|write}64_{lo_hi

[PATCH v9 2/8] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v9 4/8] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v9 5/8] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v9 3/8] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v9 1/8] drm/tilcdc: ensure nonatomic iowrite64 is not used

this change, this patchset would inadvertantly change the behaviour of the tilcdc driver. [1] lkml.kernel.org/r/cak8p3a2hho_zcnstzq7hmwsz5la5thu19fwzpun16imnyyn...@mail.gmail.com Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc

[PATCH v9 8/8] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason <jdma...@kudzu.us> --- drivers/ntb/hw/mscc/ntb_hw_swit

[PATCH v9 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 functions in non-64bit cases in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Horia Geantă <horia.gea

[PATCH v9 8/8] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Jon Mason <jdma...@kudzu.us> --- drivers/ntb/hw/mscc/ntb_hw_swit

[PATCH v9 2/8] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe <log...@deltatee.com>

[PATCH v9 6/8] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

Now that ioread64 and iowrite64 are available in io-64-nonatomic, we can remove the hack at the top of ntb_hw_intel.c and replace it with an include. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Acked-by: Dave Ji

[PATCH v9 3/8] powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo}

-by: Logan Gunthorpe <log...@deltatee.com> Tested-by: Horia Geantă <horia.gea...@nxp.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@

[PATCH v9 4/8] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

[PATCH v9 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 functions in non-64bit cases in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Horia Geantă <horia.gea

[PATCH v9 0/8] Add io{read|write}64 to io-64-atomic headers

. (earlier versions were drastically different) Logan Gunthorpe (8): drm/tilcdc: ensure nonatomic iowrite64 is not used powerpc: io.h: move iomap.h include so that it can use readq/writeq defs powerpc: iomap.c: introduce io{read|write}64_{lo_hi|hi_lo} iomap: introduce io{read|write}64_{lo_hi

[PATCH v9 1/8] drm/tilcdc: ensure nonatomic iowrite64 is not used

this change, this patchset would inadvertantly change the behaviour of the tilcdc driver. [1] lkml.kernel.org/r/cak8p3a2hho_zcnstzq7hmwsz5la5thu19fwzpun16imnyyn...@mail.gmail.com Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc

[PATCH v9 5/8] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros

are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] LDD3: section 9.4.2 Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Christoph Hellwig <h...@lst.de>

[PATCH v8 4/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

and writeq are defined. If they are not, then the wrappers that always use non-atomic operations from include/linux/io-64-nonatomic*.h will be used. Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Benjamin Herr

  1   2   3   >