Re: [PATCH v2 4/6] crypto: virtio: convert to new crypto engine API

2018-02-14 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 08:15:32PM +0100, Corentin Labbe wrote: > This patch convert the driver to the new crypto engine API. > > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> Pls queue when/if rest of changes go

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-31 Thread Michael S. Tsirkin
On Fri, Mar 31, 2017 at 12:04:55PM +0800, Jason Wang wrote: > > > On 2017年03月30日 22:32, Michael S. Tsirkin wrote: > > On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: > > > > > > On 2017年03月30日 04:48, Michael S. Tsirkin wrote: > > > > We

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: > > > On 2017年03月30日 04:48, Michael S. Tsirkin wrote: > > We are going to add more parameters to find_vqs, let's wrap the call so > > we don't need to tweak all drivers every time. > > > > Si

[PATCH 1/6] virtio: wrap find_vqs

2017-03-29 Thread Michael S. Tsirkin
We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- drivers/block/virtio_blk.c | 3 +-- drivers/char/virtio_console.c | 6 +++--- drivers/

Re: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > >> Hi, > >> > >>> > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > >>> [...] > + > +static struct crypto_alg

Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

2016-12-15 Thread Michael S. Tsirkin
On Thu, Dec 15, 2016 at 01:08:51AM +, Gonglei (Arei) wrote: > > > > > Regards, > -Gonglei > > > > -Original Message- > > From: Zeng, Xin [mailto:xin.z...@intel.com] > > Sent: Thursday, December 15, 2016 8:59 AM > > To: Gonglei (Arei); Halil Pasic; linux-ker...@vger.kernel.org; >

[PATCH 0/8] enable endian checks for all sparse builds

2016-12-14 Thread Michael S. Tsirkin
This is just a reposting of the patch that enables endian checks, with addition of trivial patches that drop __bitwise__ and __CHECK_ENDIAN__ everywhere. I plan to include this in my pull request unless I hear otherwise. Michael S. Tsirkin (8): linux/types.h: enable endian checks for all

Re: [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-07 Thread Michael S. Tsirkin
On Thu, Dec 08, 2016 at 05:21:47AM +, Bart Van Assche wrote: > On 12/07/16 18:29, Michael S. Tsirkin wrote: > > By now, linux is mostly endian-clean. Enabling endian-ness > > checks for everyone produces about 200 new sparse warnings for me - > > less than 10% over the

[PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-07 Thread Michael S. Tsirkin
__CHECK_ENDIAN__. Follow-up patches can drop distinction between __bitwise and __bitwise__. Cc: Linus Torvalds <torva...@linux-foundation.org> Suggested-by: Christoph Hellwig <h...@infradead.org> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- Linus, could you ack this for ups

[PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-06 Thread Michael S. Tsirkin
__CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- It

[PATCH 00/10] virtio: sparse fixes

2016-12-06 Thread Michael S. Tsirkin
for sparse builds. Michael S. Tsirkin (10): virtio_console: drop unused config fields drm/virtio: fix endianness in primary_plane_update drm/virtio: fix lock context imbalance drm/virtio: annotate virtio_gpu_queue_ctrl_buffer_locked vhost: make interval tree static inline vhost: add missing

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Michael S. Tsirkin
> http://qemu-project.org/Features/VirtioCrypto > > I've left some comments below. > > > > > CC: Michael S. Tsirkin <m...@redhat.com> > > CC: Cornelia Huck <cornelia.h...@de.ibm.com> > > CC: Stefan Hajnoczi <stefa...@redhat.com> > > CC: He

Re: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-27 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 04:47:21AM +, Gonglei (Arei) wrote: > Michael, I'd like to add virtio-crypto stuff to your maintaining part likes > the virtio-net/blk parts so that the corresponding patches > can be CC'ed to you too because the virtio-crypto doesn't lay in > driver/virtio directory.

Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-27 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 04:34:56AM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wrote: > > Hi Michael, > > > > Thanks for your feedback firstly! > > > > > -Original Message- > > > From: virtio-.

Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-27 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wrote: > Hi Michael, > > Thanks for your feedback firstly! > > > -Original Message- > > From: virtio-...@lists.oasis-open.org > > [mailto:virtio-...@lists.oasis-open.org] > > On Behalf Of

Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-26 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > Virtio modern devices are always little edian, let's introduce > the LE functions for read/write configuration space for > virtio modern devices, which avoid complaint by Sparse when > we use the virtio_creaed/virtio_cwrite in VIRTIO_1

Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-26 Thread Michael S. Tsirkin
device provides the following > cryptoservices: CIPHER, MAC, HASH, and AEAD. > > For more information about virtio-crypto device, please see: > http://qemu-project.org/Features/VirtioCrypto > > CC: Michael S. Tsirkin <m...@redhat.com> > CC: Cornelia Huck <cornelia

[PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies

2015-03-30 Thread Michael S. Tsirkin
pci code is in ccp-pci.c, don't include pci headers from ccp/ccp-ops.c. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/crypto/ccp/ccp-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c index 8729364..3da1140

[PATCH 15/86] crypto/geode: use uapi/linux/pci_ids.h directly

2015-03-29 Thread Michael S. Tsirkin
Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/crypto/geode-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 80/86] crypto/ccp: drop linux/pci dependencies

2015-03-29 Thread Michael S. Tsirkin
pci code is in ccp-pci.c, don't include pci headers from ccp/ccp-ops.c. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/crypto/ccp/ccp-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c index fd5491d..3da1140

[PATCH 14/86] crypto/ccp: use uapi/linux/pci_ids.h directly

2015-03-29 Thread Michael S. Tsirkin
Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/crypto/ccp/ccp-ops.c | 2 +- drivers/crypto/ccp/ccp-pci.c | 2 +- 2 files changed, 2

[PATCH repost] virtio_rng: drop extra empty line

2015-01-20 Thread Michael S. Tsirkin
makes code look a bit prettier. Cc: linux-crypto@vger.kernel.org. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/char/hw_random/virtio-rng.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c index 72295ea

Re: [PATCH] virtio_rng: drop extra empty line

2015-01-15 Thread Michael S. Tsirkin
On Fri, Jan 16, 2015 at 10:21:09AM +1100, Herbert Xu wrote: On Thu, Jan 15, 2015 at 01:50:42PM +0200, Michael S. Tsirkin wrote: makes code look a bit prettier. Signed-off-by: Michael S. Tsirkin m...@redhat.com Please resend this patch with a cc to linux-crypto@vger.kernel.org. Thanks