Re: [PATCH 02/10] ARM: OMAP3: Fix crypto support for HS devices

2015-05-26 Thread Pali Rohár
Hi Paul, this patch is also for omap2... Can you review it too? On Saturday 28 February 2015 17:24:36 Pavel Machek wrote: On Thu 2015-02-26 14:49:52, Pali Rohár wrote: Register crypto hwmod links only if they are not disabled in DT. If DT information is missing, enable them only for GP

Re: [PATCH 01/10] ARM: OMAP2+: Return correct error values from device and hwmod

2015-05-21 Thread Pali Rohár
On Thursday 26 February 2015 14:49:51 Pali Rohár wrote: Without this patch function pm_runtime_get_sync() returns 0 even when some omap subfunction fails. This patch properly propagate error codes from omap functions back to caller. This patch fix problem, when loading omap-aes driver

Re: [PATCH 00/10] omap3 crypto fixes

2015-05-14 Thread Pali Rohár
On Thursday 14 May 2015 23:34:19 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150514 14:19]: On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: Hi, On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: Are there any fixes in this series that should go

Re: [PATCH 00/10] omap3 crypto fixes

2015-03-15 Thread Pali Rohár
On Sunday 08 March 2015 17:35:13 Paul Walmsley wrote: On Sun, 8 Mar 2015, Pali Rohár wrote: On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: Are there any fixes in this series that should go into v4.0-rc series

Re: [PATCH 00/10] omap3 crypto fixes

2015-03-08 Thread Pali Rohár
to include at least patches 01, 04, 06. Probably those could go to -stable tree... but this decision is up to you. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

[PATCH v2] crypto: omap-sham: Check for return value from pm_runtime_get_sync

2015-03-08 Thread Pali Rohár
Function pm_runtime_get_sync could fail and we need to check return value to prevent kernel crash. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- v2: Check return value for all pm_runtime_get_sync() calls --- drivers/crypto/omap-sham.c | 23 --- 1 file changed, 20

Re: [PATCH 00/10] omap3 crypto fixes

2015-02-27 Thread Pali Rohár
On Thursday 26 February 2015 23:46:05 Aaro Koskinen wrote: Hi, On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote: This patch series fix crypto support for omap3 devices which use DT. It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled for N900

[PATCH 04/10] crypto: omap-sham: Check for return value from pm_runtime_get_sync

2015-02-26 Thread Pali Rohár
Function pm_runtime_get_sync could fail and we need to check return value to prevent kernel crash. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/crypto/omap-sham.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/omap-sham.c b/drivers

[PATCH 00/10] omap3 crypto fixes

2015-02-26 Thread Pali Rohár
This patch series fix crypto support for omap3 devices which use DT. It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled for N900. Pali Rohár (10): ARM: OMAP2+: Return correct error values from device and hwmod ARM: OMAP3: Fix crypto support for HS devices crypto

[PATCH 02/10] ARM: OMAP3: Fix crypto support for HS devices

2015-02-26 Thread Pali Rohár
Register crypto hwmod links only if they are not disabled in DT. If DT information is missing, enable them only for GP devices. Before this patch crypto hwmod links were always disabled for all HS devices and it was not possible to use omap-aes and omap-sham linux drivers. Signed-off-by: Pali

[PATCH 03/10] crypto: omap-sham: Add support for omap3 devices

2015-02-26 Thread Pali Rohár
omap3 support is same as omap2, just with different IO address (specified in DT) Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/crypto/omap-sham.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 3c76696..b20e374

[PATCH 01/10] ARM: OMAP2+: Return correct error values from device and hwmod

2015-02-26 Thread Pali Rohár
Without this patch function pm_runtime_get_sync() returns 0 even when some omap subfunction fails. This patch properly propagate error codes from omap functions back to caller. This patch fix problem, when loading omap-aes driver in qemu cause kernel oops. Signed-off-by: Pali Rohár pali.ro

[PATCH 08/10] ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi

2015-02-26 Thread Pali Rohár
official bootloader and crypto enable bootloader. So we can safely enable sham code. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap3-n900.dts | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot

[PATCH 06/10] ARM: dts: omap3: Add missing dmas for crypto

2015-02-26 Thread Pali Rohár
This patch adds missing dma DTS definitions for omap aes and sham drivers. Without it kernel drivers do not work. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap3.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm

[PATCH 05/10] ARM: dts: omap3 hs: Remove timer12

2015-02-26 Thread Pali Rohár
Device timer12 is automatically disabled on all HS devices via DTS property ti,timer-secure in file omap3.dtsi so it can be safely removed. We do not need to disable it on another place. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap34xx-hs.dtsi |4 arch/arm

[PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-02-26 Thread Pali Rohár
Harmattan system on Nokia N9 and N950 devices uses omap crypto support. Bootloader on those devices is known that it enables HW crypto support. This patch just include omap36xx.dtsi directly, so aes and sham is enabled. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap3

[PATCH 09/10] ARM: dts: omap3-tao3530: Include directly omap34xx.dtsi

2015-02-26 Thread Pali Rohár
This patch just move content of file omap34xx-hs.dtsi into omap3-tao3530.dts. There is no code change, patch is just preparation for removing -hs file. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap3-tao3530.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1

[PATCH 10/10] ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi

2015-02-26 Thread Pali Rohár
These files are not used by any DTS file anymore. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- arch/arm/boot/dts/omap34xx-hs.dtsi | 12 arch/arm/boot/dts/omap36xx-hs.dtsi | 12 2 files changed, 24 deletions(-) delete mode 100644 arch/arm/boot/dts/omap34xx

Re: Nokia N900: omap aes is broken

2015-02-25 Thread Pali Rohár
On Wednesday 25 February 2015 10:50:00 Pavel Machek wrote: On Tue 2015-02-24 09:37:34, Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150224 09:42]: On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150218 16:03]: --- a/arch/arm

Re: Nokia N900: omap aes is broken

2015-02-24 Thread Pali Rohár
On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150218 16:03]: On Wednesday 18 February 2015 22:02:30 Pali Rohár wrote: On Wednesday 18 February 2015 13:21:03 Pali Rohár wrote: Hello, I tried to test OMAP AES driver on Nokia N900

Re: Nokia N900: omap aes is broken

2015-02-24 Thread Pali Rohár
On Tuesday 24 February 2015 18:37:34 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150224 09:42]: On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150218 16:03]: --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +++ b/arch/arm/mach

Re: Nokia N900: omap aes is broken

2015-02-18 Thread Pali Rohár
On Wednesday 18 February 2015 22:02:30 Pali Rohár wrote: On Wednesday 18 February 2015 13:21:03 Pali Rohár wrote: Hello, I tried to test OMAP AES driver on Nokia N900 with special Nokia bootloader which enable L3 firewall for OMAP AES HW support. I modified arch/arm/boot/dts

Re: Nokia N900: omap aes is broken

2015-02-18 Thread Pali Rohár
On Wednesday 18 February 2015 13:21:03 Pali Rohár wrote: Hello, I tried to test OMAP AES driver on Nokia N900 with special Nokia bootloader which enable L3 firewall for OMAP AES HW support. I modified arch/arm/boot/dts/omap34xx-hs.dtsi file and commented aes line which disable aes

Nokia N900: omap aes is broken

2015-02-18 Thread Pali Rohár
in DT or in hwmod? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

[PATCH] CRYPTO: omap-sham: Add missing modalias

2013-10-26 Thread Pali Rohár
From: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com --- drivers/crypto/omap-sham.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 8bdde57..236db0a 100644 ---