Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- eliminate parentheses around the
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_sysfs.c | 2 +-
1 file chan
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma <srishtis...
On Mon, Sep 11, 2017 at 9:54 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
>> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>>
>> Signed-off-by: Srishti Sharma <srishtis..
On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma <srishtis...@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>>
>>
>> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>>
>>> On Mon, Sep 11, 2017 at 9:3
Remove the variable monitor_lock as it is not used anywhere.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-The variable that was not to be declared as volatile can be
eliminated as it is not being used anywhere.
drivers/staging/ccree/ssi_request_mgr.c |
On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>
>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote:
>> > On Mon, Sep 11, 2017 at 09:29:31PM +05
On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.c
The use of volatile for the variable monitor_lock is unnecessary.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_request_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging
On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>
> Coccinelle is not always p
Merge the assignment and return statements to return the value
directly. Done using the following semantic patch by
coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-C
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_sysfs.c | 4 +---
1 file c
On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local ide
Merge the assignment and the return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v4:
-Edit commit message so that it re
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v3:
-Edit commit message so that it respe
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Edit commit message so that it re
On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Return the return value of a function directly, instead of first saving it
>> in a variable and then returning it. This change was mad
Return the return value of a function directly, instead of first saving it in a
variable and then returning it. This change was made using the following
semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --g
Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/s
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtis...@gmail.com> wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging
thers have done. It is not really
> possible to guess correctly. However, one does not generally include the
> extension on a filename.
>
Yes, they have not used the filename in the subject line . So I'll change it to
the required format .
Thanks ,
Srishti
> julia
>
> On Thu, 7 Sep 2017,
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not
On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused
On Thu, Sep 7, 2017 at 2:56 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Thu, 7 Sep 201
On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Remove local variable inflight_counter ,as it is never used.
>
> "counter ,as" -> "counter, as"
>
Remove local variable inflight_counter ,as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v3:
- There was no longer a need to make the comment more comprehensible as
I have deleted the variable associated with it because it is unused .
drivers/s
On Thu, Sep 7, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Edited comment to make it more comprehensible.
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
>> ---
>>
Correct spelling of counter in comment .
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/ccree/ssi_cipher.c
index 8
On Sun, Jun 4, 2017 at 1:49 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote:
>> Added * on subsequent lines of a comment block.
>>
>> Signed-off-by: srishti sharma <srishtis...@gmail.com>
Added *'s on subsequent lines of a comment block to fix coding style issues.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/d
Fixed the alignment of * in a comment block.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto
Fixed trailing */ style issue in a block comment.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging
Added * on subsequent lines of a comment block.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
This patchset contains a series of comment coding style issues fixes.
srishti sharma (4):
Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
comment block.
Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment
block
Staging: ccree: cc_crypto_ctx.h
of them will compile , but the second one is a better
representation of it and does not produce an error on running
checkpatch.pl .
Regards,
Srishti
On Sat, Jun 3, 2017 at 2:07 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sha
Fixed a comment coding style issue , block comments use * on subsequent lines.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_aead.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/s
Fixed a pointer declaration error , the dereferencing operator was misplaced.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_aead.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/s
Fixed a comment coding style issue that generated a warning stating that block
comments should align the * on each line.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
Fixed a comment coding style issue that generated a warning stating block
comments use * on subsequent lines.
Signed-off-by: srishti sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
41 matches
Mail list logo