Re: [PATCH 1/2] crypto: lrw - Fix an error handling path in 'create()'

2017-10-10 Thread walter harms
Am 10.10.2017 08:05, schrieb Christophe JAILLET: > Le 09/10/2017 à 23:22, walter harms a écrit : >> Am 08.10.2017 11:39, schrieb Christophe JAILLET: >>> All error handling paths 'goto err_drop_spawn' except this one. >>> In order to avoid some resources leak, w

Re: [PATCH 1/2] crypto: lrw - Fix an error handling path in 'create()'

2017-10-09 Thread walter harms
Am 08.10.2017 11:39, schrieb Christophe JAILLET: > All error handling paths 'goto err_drop_spawn' except this one. > In order to avoid some resources leak, we should do it as well here. > > Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher") > Signed-off-by: Christophe JAILLET

Re: [PATCH] crypto: zip - Memory corruption in zip_clear_stats()

2017-03-18 Thread walter harms
Am 17.03.2017 21:46, schrieb Dan Carpenter: > There is a typo here. It should be "stats" instead of "state". The > impact is that we clear 224 bytes instead of 80 and we zero out memory > that we shouldn't. > > Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics") >

Re: [patch] crypto: sha256-mb - cleanup a || vs | typo

2016-06-30 Thread walter harms
Am 30.06.2016 13:16, schrieb Joe Perches: > On Thu, 2016-06-30 at 10:50 +0300, Dan Carpenter wrote: >> On Wed, Jun 29, 2016 at 10:05:53AM -0700, H. Peter Anvin wrote: >>> On 06/29/16 07:42, Dan Carpenter wrote: >> and | behave basically the same here but || is intended. It causes a

Re: [PATCH] crypto: qat - fix CTX_ENABLES bits shift direction issue

2015-12-16 Thread walter harms
Am 16.12.2015 03:39, schrieb Yang Pingchao: > AE CTX bits should be 8-15 in CTX_ENABLES, so the mask > value 0xff should be left shifted 0x8. > > Reported-by: Dan Carpenter > Signed-off-by: Yang Pingchao > --- >