Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

[Greg Kroah-Hartman]

On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote:
> Fix wrong indentation and line breaks, including missing tabs,
> breaking lines longer then 80 char or wrongly broken.
> 
> Signed-off-by: Gilad Ben-Yossef 
> ---
>  drivers/staging/ccree/ssi_driver.c | 107 
> +++--
>  1 file changed, 67 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/staging/ccree/ssi_driver.c 
> b/drivers/staging/ccree/ssi_driver.c
> index 81cb63d..0ce2f57 100644
> --- a/drivers/staging/ccree/ssi_driver.c
> +++ b/drivers/staging/ccree/ssi_driver.c
> @@ -87,27 +87,31 @@ void dump_byte_array(const char *name, const u8 
> *the_array, unsigned long size)
>  
>   ret = snprintf(line_buf, sizeof(line_buf), "%s[%lu]: ", name, size);
>   if (ret < 0) {
> - SSI_LOG_ERR("snprintf returned %d . aborting buffer array 
> dump\n", ret);
> + SSI_LOG_ERR
> + ("snprintf returned %d . aborting buffer array dump\n",
> +  ret);

As Joe said, this is pretty bad.  Just move "ret);" to the next line,
and then fix it up so that there are not SSI_LOG_ERR() macros and use
the normal in-kernel printing functions instead, then you will not get
this type of warning.

thanks,

greg k-h

Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

[Joe Perches]

On Tue, 2017-08-15 at 09:26 +0300, Gilad Ben-Yossef wrote:
> Fix wrong indentation and line breaks, including missing tabs,
> breaking lines longer then 80 char or wrongly broken.
[]
> diff --git a/drivers/staging/ccree/ssi_driver.c 
> b/drivers/staging/ccree/ssi_driver.c
[]
> - SSI_LOG_ERR("snprintf returned %d . aborting buffer 
> array dump\n", ret);
> + SSI_LOG_ERR
> + ("snprintf returned %d . aborting buffer array 
> dump\n",
> +  ret);

This change is quite unpleasant to read.