You definitely need to be able to resolve used but not defined and
defined but not used warnings before tackling a driver conversion
like this. In light of this comment I wonder if it would be
appropriate to submit your original driver, that just duplicated
routines from the ppc440spe
On Thu, Sep 30, 2010 at 05:57:10PM -0700, Dan Williams wrote:
[ adding Greg ]
On Thu, Sep 30, 2010 at 5:16 PM, Tirumala Marri tma...@apm.com wrote:
Where ?iop_adma_alloc_slots() is implemented differently between
iop13xx and iop3xx. ?In this case why does ppc440spe-adma.h exist? ?If
it
On Thu, Sep 30, 2010 at 12:08 PM, Wolfgang Denk w...@denx.de wrote:
[snip other valid review comments]
This is a header file, yet you add here literally thousands of lines of
code.
Yes, these functions are entirely too large to be inlined. It looks
like you are trying to borrow too heavily
When reposting a patch, please always indicate that this is new
version by using something like [PATCH v2] in the Subject line.
[Marri] I know, but this patch is not modification of previous patch.
It is complete brand new from scratch again. In that case isn't this
will be first version ?
[ adding Greg ]
On Thu, Sep 30, 2010 at 5:16 PM, Tirumala Marri tma...@apm.com wrote:
Where iop_adma_alloc_slots() is implemented differently between
iop13xx and iop3xx. In this case why does ppc440spe-adma.h exist? If
it has code specific to ppe440spe it should just live in the ppe440spe
