Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 04/18/2016 04:56 PM, Thomas D. wrote: > Hi, > > Milan Broz wrote: >> could you please try backported patches here >> https://mbroz.fedorapeople.org/tmp/3.18/ ? > > This patch set works for me and fixes my reported problem (tested > against 3.18.30). > > Thank you! Excellent, I'll add this

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

Hi, Milan Broz wrote: > could you please try backported patches here > https://mbroz.fedorapeople.org/tmp/3.18/ ? This patch set works for me and fixes my reported problem (tested against 3.18.30). Thank you! -Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-crypto"

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 04/18/2016 02:54 PM, Sasha Levin wrote: > On 04/18/2016 05:48 AM, Thomas D. wrote: >> Hi, >> >> Milan's patches apply against 3.18.30, however I am getting build errors: > > Milan, Herbert, should I just be reverting the offending patches: > > bcfa841 crypto: af_alg - Forbid bind(2) when

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 04/18/2016 05:48 AM, Thomas D. wrote: > Hi, > > Milan's patches apply against 3.18.30, however I am getting build errors: Milan, Herbert, should I just be reverting the offending patches: bcfa841 crypto: af_alg - Forbid bind(2) when nokey child sockets are present eb1ab00 crypto: af_alg -

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

Hi, Milan's patches apply against 3.18.30, however I am getting build errors: > * CC [M] fs/fat/namei_vfat.o > * CC [M] crypto/algif_hash.o > * LD [M] fs/isofs/isofs.o > * CC [M] crypto/algif_skcipher.o > * LD [M] fs/fat/fat.o > *crypto/algif_hash.c:350:13: warning: initialization from

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On Sun, Apr 17, 2016 at 06:39:18PM -0400, Sasha Levin wrote: > > So I mixed stuff up here, I've received a backport that would fix this problem > on 4.1, and applied it. However, I forgot about 3.18. > > Would Milan's backport work on 3.18 as well >

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 04/17/2016 06:17 PM, Thomas D. wrote: > Hi, > > Sasha, can you please revert commit > f857638dd72680e2a8faafef7eebb4534cb39fd1 like Greg did with linux-3.10.101 > >> commit 1f2493fcd87bd810c608aa7976388157852eadb2 >> Author: Greg Kroah-Hartman >> Date: Sat Mar

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

Hi, Sasha, can you please revert commit f857638dd72680e2a8faafef7eebb4534cb39fd1 like Greg did with linux-3.10.101 > commit 1f2493fcd87bd810c608aa7976388157852eadb2 > Author: Greg Kroah-Hartman > Date: Sat Mar 12 21:30:16 2016 -0800 > > Revert: "crypto: af_alg

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/26/2016 06:25 AM, Milan Broz wrote: > On 02/24/2016 06:12 PM, Greg KH wrote: >> On Wed, Feb 24, 2016 at 09:54:48AM +0100, Milan Broz wrote: >>> On 02/24/2016 09:32 AM, Jiri Slaby wrote: > + af_alg_release_parent(sk); and this occurs to me like a double release? >>> >>> yes, my

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On Wed, Feb 24, 2016 at 09:54:48AM +0100, Milan Broz wrote: > On 02/24/2016 09:32 AM, Jiri Slaby wrote: > >> + af_alg_release_parent(sk); > > > > and this occurs to me like a double release? > > yes, my copy mistake. Which is why I want the real patches backported please. Whenever we do a

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/24/2016 09:32 AM, Jiri Slaby wrote: >> +af_alg_release_parent(sk); > > and this occurs to me like a double release? yes, my copy mistake. Anyway, there should be also two more patches from series. If it helps, I copied proper backport here (upstream commit is referenced in header)

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/21/2016, 05:40 PM, Milan Broz wrote: > On 02/20/2016 03:33 PM, Thomas D. wrote: >> Hi, >> >> FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. >> >> v4.3.6 works. Looks like the patch set is only compatible with >=linux-4.3. >> >> v3.12.54 works because it doesn't contain the patch in

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On Wed, Feb 24, 2016 at 01:10:55AM +0100, Thomas D. wrote: > Hi, > > I have applied Milan's patch on top of 4.1.18. I can reboot and open all > of my LUKS-encrypted disks. "cryptsetup benchmark" also works. > > However, don't we need all the recent changes from > "crypto/algif_skcipher.c", too?

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

Hi, I have applied Milan's patch on top of 4.1.18. I can reboot and open all of my LUKS-encrypted disks. "cryptsetup benchmark" also works. However, don't we need all the recent changes from "crypto/algif_skcipher.c", too? -Thomas -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/23/2016 04:02 PM, Milan Broz wrote: > On 02/21/2016 05:40 PM, Milan Broz wrote: >> > On 02/20/2016 03:33 PM, Thomas D. wrote: >>> >> Hi, >>> >> >>> >> FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. >>> >> >>> >> v4.3.6 works. Looks like the patch set is only compatible with >>> >>

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/21/2016 05:40 PM, Milan Broz wrote: > On 02/20/2016 03:33 PM, Thomas D. wrote: >> Hi, >> >> FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. >> >> v4.3.6 works. Looks like the patch set is only compatible with >=linux-4.3. >> >> v3.12.54 works because it doesn't contain the patch in

[PATCH] Re: Broken userspace crypto in linux-4.1.18

On 02/20/2016 03:33 PM, Thomas D. wrote: > Hi, > > FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. > > v4.3.6 works. Looks like the patch set is only compatible with >=linux-4.3. > > v3.12.54 works because it doesn't contain the patch in question. Hi, indeed, because whoever backported