Re: [PATCH] crypto: atmel-sha: remove unnecessary static in atmel_sha_remove()

[Herbert Xu]

Gustavo A. R. Silva  wrote:
> Remove unnecessary static on local variable sha_dd. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
> 
> In the following log you can see a significant difference in the object
> file size. This log is the output of the size command, before and after
> the code change:
> 
> before:
>   textdata bss dec hex filename
>  30005   10264 128   403979dcd drivers/crypto/atmel-sha.o
> 
> after:
>   textdata bss dec hex filename
>  29934   10208  64   402069d0e drivers/crypto/atmel-sha.o
> 
> Signed-off-by: Gustavo A. R. Silva 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: atmel-sha: remove unnecessary static in atmel_sha_remove()

[Gustavo A. R. Silva]

Remove unnecessary static on local variable sha_dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   textdata bss dec hex filename
  30005   10264 128   403979dcd drivers/crypto/atmel-sha.o

after:
   textdata bss dec hex filename
  29934   10208  64   402069d0e drivers/crypto/atmel-sha.o

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/crypto/atmel-sha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index dad4e5b..3e2f41b 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2883,7 +2883,7 @@ static int atmel_sha_probe(struct platform_device *pdev)
 
 static int atmel_sha_remove(struct platform_device *pdev)
 {
-   static struct atmel_sha_dev *sha_dd;
+   struct atmel_sha_dev *sha_dd;
 
sha_dd = platform_get_drvdata(pdev);
if (!sha_dd)
-- 
2.5.0