Re: [PATCH] crypto: ccp - Release locks before returning

[Herbert Xu]

On Mon, Jun 19, 2017 at 12:31:17PM -0500, Gary R Hook wrote:
> krobot warning: make sure that all error return paths release locks.
> 
> Signed-off-by: Gary R Hook 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: ccp - Release locks before returning

[Gary R Hook]

krobot warning: make sure that all error return paths release locks.

Signed-off-by: Gary R Hook 
---
 drivers/crypto/ccp/ccp-debugfs.c |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-debugfs.c b/drivers/crypto/ccp/ccp-debugfs.c
index 6d86693b117f..3cd6c83754e0 100644
--- a/drivers/crypto/ccp/ccp-debugfs.c
+++ b/drivers/crypto/ccp/ccp-debugfs.c
@@ -297,12 +297,11 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
return;
 
write_lock_irqsave(_debugfs_lock, flags);
-   if (!ccp_debugfs_dir) {
+   if (!ccp_debugfs_dir)
ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
-   if (!ccp_debugfs_dir)
-   return;
-   }
write_unlock_irqrestore(_debugfs_lock, flags);
+   if (!ccp_debugfs_dir)
+   return;
 
ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir);
if (!ccp->debugfs_instance)