Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()'

2017-07-20 Thread Arnd Bergmann
On Thu, Jul 20, 2017 at 5:04 PM, Arnd Bergmann wrote: > Coincidentally, I just came across an older patch of mine that actually > fixes the warning properly, but that for some reason ended up not > getting merged: > > https://patchwork.kernel.org/patch/8236811/ > > How about we

Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()'

2017-07-20 Thread Arnd Bergmann
On Thu, Jul 20, 2017 at 9:37 AM, Arnd Bergmann wrote: > On Wed, Jul 19, 2017 at 11:47 PM, Christophe JAILLET > wrote: >> In commit 0f987e25cb8a, the source processing has been moved in front of >> the destination processing, but the error handling

Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()'

2017-07-20 Thread Arnd Bergmann
On Wed, Jul 19, 2017 at 11:47 PM, Christophe JAILLET wrote: > In commit 0f987e25cb8a, the source processing has been moved in front of > the destination processing, but the error handling path has not been > modified accordingly. > Free resources in the correct

[PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()'

2017-07-19 Thread Christophe JAILLET
In commit 0f987e25cb8a, the source processing has been moved in front of the destination processing, but the error handling path has not been modified accordingly. Free resources in the correct order to avoid some leaks. Fixes: 0f987e25cb8a ("crypto: ixp4xx - Fix false lastlen uninitialised