Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Gilad Ben-Yossef
On Mon, May 29, 2017 at 8:36 PM, Joe Perches wrote: > On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote: >> On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: >> > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: >> > > On Sun, May 28,

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Joe Perches
On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote: > On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: > > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: > > > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > > > > cc_crypto_ctx.h had

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Gilad Ben-Yossef
On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: >> On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: >> > cc_crypto_ctx.h had multiple coding style violations reported by >> > checkpatch. Fix them

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Joe Perches
On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > > cc_crypto_ctx.h had multiple coding style violations reported by > > checkpatch. Fix them all. > > Sorry, no. You need to do only one-thing-per-patch, and "fix all

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > cc_crypto_ctx.h had multiple coding style violations reported by > checkpatch. Fix them all. Sorry, no. You need to do only one-thing-per-patch, and "fix all coding style issues is not "one thing". I wouldn't take this kind of

[PATCH 01/12] staging: ccree: correct coding style violations

2017-05-28 Thread Gilad Ben-Yossef
cc_crypto_ctx.h had multiple coding style violations reported by checkpatch. Fix them all. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_crypto_ctx.h | 66 +-- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git