[PATCH 1/1]: Add countersize to CTR

2007-10-23 Thread Joy Latten
This patch adds countersize to CTR mode. The template is now ctr(algo,noncesize,ivsize,countersize). For example, ctr(aes,4,8,4) indicates the counterblock will be composed of a salt/nonce that is 4 bytes, an iv that is 8 bytes and the counter is 4 bytes. When noncesize + ivsize + countersize

Re: [PATCH 1/1]: Add countersize to CTR

2007-10-23 Thread Michael Halcrow
On Tue, Oct 23, 2007 at 03:26:29PM -0500, Joy Latten wrote: + unsigned int countersize; It's somewhat nicer to just use size_t in the kernel for these sorts of data types. If you care about the exact number of bytes used by the variable, types like u32 make the code more parsable. +

Re: [PATCH 1/1]: Add countersize to CTR

2007-10-23 Thread Herbert Xu
On Tue, Oct 23, 2007 at 03:40:08PM -0500, Michael Halcrow wrote: On Tue, Oct 23, 2007 at 03:26:29PM -0500, Joy Latten wrote: + unsigned int countersize; It's somewhat nicer to just use size_t in the kernel for these sorts of data types. If you care about the exact number of bytes used by

Re: [PATCH 1/1]: Add countersize to CTR

2007-10-23 Thread Herbert Xu
On Tue, Oct 23, 2007 at 07:59:22PM -0500, Michael Halcrow wrote: It is usually appropriate to print something to the system log when there is an error condition in the kernel code. That can help triage down the road when people have troubles. The only reason I can think of as to why we

Re: [PATCH 1/1]: Add countersize to CTR

2007-10-23 Thread Michael Halcrow
On Wed, Oct 24, 2007 at 09:19:05AM +0800, Herbert Xu wrote: These paths can be triggered from user-space in future so printks are not appropriate. I am familiar with CryptoDev and Cryproc. Will you be implementing anything similar to what these projects are currently doing? Or do you have