Re: [PATCH 1/2] crypto: Make hwrng choose rng source by quality.

2017-06-30 Thread Harald Freudenberger
On 06/30/2017 07:27 AM, PrasannaKumar Muralidharan wrote: > Hi Harald, > > Can you split this patch into two? One patch to choose rng based on > the quality and another for not overriding user decided rng. > > Some more minor comments below. > > On 29 June 2017 at 15:33, Harald Freudenberger >

Re: [PATCH 1/2] crypto: Make hwrng choose rng source by quality.

2017-06-29 Thread PrasannaKumar Muralidharan
Hi Harald, Can you split this patch into two? One patch to choose rng based on the quality and another for not overriding user decided rng. Some more minor comments below. On 29 June 2017 at 15:33, Harald Freudenberger wrote: > The hwrng core implementation currently

[PATCH 1/2] crypto: Make hwrng choose rng source by quality.

2017-06-29 Thread Harald Freudenberger
The hwrng core implementation currently doesn't consider the quality field of the struct hwrng. So the first registered rng is the winner and further rng sources even with much better quality are ignored. The behavior should be that always the best rng with the highest quality rate should be used