Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-07-04 Thread Herbert Xu
On Sun, Jun 29, 2014 at 01:37:05PM +0200, Stephan Mueller wrote: When looking into the documentation and trying it I found: - bool choices allow me to only select one option, and only one - tristate choices allow me to only select one option, if the initial tristate is set to yes. If

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-07-04 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 22:15:41 schrieb Herbert Xu: Hi Herbert, On Sun, Jun 29, 2014 at 01:37:05PM +0200, Stephan Mueller wrote: When looking into the documentation and trying it I found: - bool choices allow me to only select one option, and only one - tristate choices allow me

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-29 Thread Randy Dunlap
On 06/28/14 22:07, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:20:15 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller smuel...@chronox.de wrote: diff --git a/crypto/drbg.c b/crypto/drbg.c index 6679a26..03a230e 100644 ---

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-29 Thread Stephan Mueller
Am Sonntag, 29. Juni 2014, 00:41:22 schrieb Randy Dunlap: Hi Randy, On 06/28/14 22:07, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:20:15 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller smuel...@chronox.de wrote:

[PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-28 Thread Stephan Mueller
The structure used to construct the module description line was marked problematic by the sparse code analysis tool. The module line description now does not contain any ifdefs to prevent error reports from sparse. The preprocessor warning declaration was reported by sparse. It is replaced in

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-28 Thread Stephen Rothwell
Hi Stephan, On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller smuel...@chronox.de wrote: diff --git a/crypto/drbg.c b/crypto/drbg.c index 6679a26..03a230e 100644 --- a/crypto/drbg.c +++ b/crypto/drbg.c @@ -102,8 +102,13 @@ #if !defined(CONFIG_CRYPTO_DRBG_HASH) \

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-28 Thread Stephan Mueller
Am Sonntag, 29. Juni 2014, 12:20:15 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller smuel...@chronox.de wrote: diff --git a/crypto/drbg.c b/crypto/drbg.c index 6679a26..03a230e 100644 --- a/crypto/drbg.c +++ b/crypto/drbg.c @@