On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote:
Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg:
IOW, I think something like this would make sense:
That looks definitely cleaner :-)
Indeed.. That AAD length-in-the-buffer design came from the over ten
year old code
Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg:
Hi Johannes,
IOW, I think something like this would make sense:
That looks definitely cleaner :-)
Though, my main concern was just to ensure that the aad length value is not
zero.
Ciao
Stephan
--
To unsubscribe from this list: send
Am Donnerstag, 21. Mai 2015, 13:20:49 schrieb Johannes Berg:
Hi Johannes,
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Looks fine - want me to run any
On Mon, 2015-06-01 at 15:49 +0200, Stephan Mueller wrote:
The contents, now, that's a more interesting question. I believe it can
never be all zeroes, since association request frames are not
encrypted/protected and thus at least one byte in here must be non-zero.
The MAC addresses are also
On Mon, 2015-06-01 at 15:21 +0200, Stephan Mueller wrote:
Just a short question on ieee80211_aes_ccm_encrypt,
ieee80211_aes_ccm_decrypt,
ieee80211_aes_gcm_encrypt, ieee80211_aes_gcm_decrypt, ieee80211_aes_gmac: can
the aad parameter of these functions be zero?
What do you mean by zero?
Am Montag, 1. Juni 2015, 15:42:41 schrieb Johannes Berg:
Hi Johannes,
On Mon, 2015-06-01 at 15:21 +0200, Stephan Mueller wrote:
Just a short question on ieee80211_aes_ccm_encrypt,
ieee80211_aes_ccm_decrypt, ieee80211_aes_gcm_encrypt,
ieee80211_aes_gcm_decrypt, ieee80211_aes_gmac: can the aad
On Mon, 2015-06-01 at 16:05 +0200, Johannes Berg wrote:
Ok - here the length is kinda passed a part of the AAD buffer, but this
is really just some arcane code that should be fixed to use a proper
struct. The value there, even though it is __be16 and looks like it came
from the data, is
On Fri, May 22, 2015 at 09:43:28AM +0200, Johannes Berg wrote:
Oops, sorry, of course - I was running in a VM :)
Thanks!
Does this patch on top help?
diff --git a/net/mac80211/aes_gmac.c b/net/mac80211/aes_gmac.c
index 7eee32b..133be53 100644
--- a/net/mac80211/aes_gmac.c
+++
On Fri, May 22, 2015 at 10:18:03AM +0200, Johannes Berg wrote:
Yep, that fixes things.
Great I will respin the patches.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To
On Fri, 2015-05-22 at 15:41 +0800, Herbert Xu wrote:
Did this have a code section at the end? Without it it's difficult
to pin-point the crash because your compiler produces different
output than mine.
Oops, sorry, of course - I was running in a VM :)
[ 26.143579] BUG: unable to handle
On Fri, May 22, 2015 at 09:32:28AM +0200, Johannes Berg wrote:
The CCM and GCM part seems to work, but GMAC causes a kernel crash:
Awesome :)
[ 26.143579] BUG: unable to handle kernel NULL pointer dereference at
(null)
[ 26.144406] IP: [811d9e7d]
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
The CCM and GCM part seems to work, but GMAC causes a kernel crash:
[ 26.143579] BUG: unable to handle kernel
On Fri, 2015-05-22 at 16:05 +0800, Herbert Xu wrote:
On Fri, May 22, 2015 at 09:43:28AM +0200, Johannes Berg wrote:
Oops, sorry, of course - I was running in a VM :)
Thanks!
Does this patch on top help?
Yep, that fixes things.
johannes
--
To unsubscribe from this list: send the line
On Thu, 2015-05-21 at 19:50 +0800, Herbert Xu wrote:
On Thu, May 21, 2015 at 01:20:49PM +0200, Johannes Berg wrote:
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and
On Thu, May 21, 2015 at 01:20:49PM +0200, Johannes Berg wrote:
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Looks fine - want me to run any tests on it?
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/mac80211/aes_ccm.c | 30 ++
net/mac80211/aes_gcm.c | 30
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Looks fine - want me to run any tests on it?
johannes
--
To unsubscribe from this list: send the line
On Thu, May 21, 2015 at 02:17:44PM +0200, Johannes Berg wrote:
Do you have a branch somewhere with all of that?
OK the prerequisite patches are now in cryptodev.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
18 matches
Mail list logo
