Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-08-08 Thread Herbert Xu
On Thu, Aug 03, 2017 at 07:48:51AM +, Horia Geantă wrote: > > Right now it's configured as a DRBG. > If I read correctly, it doesn't matter it's using the internal TRNG for > (automated) seeding, it still shouldn't use hwrng. > This means it's broken since the very beginning: > e24f7c9e87d4

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-08-03 Thread Oleksij Rempel
On 03.08.2017 09:48, Horia Geantă wrote: On 8/3/2017 6:17 AM, Herbert Xu wrote: On Wed, Aug 02, 2017 at 02:03:14PM +, Horia Geantă wrote: Take CAAM's engine HWRNG: it can work both as a TRNG and as a TRNG-seeded DRBG (that's how it's currently configured). IIUC, both setups are fit as

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-08-03 Thread Horia Geantă
On 8/3/2017 6:17 AM, Herbert Xu wrote: > On Wed, Aug 02, 2017 at 02:03:14PM +, Horia Geantă wrote: >> >> Take CAAM's engine HWRNG: it can work both as a TRNG and as a >> TRNG-seeded DRBG (that's how it's currently configured). >> IIUC, both setups are fit as source for the entropy pool. > >

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-08-02 Thread Herbert Xu
On Wed, Aug 02, 2017 at 02:03:14PM +, Horia Geantă wrote: > > Take CAAM's engine HWRNG: it can work both as a TRNG and as a > TRNG-seeded DRBG (that's how it's currently configured). > IIUC, both setups are fit as source for the entropy pool. So which is it? If it's a DRBG then it should not

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-08-02 Thread Horia Geantă
On 7/20/2017 4:08 PM, Harald Freudenberger wrote: > On 07/19/2017 08:13 PM, Oleksij Rempel wrote: >> On Wed, Jul 19, 2017 at 04:53:21PM +, Horia Geantă wrote: >>> On 7/19/2017 7:32 PM, Oleksij Rempel wrote: On Wed, Jul 19, 2017 at 12:49:47PM +, Horia Geantă wrote: > On 7/19/2017

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-07-20 Thread Harald Freudenberger
On 07/19/2017 08:13 PM, Oleksij Rempel wrote: > On Wed, Jul 19, 2017 at 04:53:21PM +, Horia Geantă wrote: >> On 7/19/2017 7:32 PM, Oleksij Rempel wrote: >>> On Wed, Jul 19, 2017 at 12:49:47PM +, Horia Geantă wrote: On 7/19/2017 10:45 AM, Oleksij Rempel wrote: > According

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-07-19 Thread Oleksij Rempel
On Wed, Jul 19, 2017 at 04:53:21PM +, Horia Geantă wrote: > On 7/19/2017 7:32 PM, Oleksij Rempel wrote: > > On Wed, Jul 19, 2017 at 12:49:47PM +, Horia Geantă wrote: > >> On 7/19/2017 10:45 AM, Oleksij Rempel wrote: > >>> According documentation, it is NIST certified TRNG. > >>> So, set

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-07-19 Thread Horia Geantă
On 7/19/2017 7:32 PM, Oleksij Rempel wrote: > On Wed, Jul 19, 2017 at 12:49:47PM +, Horia Geantă wrote: >> On 7/19/2017 10:45 AM, Oleksij Rempel wrote: >>> According documentation, it is NIST certified TRNG. >>> So, set high quality to let the HWRNG framework automatically use it. >>> >>>

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-07-19 Thread Oleksij Rempel
On Wed, Jul 19, 2017 at 12:49:47PM +, Horia Geantă wrote: > On 7/19/2017 10:45 AM, Oleksij Rempel wrote: > > According documentation, it is NIST certified TRNG. > > So, set high quality to let the HWRNG framework automatically use it. > > > > Signed-off-by: Oleksij Rempel

Re: [PATCH v1] crypto: caam - set hwrng quality level

2017-07-19 Thread Horia Geantă
On 7/19/2017 10:45 AM, Oleksij Rempel wrote: > According documentation, it is NIST certified TRNG. > So, set high quality to let the HWRNG framework automatically use it. > > Signed-off-by: Oleksij Rempel > --- > drivers/crypto/caam/caamrng.c | 6 ++ > 1 file

[PATCH v1] crypto: caam - set hwrng quality level

2017-07-19 Thread Oleksij Rempel
According documentation, it is NIST certified TRNG. So, set high quality to let the HWRNG framework automatically use it. Signed-off-by: Oleksij Rempel --- drivers/crypto/caam/caamrng.c | 6 ++ 1 file changed, 6 insertions(+) diff --git