Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-08-21 Thread Herbert Xu
On Wed, Aug 09, 2017 at 11:40:12AM +0200, Corentin Labbe wrote: > > I really didnt see how to do that since cra_type is const. > Anyway, I think it cannot be possible since we could have two different > engine with two different prepare_request(). > > I will really appreciate any advice on what

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-08-09 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 05:01:19PM +0200, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 09:52:57PM +0800, Herbert Xu wrote: > > On Fri, Jul 14, 2017 at 01:15:36PM +0200, Corentin Labbe wrote: > > > On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > > > > On Mon, Jun 19, 2017 at

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-07-28 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 09:52:57PM +0800, Herbert Xu wrote: > On Fri, Jul 14, 2017 at 01:15:36PM +0200, Corentin Labbe wrote: > > On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > > > On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > > > > > > > Since there are two

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-07-28 Thread Herbert Xu
On Fri, Jul 14, 2017 at 01:15:36PM +0200, Corentin Labbe wrote: > On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > > On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > > > > > Since there are two different user of "crypto engine + ablkcipher", it > > > will be not

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-07-14 Thread Corentin Labbe
On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > > > Since there are two different user of "crypto engine + ablkcipher", it will > > be not easy to convert them in one serie. (I could do it, but I simply > > could

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-23 Thread Herbert Xu
On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > Since there are two different user of "crypto engine + ablkcipher", it will > be not easy to convert them in one serie. (I could do it, but I simply could > not test it for OMAP (lack of hw)) > And any new user which want to use

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-19 Thread Corentin Labbe
On Mon, Jun 19, 2017 at 01:27:08PM +0800, Herbert Xu wrote: > On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue skcipher requets by adding all necessary > > functions. >

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-18 Thread Herbert Xu
On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue skcipher requets by adding all necessary > functions. > The only problem is that ablkcipher and skcipher id are the same,

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-06 Thread Corentin Labbe
On Tue, Jun 06, 2017 at 04:07:25PM +0200, Stephan Müller wrote: > Am Dienstag, 6. Juni 2017, 15:44:17 CEST schrieb Corentin Labbe: > > Hi Corentin, > > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue skcipher requets by adding all

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-06 Thread Stephan Müller
Am Dienstag, 6. Juni 2017, 15:44:17 CEST schrieb Corentin Labbe: Hi Corentin, > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue skcipher requets by adding all necessary > functions. > The only problem is that ablkcipher and skcipher id

[PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-06 Thread Corentin Labbe
The crypto engine could actually only enqueue hash and ablkcipher request. This patch permit it to enqueue skcipher requets by adding all necessary functions. The only problem is that ablkcipher and skcipher id are the same, so only one cipher type is usable on the same crypto engine.