Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-10 Thread Stephan Müller
Am Samstag, 10. Juni 2017, 10:59:40 CEST schrieb Herbert Xu: Hi Herbert, > > Indeed, we should just kill the wait or perhaps convert it to > a WARN_ON. As the inflight variable is only used for refcounting and the related wait, I would propose to remove that variable entirely. Ciao Stephan

Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-10 Thread Herbert Xu
On Sat, Jun 10, 2017 at 10:33:28AM +0200, Stephan Müller wrote: > > Right. Shouldn't we drop the ctx->inflight completely? > > The code in the current patch set contains: > > when an async operation is queued: > > sock_hold(sk); > ctx->inflight++; > > upon

Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-10 Thread Stephan Müller
Am Samstag, 10. Juni 2017, 05:13:16 CEST schrieb Herbert Xu: Hi Herbert, > On Tue, May 23, 2017 at 04:31:59PM +0200, Stephan Müller wrote: > > static void skcipher_sock_destruct(struct sock *sk) > > { > > > > struct alg_sock *ask = alg_sk(sk); > > struct skcipher_ctx *ctx =

Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-09 Thread Herbert Xu
On Tue, May 23, 2017 at 04:31:59PM +0200, Stephan Müller wrote: > > static void skcipher_sock_destruct(struct sock *sk) > { > struct alg_sock *ask = alg_sk(sk); > struct skcipher_ctx *ctx = ask->private; > - struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(>req); > +

[PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-05-23 Thread Stephan Müller
The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the