Re: [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-03 Thread Binoy Jayan
Hi Gilad, On 3 January 2017 at 19:53, Gilad Ben-Yossef wrote: > Good idea. I wanted to test the patch but alas it does not apply cleanly. > You seem to have a blank line at the end of files and other small > transgressions that makes checkpatch grumpy. I think that is

[PATCH] crypto: mediatek: don't return garbage err on successful return

2017-01-03 Thread Colin King
From: Colin Ian King In the case where keylen <= bs mtk_sha_setkey returns an uninitialized return value in err. Fix this by returning 0 instead of err. Issue detected by static analysis with cppcheck. Signed-off-by: Colin Ian King ---

Re: [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-03 Thread Gilad Ben-Yossef
Hi Binoy, On Tue, Dec 13, 2016 at 02:19:09PM +0530, Binoy Jayan wrote: > Currently, the iv generation algorithms are implemented in dm-crypt.c. > The goal is to move these algorithms from the dm layer to the kernel > crypto layer by implementing them as template ciphers so they can be >

Re: Geode LX AES/RNG driver triggers warning

2017-01-03 Thread One Thousand Gnomes
On Sat, 31 Dec 2016 00:58:54 +0100 David Gstir wrote: > Hi! > > I recently tested kernel v4.9 on my AMD Geode platform and noticed that its > AES hardware driver triggers this warning on initialization: ... > I narrowed it down to commit 6e9b5e76882c ("hwrng: geode -

Re: [PATCH 0/6] crypto: ARM/arm64 - AES and ChaCha20 updates for v4.11

2017-01-03 Thread Ard Biesheuvel
On 2 January 2017 at 18:21, Ard Biesheuvel wrote: > This series adds SIMD implementations for arm64 and ARM of ChaCha20 (*), > and a port of the ARM bit-sliced AES algorithm to arm64, and > > Patch #1 is a prerequisite for the AES-XTS implementation in #6, which needs >