Re: [PATCH] crypto: Fix next IV issue for CTS template

2017-02-16 Thread Ard Biesheuvel
Hello Libo, On 17 February 2017 at 03:47, wrote: > From: Libo Wang > > CTS template assumes underlying CBC algorithm will carry out next IV for > further process.But some implementations of CBC algorithm in kernel break > this assumption, for example, some hardware crypto

[PATCH] crypto: Fix next IV issue for CTS template

2017-02-16 Thread Libo.Wang
From: Libo Wang CTS template assumes underlying CBC algorithm will carry out next IV for further process.But some implementations of CBC algorithm in kernel break this assumption, for example, some hardware crypto drivers ignore next IV for performance consider, inthis case, tcry cts(cbc(aes))

Re: [PATCH v3 0/2] crypto: AF_ALG memory management fix

2017-02-16 Thread Stephan Müller
Am Donnerstag, 16. Februar 2017, 20:10:21 CET schrieb Herbert Xu: Hi Herbert, > On Wed, Feb 15, 2017 at 09:47:19AM +0100, Stephan Müller wrote: > > as I just saw that you marked my patch with changes requested in > > patchwork, > > may I ask which changes should be applied? > > I thought we

Re: [PATCH v3 0/2] crypto: AF_ALG memory management fix

2017-02-16 Thread Herbert Xu
On Wed, Feb 15, 2017 at 09:47:19AM +0100, Stephan Müller wrote: > > as I just saw that you marked my patch with changes requested in patchwork, > may I ask which changes should be applied? I thought we agreed that we would not do the TX offset thing and keep the existing semantics of consuming

[bug report] crypto: cavium - Add the Virtual Function driver for CPT

2017-02-16 Thread Dan Carpenter
Hello George Cherian, This is a semi-automatic email about new static checker warnings. The patch c694b233295b: "crypto: cavium - Add the Virtual Function driver for CPT" from Feb 7, 2017, leads to the following Smatch complaint: drivers/crypto/cavium/cpt/cptvf_main.c:899 cptvf_remove()

[PATCH v4 2/2] crypto: aead AF_ALG - overhaul memory management

2017-02-16 Thread Stephan Müller
The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

[PATCH v4 0/2] crypto: AF_ALG memory management fix

2017-02-16 Thread Stephan Müller
Hi Herbert, Changes v4: * replace ctx->processed with a maintenance of a private recvmsg TX SGL * algif_skcipher: rename skcipher_sg_list into skcipher_tsgl to make it consistent with algif_aead to prepare for a code consolidation Changes v3: * in *_pull_tsgl: make sure ctx->processed cannot

[PATCH v4 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-02-16 Thread Stephan Müller
The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

[PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-16 Thread Joe Perches
There are ~4300 uses of pr_warn and ~250 uses of the older pr_warning in the kernel source tree. Make the use of pr_warn consistent across all kernel files. This excludes all files in tools/ as there is a separate define pr_warning for that directory tree and pr_warn is not used in tools/. Done

[PATCH 15/35] drivers/crypto: Convert remaining uses of pr_warning to pr_warn

2017-02-16 Thread Joe Perches
To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/crypto Prior to this patch, there were 3 uses of pr_warning and 12 uses of pr_warn in drivers/crypto Signed-off-by: Joe Perches --- drivers/crypto/n2_core.c | 12 ++-- 1 file