Re: crypto: al_alg: alg_setkey does not check key's size is zero or not, causing a Null-ptr-dereference

On Fri, May 05, 2017 at 03:59:28PM +0300, Dan Carpenter wrote: > Thanks for the Report. I've fowarded it to Herbert Xu. Thanks. This is a bug in the new skcipher interface. ---8<--- Subject: crypto: skcipher - Add missing API setkey checks The API setkey checks for key sizes and alignment

[PATCH] crypto: rng - move __crypto_rng_cast to the rng header

This patch move __crypto_rng_cast() to the right header like other __algo_cast functions. Signed-off-by: Corentin Labbe --- crypto/rng.c | 5 - include/crypto/rng.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/crypto/rng.c

[PATCH] crypto: glue_helper - Delete some dead code

We checked (nbytes < bsize) inside the loops so it's not possible to hit the "goto done;" here. This code is cut and paste from other slightly different loops where we don't have the check inside the loop. Signed-off-by: Dan Carpenter diff --git

[PATCH] crypto: aes_ti - fix comment for MixColumns step

From: Eric Biggers mix_columns() contains a comment which shows the matrix used by the MixColumns step of AES, but the last entry in this matrix was incorrect --- and did not match the code, which is correct. Fix the comment. Signed-off-by: Eric Biggers