Re: get_random_bytes returns bad randomness before seeding is complete

On Sat, Jun 3, 2017 at 7:04 AM, Theodore Ts'o wrote: > has been pretty terrible? > This kind of "my shit doesn't stink, but yours does", is not > The reason why I keep harping on this is because I'm concerned about > an absolutist attitude towards technical design, where the good

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > Fixed block comments across whole ccree driver > > Version #1 has some trailing white space issue in a few patches Some of these applied, some did not :(

Re: [PATCH V2 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

On Tue, May 30, 2017 at 06:09:54PM +1200, Derek Robson wrote: > Fixed block comment alignment, Style fix only > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/ccree/ssi_sysfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not

Re: [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

On Wed, May 31, 2017 at 06:24:55PM +0530, srishti sharma wrote: > Fixed a comment coding style issue that generated a warning stating that > block comments should align the * on each line. > Please properly line-wrap your changelog comments :( You also sent 2 different patches, that did

Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote: > Fixed a pointer declaration error , the dereferencing operator was misplaced. Odd use of a , Also, I don't understand what was "misplaced" here? There does not seem to be a "error" fixed here...

Re: [PATCH v2 02/20] staging: ccree: replace bit shift with BIT macro

On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote: > CC_CTX_SIZE was being defined using a hand rolled bit shift operation. > Replace with use of BIT macro. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_crypto_ctx.h | 2 +- > 1 file

[PATCH] Staging: ccree: ssi_aead.h: Fixed a comment coding style issue.

Fixed a comment coding style issue , block comments use * on subsequent lines. Signed-off-by: srishti sharma --- drivers/staging/ccree/ssi_aead.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h

Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

Hey, checkpatch.pl generated two errors , because the dereferencing operator was placed next to the structure name instead of being placed with the pointer . for eg: struct scatterlist* srcSgl; (this was giving an error) whereas struct scatterlist *srcSgl; (this did not give an error) Both

Re: get_random_bytes returns bad randomness before seeding is complete

Stephan's driver, the HAVEGE system & several others purport to extract entropy from a series of timer calls. Probably the best analysis is in the Mcguire et al. paper at https://static.lwn.net/images/conf/rtlws11/random-hardware.pdf & the simplest code in my user-space driver at

[PATCH][V2] staging: ccree: fix spelling mistake: "chanined" -> "chained"

From: Colin Ian King Trivial fix to spelling mistake in SSI_LOG_ERR message Signed-off-by: Colin Ian King --- drivers/staging/ccree/ssi_buffer_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/4] Fixed comment coding style issues.

This patchset contains a series of comment coding style issues fixes. srishti sharma (4): Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block. Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block Staging: ccree: cc_crypto_ctx.h:

[PATCH] taging: ccree: fix spelling mistake: "chanined" -> "chained"

From: Colin Ian King Trivial fix to spelling mistake in SSI_LOG_ERR message Signed-off-by: Colin Ian King --- drivers/staging/ccree/ssi_buffer_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Added * on subsequent lines of a comment block. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h index

Re: [kernel-hardening] Re: get_random_bytes returns bad randomness before seeding is complete

On 3 June 2017 at 18:54, Jeffrey Walton wrote: > On Sat, Jun 3, 2017 at 5:45 PM, Sandy Harris wrote: >> ... >> Of course this will fail on systems with no high-res timer. Are there >> still some of those? It might be done in about 1000 times as long on

[PATCH 3/4] Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment block

Fixed the alignment of * in a comment block. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h

[PATCH 2/4] Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block

Fixed trailing */ style issue in a block comment. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h

[PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block

Added *'s on subsequent lines of a comment block to fix coding style issues. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h

Re: get_random_bytes returns bad randomness before seeding is complete

Am Freitag, 2. Juni 2017, 16:59:56 CEST schrieb Jason A. Donenfeld: Hi Jason, > > Alternatively, I'm open to other solutions people might come up with. How about stirring in some data from the Jitter RNG that we have in the kernel already and that is used for the DRBG in case get_random_bytes

Re: [PATCH v2 02/20] staging: ccree: replace bit shift with BIT macro

On Sat, Jun 3, 2017 at 11:46 AM, Greg Kroah-Hartman wrote: > On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote: >> CC_CTX_SIZE was being defined using a hand rolled bit shift operation. >> Replace with use of BIT macro. >> >> Signed-off-by: Gilad

Re: get_random_bytes returns bad randomness before seeding is complete

On Sun, Jun 4, 2017 at 1:48 AM, Stephan Müller wrote: > Am Freitag, 2. Juni 2017, 16:59:56 CEST schrieb Jason A. Donenfeld: > >> Alternatively, I'm open to other solutions people might come up with. > > How about stirring in some data from the Jitter RNG that we have in the

Re: get_random_bytes returns bad randomness before seeding is complete

Am Sonntag, 4. Juni 2017, 00:54:39 CEST schrieb Jeffrey Walton: Hi Jeffrey, > On Sat, Jun 3, 2017 at 5:45 PM, Sandy Harris wrote: > > ... > > Of course this will fail on systems with no high-res timer. Are there > > still some of those? It might be done in about 1000

Re: get_random_bytes returns bad randomness before seeding is complete

On Sat, Jun 3, 2017 at 5:45 PM, Sandy Harris wrote: > ... > Of course this will fail on systems with no high-res timer. Are there > still some of those? It might be done in about 1000 times as long on a > system that lacks the realtime library's nanosecond timer but has