Re: [dm-devel] [PATCH v5 12/19] dm: move dm-verity to generic async completion

On Sat, Aug 19, 2017 at 11:08 PM, Mikulas Patocka wrote: > > > > On Mon, 14 Aug 2017, Gilad Ben-Yossef wrote: > > > dm-verity is starting async. crypto ops and waiting for them to complete. > > Move it over to generic code doing the same. > > > > This also fixes a possible

[PATCH 1/2] crypto: add OSCCA SM3 secure hash

Add OSCCA SM3 secure hash (OSCCA GM/T 0004-2012 SM3) generic hash transformation. Signed-off-by: Gilad Ben-Yossef --- crypto/Kconfig| 11 +++ crypto/Makefile | 1 + crypto/sm3_generic.c | 210 ++

[PATCH 0/2] crypto: add OSCCA SM3 secure hash and tests

Add OSCCA SM3 secure hash (OSCCA GM/T 0004-2012 SM3) generic hash transformation, testmgr and tcrypt tests. SM3 is a secure hash function which is part of the Chinese "Commercial Cryptography" suite of algorithms which use is required for certain commercial applications in China. References:

[PATCH 2/2] crypto: add SM3 test vectors

Add testmgr and tcrypt tests and vectors for SM3 secure hash. Signed-off-by: Gilad Ben-Yossef --- crypto/tcrypt.c | 14 +++- crypto/testmgr.c | 6 + crypto/testmgr.h | 67 3 files changed, 86

Re: [PATCH v5 05/19] crypto: introduce crypto wait for async op

On Tue, Aug 15, 2017 at 5:23 AM, Jonathan Cameron wrote: > On Mon, 14 Aug 2017 18:21:15 +0300 > Gilad Ben-Yossef wrote: > >> Invoking a possibly async. crypto op and waiting for completion >> while correctly handling backlog processing is a

Re: [PATCH v8 3/4] crypto: AF_ALG -- add asymmetric cipher

On 08/21/2017 11:55 AM, Tudor Ambarus wrote: Hi, Stephan, +static int akcipher_setprivkey(void *private, const u8 *key, + unsigned int keylen) +{ +struct akcipher_tfm *tfm = private; +struct crypto_akcipher *akcipher = tfm->akcipher; +int err; + +err =

Re: [PATCH v8 3/4] crypto: AF_ALG -- add asymmetric cipher

Hi, Stephan, +static int akcipher_setprivkey(void *private, const u8 *key, + unsigned int keylen) +{ + struct akcipher_tfm *tfm = private; + struct crypto_akcipher *akcipher = tfm->akcipher; + int err; + + err =

Re: [PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote: > From: Carlo Caione > > We have found some ACER laptops shipping with certificates signed using > the 1.3.14.3.2.29 OID. This is causing the message /cut Ping on this (literally) two lines patch. --

Re: [PATCH v8 3/4] crypto: AF_ALG -- add asymmetric cipher

Am Montag, 21. August 2017, 11:23:55 CEST schrieb Tudor Ambarus: Hi Tudor, > > Oops, I missed the negation. When crypto_akcipher_set_priv_key succeeds > you return the akcipher_maxsize. Not a bad idea, you save few cpu > cycles. I was hoping to save some context switches. > > > crypto

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

On Wed, Aug 09, 2017 at 11:40:12AM +0200, Corentin Labbe wrote: > > I really didnt see how to do that since cra_type is const. > Anyway, I think it cannot be possible since we could have two different > engine with two different prepare_request(). > > I will really appreciate any advice on what

[PATCH v6 00/19] simplify crypto wait for async op

Many users of kernel async. crypto services have a pattern of starting an async. crypto op and than using a completion to wait for it to end. This patch set simplifies this common use case in two ways: First, by separating the return codes of the case where a request is queued to a backlog due

[PATCH v6 19/19] crypto: adapt api sample to use async. op wait

The code sample is waiting for an async. crypto op completion. Adapt sample to use the new generic infrastructure to do the same. This also fixes a possible data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait

[PATCH v6 07/19] crypto: move pub key to generic async completion

public_key_verify_signature() is starting an async crypto op and waiting for it to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/asymmetric_keys/public_key.c | 28 1 file changed, 4

[PATCH v6 08/19] crypto: move drbg to generic async completion

DRBG is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating crypto request memory allocation may use GFP_KERNEL which should be perfectly fine as the code is obviously sleeping for

[PATCH v6 04/19] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef Acked-by: Boris Brezillon ---

[PATCH v6 17/19] crypto: qce: move to generic async completion

The qce driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/qce/sha.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-)

[PATCH v6 11/19] fscrypt: move to generic async completion

fscrypt starts several async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- fs/crypto/crypto.c | 28 fs/crypto/fname.c | 36

[PATCH v6 10/19] crypto: move testmgr to generic async completion

testmgr is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also provides a test of the generic crypto async. wait code. Signed-off-by: Gilad Ben-Yossef --- crypto/testmgr.c | 204

[PATCH v6 12/19] dm: move dm-verity to generic async completion

dm-verity is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also avoids a future potential data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait

[PATCH v6 09/19] crypto: move gcm to generic async completion

gcm is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/gcm.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/crypto/gcm.c

[PATCH v6 01/19] crypto: change transient busy return code to -EAGAIN

The crypto API was using the -EBUSY return value to indicate both a hard failure to submit a crypto operation into a transformation provider when the latter was busy and the backlog mechanism was not enabled as well as a notification that the operation was queued into the backlog when the backlog

[PATCH v6 03/19] crypto: remove redundant backlog checks on EBUSY

Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef --- crypto/ahash.c| 12 +++- crypto/cts.c | 6

[PATCH v6 02/19] crypto: ccp: use -EAGAIN for transient busy indication

Replace -EBUSY with -EAGAIN when reporting transient busy indication in the absence of backlog. Signed-off-by: Gilad Ben-Yossef Reviewed-by: Gary R Hook --- drivers/crypto/ccp/ccp-crypto-main.c | 8 +++- drivers/crypto/ccp/ccp-dev.c | 7

[PATCH v6 15/19] crypto: tcrypt: move to generic async completion

tcrypt starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/tcrypt.c | 84 + 1 file changed, 25 insertions(+), 59

[PATCH v6 16/19] crypto: talitos: move to generic async completion

The talitos driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/talitos.c | 38 +- 1 file changed, 5 insertions(+), 33

[PATCH v6 14/19] ima: move to generic async completion

ima starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 56

[PATCH v6 13/19] cifs: move to generic async completion

cifs starts an async. crypto op and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 30 -- 1 file changed, 4

[PATCH v6 18/19] crypto: mediatek: move to generic async completion

The mediatek driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Ryder Lee --- drivers/crypto/mediatek/mtk-aes.c | 31

[PATCH v6 06/19] crypto: move algif to generic async completion

algif starts several async crypto ops and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/af_alg.c | 27 --- crypto/algif_aead.c | 8 crypto/algif_hash.c |

[PATCH v6 05/19] crypto: introduce crypto wait for async op

Invoking a possibly async. crypto op and waiting for completion while correctly handling backlog processing is a common task in the crypto API implementation and outside users of it. This patch adds a generic implementation for doing so in preparation for using it across the board instead of hand

Re: [PATCH 2/6] crypto: jz4780-rng: Make ingenic CGU driver use syscon

Hi PrasannaKumar, On Sunday, 20 August 2017 09:12:12 PDT PrasannaKumar Muralidharan wrote: > > Could you instead perhaps: > > - Just add "syscon" as a second compatible string to the CGU node in the > > > >device tree, but otherwise leave it as-is without the extra > >cgu_registers > >