Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-17 Thread Suniel Mahesh
On Monday 17 July 2017 06:03 PM, Greg KH wrote: > On Sat, Jul 15, 2017 at 01:21:54PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh <suni...@techveda.org> >> >> It is recommended to use managed function devm_kzalloc, which >> simplifies dri

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-27 Thread Suniel Mahesh
On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Suniel Mahesh
On Thursday 05 October 2017 11:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: >> On Wed, Oct 4, 2017 at 10:12 PM, wrote: >>> There is no need to create a local pointer variable "dev" and >>> pass it various API's, instead use plat_dev

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-19 Thread Suniel Mahesh
gs which I am working on and there by improving myself. Yeah English is not my first language, but all my education was done in English, no issues there. > > On Wed, Oct 18, 2017 at 12:11:55PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh <suni...@techveda.org> >> &