Hello LABBE,
On 19.10.2014 17:16, LABBE Corentin wrote:
> Add support for the Security System included in Allwinner SoC A20.
> The Security System is a hardware cryptographic accelerator that support
> AES/MD5/SHA1/DES/3DES/PRNG algorithms.
>
> Signed-off-by: LABBE Corentin
> ---
> drivers/cry
Hi Corentin,
On 21.10.2014 19:25, Corentin LABBE wrote:
> On 10/21/14 01:28, Vladimir Zapolskiy wrote:
>> Hello LABBE,
>>
>> On 19.10.2014 17:16, LABBE Corentin wrote:
>>> Add support for the Security System included in Allwinner SoC A20.
>>> The Secu
Hello James,
On 10.11.2014 14:10, James Hartley wrote:
> This adds support for the Imagination Technologies hash
> accelerator that provides hardware acceleration for
> SHA1 SHA224 SHA256 and MD5 Hashes.
>
> Signed-off-by: James Hartley
> ---
[snip]
> diff --git a/drivers/crypto/img-hash.c b/d
Hi James,
On 11.11.2014 16:59, James Hartley wrote:
> Hi Vladimir, thanks for the review!
>
>> -Original Message-----
>> From: Vladimir Zapolskiy [mailto:vladimir_zapols...@mentor.com]
>> Sent: 10 November 2014 15:10
>> To: James Hartley; herb...@gondor.apa
Hello Kamil,
thank you for the change, please find below a number of minor
review comments.
On 10/09/2017 02:12 PM, Kamil Konieczny wrote:
> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
> It uses the crypto framework asynchronous hash api.
> It is based on omap-sham.c driver.
Hi Kamil,
thank you for updates, I have just a few more comments.
On 10/17/2017 02:28 PM, Kamil Konieczny wrote:
> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
> It uses the crypto framework asynchronous hash api.
> It is based on omap-sham.c driver.
> S5P has some HW differen
Hi Kamil,
On 10/17/2017 02:28 PM, Kamil Konieczny wrote:
> change spaces into tabs in defines
Here a grammatically correct sentence in English is welcome.
>
> Signed-off-by: Kamil Konieczny
> ---
Please feel free to add a tag
Acked-by: Vladimir Zapolskiy
--
With best wishes,
Vladimir
Hi Kamil,
On 10/24/2017 01:19 PM, Kamil Konieczny wrote:
> Hi Vladimir,
>
> Thank you for review.
>
> On 22.10.2017 12:18, Vladimir Zapolskiy wrote:
>> Hi Kamil,
>>
>> On 10/17/2017 02:28 PM, Kamil Konieczny wrote:
>>> change spaces into tabs in
l apply almost all of your remarks,
> see answers below.
>
> On 22.10.2017 12:18, Vladimir Zapolskiy wrote:
>> Hi Kamil,
>>
>> thank you for updates, I have just a few more comments.
>>
[snip]
>>> +/**
>>> + * s5p_hash_import - import hash state
The change fixes potential oops while accessing iomem on invalid
address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never
returns NULL, which makes useless a following check for NULL.
Signed-off-by: Vladimir Zapolskiy
Fixes
The change fixes potential oops while accessing iomem on invalid
address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never
returns NULL, which makes useless a following check for NULL.
Signed-off-by: Vladimir Zapolskiy
Fixes
5000+ goto labels one day,
though it is better to have an officially agreed policy beforehand.
Anyway I do not strictly object against the change, see one my comment
below and feel free to add my
Acked-by: Vladimir Zapolskiy
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/c
like
s5p-sss etc.
Anyway since it is a valid improvement, please feel free to add my
Acked-by: Vladimir Zapolskiy
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/crypto/s5p-sss.c | 149
> +++
> 1 file changed, 137 insertio
Hi Krzysztof,
On 07.03.2016 06:05, Krzysztof Kozlowski wrote:
> On 07.03.2016 10:01, Vladimir Zapolskiy wrote:
>> Hi Krzysztof,
>>
>> On 06.03.2016 12:17, Krzysztof Kozlowski wrote:
>>> Remove unneeded inclusion of delay.h and get rid of indentation from
>>
On 11.03.2016 16:06, Steffen Trumtrar wrote:
> The driver is ported from Freescales Linux git and can be
> found in the
>
> vendor/freescale/imx_2.6.35_maintain
>
> branch.
>
> According to that code, the RNGC is found on Freescales i.MX3/5 SoCs.
> The i.MX2x actually has an RNGB, which ha
_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> + depends on HAS_IOMEM && HAS_DMA
> select CRYPTO_AES
> select CRYPTO_BLKCIPHER
> help
>
Acked-by: Vladimir Zapolskiy
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "u
On 10.03.2016 03:31, Krzysztof Kozlowski wrote:
> Sort the headers alphabetically to improve readability and to spot
> duplications easier.
>
> Suggested-by: Vladimir Zapolskiy
> Signed-off-by: Krzysztof Kozlowski
>
> ---
>
> Changes since v1:
> 1. New patch.
On 26.03.2016 20:06, Jeffrey Walton wrote:
> Hi Everyone,
>
> Please forgive my ignorance here... I'm trying to detect the
> availability of asynchronous ciphers support at runtime. The back
> story is there's some feature tests going on based on hard coded
> kernel version numbers (namely, 4.1).
ash interrupt bit.
>
> Driver does not provide hash functions so it is safe to remove the hash
> interrupt related code and to not require the interrupt in Device Tree.
>
> Signed-off-by: Krzysztof Kozlowski
Thank you for the change.
Acked-by: Vladimir Zapolskiy
> ---
>
rt have just applied the changes, but anyway I reviewed
them and they are good in my opinion.
Acked-by: Vladimir Zapolskiy
> ---
> drivers/crypto/s5p-sss.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 4
rypto: s5p-sss - add S5PV210 advanced crypto engine
> support")
> Fixes: 9e4a1100a445 ("crypto: s5p-sss - Handle unaligned buffers")
> Cc:
> Signed-off-by: Marek Szyprowski
Acked-by: Vladimir Zapolskiy
thank you for the fix.
--
With best wishes,
Vladimir
--
To unsubsc
g usage of such indentation and lack of it.
>When removing indentation, reorder variables in
>reversed-christmas-tree order with first variables being initialized
>ones.
>
> Signed-off-by: Krzysztof Kozlowski
it looks like a trivial and nice change, thank you.
Acked-by: Vla
Hi Krzysztof,
On 03/10/2017 09:10 PM, Krzysztof Kozlowski wrote:
> Beside developing of this driver recently, I handle also reviews and
> bug reports from users so having a maintainer entry will ensure that I
> will be CC-ed on important emails.
if you assume that the driver needs a special maint
On 03/11/2017 08:11 AM, Krzysztof Kozlowski wrote:
> Add Krzysztof Kozlowski and Vladimir Zapolskiy as maintainers of s5p-sss
> driver for handling reviews, testing and getting bug reports from the
> users.
>
> Cc: Vladimir Zapolskiy
> Cc: Herbert Xu
> Signed-off-by
Hello Herbert,
I'm trying to implement a driver for one hardware crypto engine, and
on the current stage I work with AES algorithm, and I have a couple of
open questions.
1) What shall be guaranteed from crypto engine by providing
cra_blocksize and cra_alignmask values in crypto_alg definition
This change adds support for AES encrypting and decrypting using
advanced crypto engine found on Samsung S5PV210 and S5PC110 SoCs.
Signed-off-by: Vladimir Zapolskiy
---
drivers/crypto/Kconfig | 11 +
drivers/crypto/Makefile |1 +
drivers/crypto/s5p-sss.c | 701
On 26.11.2011 15:26, Axel Lin wrote:
> This patch converts the drivers in drivers/crypto/* to use the
> module_platform_driver() macro which makes the code smaller and a bit
> simpler.
>
> Cc: James Hsiao
> Cc: Sebastian Andrzej Siewior
> Cc: Vladimir Zapolskiy
> Cc: Jamie
perform cleanup to remove all unneeded initializations
of this field in 'crypto/drivers/'.
Cc: Kent Yoder
Cc: Benjamin Herrenschmidt
Cc: linux-ge...@lists.infradead.org
Cc: Michal Ludvig
Cc: Dmitry Kasatkin
Cc: Varun Wadekar
Cc: Vladimir Zapolskiy
Cc: Eric Bénard
Signed-off-by: Jussi Kivilin
ata->clk);
s5p_dev = NULL;
- platform_set_drvdata(pdev, NULL);
return 0;
}
Acked-by: Vladimir Zapolskiy
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger
)
for which
1. AES register are at an offset of 0x200 and
2. hash interrupt is not available
Signed-off-by: Naveen Krishna Ch
CC: Herbert Xu
CC: David S. Miller
CC: Vladimir Zapolskiy
TO:
CC:
---
Changes since v2:
1. Added variant struct to handle the differences in SSS modules
2. Changed the
ged in.
Its has got reviewed and re-based several times and got acked by a
couple of seniors.
Do you want me to pick these series up?
Cheers,
thank you for this changeset, in my opinion it is quite good. To all changes
Acked-by: Vladimir Zapolskiy
--
With best wishes,
Vladimir
--
To unsubs
The driver works well on i.MX31 powered boards with device description
taken from board device tree, the only change to add to the driver is
the missing OF device id, the affected list of included headers and
platform driver struct are beautified a little.
Signed-off-by: Vladimir Zapolskiy
The series is a trivial change to extend Freescale i.MX31 RNGA
driver to work on boards with device description taken from device
tree blob. The change was tested on a legacy LogicPD MX31Lite board.
Vladimir Zapolskiy (2):
dt-bindings: rng: Document Freescale i.MX31 RNGA compatible
hwrng: mxc
the documentation file has no more potential for further extensions,
nevertheless generalize it by removing explicit RNGC specifics.
Signed-off-by: Vladimir Zapolskiy
---
.../devicetree/bindings/rng/{imx-rngc.txt => imx-rng.txt} | 10 --
1 file changed, 4 insertions(+), 6 deleti
On 02/27/2018 05:49 PM, Kim Phillips wrote:
> On Mon, 26 Feb 2018 20:38:49 +0200
> Vladimir Zapolskiy wrote:
>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id mxc_rnga_of_match[] = {
>> +{ .compatible = "fsl,imx31-rnga", },
>> +{ /* se
On 02/27/2018 09:39 PM, Kim Phillips wrote:
> On Tue, 27 Feb 2018 18:53:08 +0200
> Vladimir Zapolskiy wrote:
>
>> On 02/27/2018 05:49 PM, Kim Phillips wrote:
>>> On Mon, 26 Feb 2018 20:38:49 +0200
>>> Vladimir Zapolskiy wrote:
>>>
>>>> +#
On 02/27/2018 10:07 PM, Vladimir Zapolskiy wrote:
> On 02/27/2018 09:39 PM, Kim Phillips wrote:
>> On Tue, 27 Feb 2018 18:53:08 +0200
>> Vladimir Zapolskiy wrote:
>>
>>> On 02/27/2018 05:49 PM, Kim Phillips wrote:
>>>> On Mon, 26 Feb 2018 20:
The series is a trivial change to extend Freescale i.MX31 RNGA
driver to work on boards with device description taken from device
tree blob. The change was tested on a legacy LogicPD MX31Lite board.
Vladimir Zapolskiy (2):
dt-bindings: rng: Document Freescale i.MX21 and i.MX31 RNGA compatibles
The driver works well on i.MX31 powered boards with device description
taken from board device tree, the only change to add to the driver is
the missing OF device id, the affected list of included headers and
indentation in platform driver struct are beautified a little.
Signed-off-by: Vladimir
, apparently
the documentation file has no more potential for further extensions,
nevertheless generalize it by removing explicit RNGC specifics.
Signed-off-by: Vladimir Zapolskiy
Reviewed-by: Rob Herring
---
Changes from v1 to v2:
* added i.MX21 RNGA compatible, i.MX31 RNGA is backward compatible to it
Hi Fabio,
On 03/06/2018 12:24 AM, Fabio Estevam wrote:
> Hi Vladimir,
>
> On Mon, Mar 5, 2018 at 7:21 PM, Vladimir Zapolskiy wrote:
>> The driver works well on i.MX31 powered boards with device description
>> taken from board device tree, the only change to add to the dri
for S5P Security Subsystem crypto accelerator.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Vladimir Zapolskiy
--
Best wishes,
Vladimir
Acked-by: Dmitry Torokhov
Acked-by: Linus Walleij
Signed-off-by: Uwe Kleine-König
For drivers/memory/pl172.c:
Acked-by: Vladimir Zapolskiy
--
Best wishes,
Vladimir
43 matches
Mail list logo
