Re: [PATCH] fix ptr_ret.cocci warnings

[Stephan Müller]

Am Montag, 15. Mai 2017, 12:52:11 CEST schrieb Julia Lawall:

Hi Julia,

> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci

Thank you, included -- it will be present in the next release.

Ciao
Stephan

[PATCH] fix ptr_ret.cocci warnings

[Julia Lawall]

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Stephan Müller 
Signed-off-by: Julia Lawall 
Signed-off-by: Fengguang Wu 
---

Not very important, but the code can be a little simpler.

 lrng_base.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/char/lrng_base.c
+++ b/drivers/char/lrng_base.c
@@ -1523,10 +1523,7 @@ static int lrng_alloc(void)
lrng_init_rng(key, sizeof(key));
lrng_pool.lrng_hash = lrng_hash_alloc(LRNG_HASH_NAME, key, sizeof(key));
memzero_explicit(key, sizeof(key));
-   if (IS_ERR(lrng_pool.lrng_hash))
-   return PTR_ERR(lrng_pool.lrng_hash);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(lrng_pool.lrng_hash);
 }

 /** LRNG kernel interfaces ***/