Re: [PATCH 00/12] staging: ccree: coding style fixes

2017-07-14 Thread Gilad Ben-Yossef 
On Fri, Jul 14, 2017 at 2:39 PM, Greg Kroah-Hartman
 wrote:
> On Thu, Jul 13, 2017 at 11:19:50AM +0300, Gilad Ben-Yossef wrote:
>> Another batch of ccree coding style fixes.
>>
>> These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues 
>> in ssi_sysfs.c")
>> in staging-testing.
>
> Odd, some of these did not apply, but others did.  Please rebase your
> series and resend what I didn't pick up this time.

That is weird.

I am away about to board a flight and will be away for few days but
will check up on this when I'm back.

Sorry about that and thanks,
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Re: [PATCH 00/12] staging: ccree: coding style fixes

2017-07-14 Thread Greg Kroah-Hartman 
On Thu, Jul 13, 2017 at 11:19:50AM +0300, Gilad Ben-Yossef wrote:
> Another batch of ccree coding style fixes.
> 
> These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues 
> in ssi_sysfs.c")
> in staging-testing.

Odd, some of these did not apply, but others did.  Please rebase your
series and resend what I didn't pick up this time.

thanks,

greg k-h

[PATCH 00/12] staging: ccree: coding style fixes

2017-07-13 Thread Gilad Ben-Yossef 
Another batch of ccree coding style fixes.

These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues in 
ssi_sysfs.c")
in staging-testing.

Gilad Ben-Yossef (12):
  staging: ccree remove unnecessary parentheses
  staging: ccree: clean up struct ssi_aead_ctx
  staging: ccree: use proper printk format for dma_addr_t
  staging: ccree: fix parenthesis alignment
  staging: ccree: fix split strings
  staging: ccree: CamelCase to snake_case in func vars
  staging: ccree: CamelCase to snake_case in aead struct
  staging: ccree: avoid constant comparison
  staging: ccree: avoid unnecessary line continuation
  staging: ccree: remove func name from log messages
  staging: ccree: kmalloc by sizeof var not type
  staging: ccree: remove whitespace before a quoted newline

 drivers/staging/ccree/ssi_aead.c| 242 +--
 drivers/staging/ccree/ssi_aead.h|  12 +-
 drivers/staging/ccree/ssi_buffer_mgr.c  | 247 +++-
 drivers/staging/ccree/ssi_cipher.c  |  65 -
 drivers/staging/ccree/ssi_driver.c  |  16 +--
 drivers/staging/ccree/ssi_hash.c| 209 ++-
 drivers/staging/ccree/ssi_ivgen.c   |  17 +--
 drivers/staging/ccree/ssi_pm.c  |   4 +-
 drivers/staging/ccree/ssi_request_mgr.c |  29 ++--
 drivers/staging/ccree/ssi_sysfs.c   |  18 +--
 10 files changed, 435 insertions(+), 424 deletions(-)

-- 
2.1.4