Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

On 14 April 2017 at 09:28, Sean Wang wrote: > > Hi PrasannaKumar, > > Add my comments inline > >> >> Use readl_poll_timeout_atomic's return value or -EIO instead of >> !!ready. This will simplify mtk_rng_read. >> > > !!ready provided is in order to let

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

Hi PrasannaKumar, Add my comments inline On Thu, 2017-04-13 at 14:09 +0530, PrasannaKumar Muralidharan wrote: > Hi Sean, > > Mostly looks good, have few minor comments. > > On 13 April 2017 at 12:35, wrote: > > +static bool mtk_rng_wait_ready(struct hwrng *rng, bool

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

Hi Corentin, I all agree and appreciate your careful reviewing. They will be added into the next one. Sean On Thu, 2017-04-13 at 13:06 +0200, Corentin Labbe wrote: > Hello > > I have some minor comment below: > > On Thu, Apr 13, 2017 at 03:05:08PM +0800, sean.w...@mediatek.com

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

Hello I have some minor comment below: On Thu, Apr 13, 2017 at 03:05:08PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds support for hardware random generator on MT7623 SoC > and should also work on other similar Mediatek SoCs. Currently, >

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

Hi Sean, Mostly looks good, have few minor comments. On 13 April 2017 at 12:35, wrote: > +static bool mtk_rng_wait_ready(struct hwrng *rng, bool wait) > +{ > + struct mtk_rng *priv = to_mtk_rng(rng); > + int ready; > + > + ready = readl(priv->base +

[PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

From: Sean Wang This patch adds support for hardware random generator on MT7623 SoC and should also work on other similar Mediatek SoCs. Currently, the driver is already tested successfully with rng-tools. Signed-off-by: Sean Wang ---