Re: [PATCH v5 1/4] Documentation/bindings: Document the SafeXel cryptographic engine driver

[Antoine Tenart]

Hi Thomas,

On Mon, May 22, 2017 at 09:34:16PM +0200, Thomas Petazzoni wrote:
> On Mon, 22 May 2017 16:45:11 +0200, Antoine Tenart wrote:
> > +   interrupts =  > IRQ_TYPE_LEVEL_HIGH)>,
> 
> You already got the feedback previously that an interrupt that is both
> edge and level at the same time doesn't make sense. Could you fix this?
> 
> Also, the DTs that have already been merged by Grégory are wrong for
> the same reason and should be fixed.

Sure, I'll fix this and send a new version :)

Thanks,
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH v5 1/4] Documentation/bindings: Document the SafeXel cryptographic engine driver

[Thomas Petazzoni]

Hello,

On Mon, 22 May 2017 16:45:11 +0200, Antoine Tenart wrote:
> + interrupts =  IRQ_TYPE_LEVEL_HIGH)>,

You already got the feedback previously that an interrupt that is both
edge and level at the same time doesn't make sense. Could you fix this?

Also, the DTs that have already been merged by Grégory are wrong for
the same reason and should be fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH v5 1/4] Documentation/bindings: Document the SafeXel cryptographic engine driver

[Antoine Tenart]

The Inside Secure Safexcel cryptographic engine is found on some Marvell
SoCs (7k/8k). Document the bindings used by its driver.

Signed-off-by: Antoine Tenart 
---
 .../bindings/crypto/inside-secure-safexcel.txt | 29 ++
 1 file changed, 29 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/crypto/inside-secure-safexcel.txt

diff --git 
a/Documentation/devicetree/bindings/crypto/inside-secure-safexcel.txt 
b/Documentation/devicetree/bindings/crypto/inside-secure-safexcel.txt
new file mode 100644
index ..37abbb2ca250
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/inside-secure-safexcel.txt
@@ -0,0 +1,29 @@
+Inside Secure SafeXcel cryptographic engine
+
+Required properties:
+- compatible: Should be "inside-secure,safexcel-eip197".
+- reg: Base physical address of the engine and length of memory mapped region.
+- interrupts: Interrupt numbers for the rings and engine.
+- interrupt-names: Should be "ring0", "ring1", "ring2", "ring3", "eip", "mem".
+
+Optional properties:
+- clocks: Reference to the crypto engine clock.
+- dma-mask: The address mask limitation. Defaults to 64.
+
+Example:
+
+   crypto: crypto@80 {
+   compatible = "inside-secure,safexcel-eip197";
+   reg = <0x80 0x20>;
+   interrupts = ,
+,
+,
+,
+,
+;
+   interrupt-names = "mem", "ring0", "ring1", "ring2", "ring3",
+ "eip";
+   clocks = <_syscon0 1 26>;
+   dma-mask = <0xff 0x>;
+   status = "disabled";
+   };
-- 
2.9.4