Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Wed, May 3, 2017 at 10:29 AM, Vinod Koul wrote: > On Wed, May 03, 2017 at 09:15:20AM +0530, Anup Patel wrote: >> Hi Vinod, >> >> The Broadcom FlexRM patchset have been >> merged in v4.11. >> >> I think you now can take this patchset in next >> merge window. Right?? > > Sure, please rebase and resend after -rc1 is out Sure, I will do that. Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Wed, May 03, 2017 at 09:15:20AM +0530, Anup Patel wrote: > Hi Vinod, > > The Broadcom FlexRM patchset have been > merged in v4.11. > > I think you now can take this patchset in next > merge window. Right?? Sure, please rebase and resend after -rc1 is out -- ~Vinod
Re: [PATCH v6 0/4] Broadcom SBA RAID support
Hi Vinod, The Broadcom FlexRM patchset have been merged in v4.11. I think you now can take this patchset in next merge window. Right?? Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Wed, Mar 29, 2017 at 11:35:43AM +0530, Anup Patel wrote: > On Tue, Mar 21, 2017 at 2:48 PM, Vinod Koul wrote: > > On Tue, Mar 21, 2017 at 02:17:21PM +0530, Anup Patel wrote: > >> On Tue, Mar 21, 2017 at 2:00 PM, Vinod Koul wrote: > >> > On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrote: > >> >> The Broadcom SBA RAID is a stream-based device which provides > >> >> RAID5/6 offload. > >> >> > >> >> It requires a SoC specific ring manager (such as Broadcom FlexRM > >> >> ring manager) to provide ring-based programming interface. Due to > >> >> this, the Broadcom SBA RAID driver (mailbox client) implements > >> >> DMA device having one DMA channel using a set of mailbox channels > >> >> provided by Broadcom SoC specific ring manager driver (mailbox > >> >> controller). > >> >> > >> >> The Broadcom SBA RAID hardware requires PQ disk position instead > >> >> of PQ disk coefficient. To address this, we have added raid_gflog > >> >> table which will help driver to convert PQ disk coefficient to PQ > >> >> disk position. > >> >> > >> >> This patchset is based on Linux-4.11-rc1 and depends on patchset > >> >> "[PATCH v5 0/2] Broadcom FlexRM ring manager support" > >> > > >> > Okay I applied and was about to push when I noticed this :( > >> > > >> > So what is the status of this..? > >> > >> PATCH2 is Acked but PATCH1 is under-review. Currently, its > >> v6 of that patchset. > >> > >> The only dependency on that patchset is the changes in > >> brcm-message.h which are required by this BCM-SBA-RAID > >> driver. > >> > >> @Jassi, > >> Can you please have a look at PATCH v6? > > > > And I would need an immutable branch/tag once merged. I am going to keep > > this series pending till then. > > The Broadcom FlexRM patchset is pickedup by Jassi and > can be found in mailbox-for-next branch of > git://git.linaro.org/landing-teams/working/fujitsu/integration > > Both patchset (Broadcom FlexRM patchset and this one) are > also available in sba-raid-v7 branch of > https://github.com/Broadcom/arm64-linux.git Jassi, Can you provide an immutable branch/tag please for this, latter is preferred. Btw didn't find your tree in MAINTAINERS.. > > Regards, > Anup -- ~Vinod
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Tue, Mar 21, 2017 at 2:48 PM, Vinod Koul wrote: > On Tue, Mar 21, 2017 at 02:17:21PM +0530, Anup Patel wrote: >> On Tue, Mar 21, 2017 at 2:00 PM, Vinod Koul wrote: >> > On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrote: >> >> The Broadcom SBA RAID is a stream-based device which provides >> >> RAID5/6 offload. >> >> >> >> It requires a SoC specific ring manager (such as Broadcom FlexRM >> >> ring manager) to provide ring-based programming interface. Due to >> >> this, the Broadcom SBA RAID driver (mailbox client) implements >> >> DMA device having one DMA channel using a set of mailbox channels >> >> provided by Broadcom SoC specific ring manager driver (mailbox >> >> controller). >> >> >> >> The Broadcom SBA RAID hardware requires PQ disk position instead >> >> of PQ disk coefficient. To address this, we have added raid_gflog >> >> table which will help driver to convert PQ disk coefficient to PQ >> >> disk position. >> >> >> >> This patchset is based on Linux-4.11-rc1 and depends on patchset >> >> "[PATCH v5 0/2] Broadcom FlexRM ring manager support" >> > >> > Okay I applied and was about to push when I noticed this :( >> > >> > So what is the status of this..? >> >> PATCH2 is Acked but PATCH1 is under-review. Currently, its >> v6 of that patchset. >> >> The only dependency on that patchset is the changes in >> brcm-message.h which are required by this BCM-SBA-RAID >> driver. >> >> @Jassi, >> Can you please have a look at PATCH v6? > > And I would need an immutable branch/tag once merged. I am going to keep > this series pending till then. The Broadcom FlexRM patchset is pickedup by Jassi and can be found in mailbox-for-next branch of git://git.linaro.org/landing-teams/working/fujitsu/integration Both patchset (Broadcom FlexRM patchset and this one) are also available in sba-raid-v7 branch of https://github.com/Broadcom/arm64-linux.git Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Tue, Mar 21, 2017 at 02:17:21PM +0530, Anup Patel wrote: > On Tue, Mar 21, 2017 at 2:00 PM, Vinod Koul wrote: > > On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrote: > >> The Broadcom SBA RAID is a stream-based device which provides > >> RAID5/6 offload. > >> > >> It requires a SoC specific ring manager (such as Broadcom FlexRM > >> ring manager) to provide ring-based programming interface. Due to > >> this, the Broadcom SBA RAID driver (mailbox client) implements > >> DMA device having one DMA channel using a set of mailbox channels > >> provided by Broadcom SoC specific ring manager driver (mailbox > >> controller). > >> > >> The Broadcom SBA RAID hardware requires PQ disk position instead > >> of PQ disk coefficient. To address this, we have added raid_gflog > >> table which will help driver to convert PQ disk coefficient to PQ > >> disk position. > >> > >> This patchset is based on Linux-4.11-rc1 and depends on patchset > >> "[PATCH v5 0/2] Broadcom FlexRM ring manager support" > > > > Okay I applied and was about to push when I noticed this :( > > > > So what is the status of this..? > > PATCH2 is Acked but PATCH1 is under-review. Currently, its > v6 of that patchset. > > The only dependency on that patchset is the changes in > brcm-message.h which are required by this BCM-SBA-RAID > driver. > > @Jassi, > Can you please have a look at PATCH v6? And I would need an immutable branch/tag once merged. I am going to keep this series pending till then. -- ~Vinod
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Tue, Mar 21, 2017 at 2:00 PM, Vinod Koul wrote: > On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrote: >> The Broadcom SBA RAID is a stream-based device which provides >> RAID5/6 offload. >> >> It requires a SoC specific ring manager (such as Broadcom FlexRM >> ring manager) to provide ring-based programming interface. Due to >> this, the Broadcom SBA RAID driver (mailbox client) implements >> DMA device having one DMA channel using a set of mailbox channels >> provided by Broadcom SoC specific ring manager driver (mailbox >> controller). >> >> The Broadcom SBA RAID hardware requires PQ disk position instead >> of PQ disk coefficient. To address this, we have added raid_gflog >> table which will help driver to convert PQ disk coefficient to PQ >> disk position. >> >> This patchset is based on Linux-4.11-rc1 and depends on patchset >> "[PATCH v5 0/2] Broadcom FlexRM ring manager support" > > Okay I applied and was about to push when I noticed this :( > > So what is the status of this..? PATCH2 is Acked but PATCH1 is under-review. Currently, its v6 of that patchset. The only dependency on that patchset is the changes in brcm-message.h which are required by this BCM-SBA-RAID driver. @Jassi, Can you please have a look at PATCH v6? Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrote: > The Broadcom SBA RAID is a stream-based device which provides > RAID5/6 offload. > > It requires a SoC specific ring manager (such as Broadcom FlexRM > ring manager) to provide ring-based programming interface. Due to > this, the Broadcom SBA RAID driver (mailbox client) implements > DMA device having one DMA channel using a set of mailbox channels > provided by Broadcom SoC specific ring manager driver (mailbox > controller). > > The Broadcom SBA RAID hardware requires PQ disk position instead > of PQ disk coefficient. To address this, we have added raid_gflog > table which will help driver to convert PQ disk coefficient to PQ > disk position. > > This patchset is based on Linux-4.11-rc1 and depends on patchset > "[PATCH v5 0/2] Broadcom FlexRM ring manager support" Okay I applied and was about to push when I noticed this :( So what is the status of this..? -- ~Vinod
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Wed, Mar 15, 2017 at 12:18 AM, Shaohua Li wrote: > On Tue, Mar 14, 2017 at 09:56:35AM -0700, Dan Williams wrote: >> On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: >> > The Broadcom SBA RAID is a stream-based device which provides >> > RAID5/6 offload. >> > >> > It requires a SoC specific ring manager (such as Broadcom FlexRM >> > ring manager) to provide ring-based programming interface. Due to >> > this, the Broadcom SBA RAID driver (mailbox client) implements >> > DMA device having one DMA channel using a set of mailbox channels >> > provided by Broadcom SoC specific ring manager driver (mailbox >> > controller). >> > >> > The Broadcom SBA RAID hardware requires PQ disk position instead >> > of PQ disk coefficient. To address this, we have added raid_gflog >> > table which will help driver to convert PQ disk coefficient to PQ >> > disk position. >> > >> > This patchset is based on Linux-4.11-rc1 and depends on patchset >> > "[PATCH v5 0/2] Broadcom FlexRM ring manager support" >> > >> > It is also available at sba-raid-v6 branch of >> > https://github.com/Broadcom/arm64-linux.git >> > >> [..] >> > >> > Anup Patel (4): >> > lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position >> > async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() >> > dmaengine: Add Broadcom SBA RAID driver >> > dt-bindings: Add DT bindings document for Broadcom SBA RAID driver >> >> For the dmaengine and async_tx changes: >> >> Acked-by: Dan Williams >> >> The raid change should get an ack from Shaohua. > > For the raid6 part: > > Acked-by: Shaohua Li Thanks Shaohua ... Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Tue, Mar 14, 2017 at 10:26 PM, Dan Williams wrote: > On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: >> The Broadcom SBA RAID is a stream-based device which provides >> RAID5/6 offload. >> >> It requires a SoC specific ring manager (such as Broadcom FlexRM >> ring manager) to provide ring-based programming interface. Due to >> this, the Broadcom SBA RAID driver (mailbox client) implements >> DMA device having one DMA channel using a set of mailbox channels >> provided by Broadcom SoC specific ring manager driver (mailbox >> controller). >> >> The Broadcom SBA RAID hardware requires PQ disk position instead >> of PQ disk coefficient. To address this, we have added raid_gflog >> table which will help driver to convert PQ disk coefficient to PQ >> disk position. >> >> This patchset is based on Linux-4.11-rc1 and depends on patchset >> "[PATCH v5 0/2] Broadcom FlexRM ring manager support" >> >> It is also available at sba-raid-v6 branch of >> https://github.com/Broadcom/arm64-linux.git >> > [..] >> >> Anup Patel (4): >> lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position >> async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() >> dmaengine: Add Broadcom SBA RAID driver >> dt-bindings: Add DT bindings document for Broadcom SBA RAID driver > > For the dmaengine and async_tx changes: > > Acked-by: Dan Williams > Thanks Dan ... Regards, Anup
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Tue, Mar 14, 2017 at 09:56:35AM -0700, Dan Williams wrote: > On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: > > The Broadcom SBA RAID is a stream-based device which provides > > RAID5/6 offload. > > > > It requires a SoC specific ring manager (such as Broadcom FlexRM > > ring manager) to provide ring-based programming interface. Due to > > this, the Broadcom SBA RAID driver (mailbox client) implements > > DMA device having one DMA channel using a set of mailbox channels > > provided by Broadcom SoC specific ring manager driver (mailbox > > controller). > > > > The Broadcom SBA RAID hardware requires PQ disk position instead > > of PQ disk coefficient. To address this, we have added raid_gflog > > table which will help driver to convert PQ disk coefficient to PQ > > disk position. > > > > This patchset is based on Linux-4.11-rc1 and depends on patchset > > "[PATCH v5 0/2] Broadcom FlexRM ring manager support" > > > > It is also available at sba-raid-v6 branch of > > https://github.com/Broadcom/arm64-linux.git > > > [..] > > > > Anup Patel (4): > > lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position > > async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() > > dmaengine: Add Broadcom SBA RAID driver > > dt-bindings: Add DT bindings document for Broadcom SBA RAID driver > > For the dmaengine and async_tx changes: > > Acked-by: Dan Williams > > The raid change should get an ack from Shaohua. For the raid6 part: Acked-by: Shaohua Li
Re: [PATCH v6 0/4] Broadcom SBA RAID support
On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: > The Broadcom SBA RAID is a stream-based device which provides > RAID5/6 offload. > > It requires a SoC specific ring manager (such as Broadcom FlexRM > ring manager) to provide ring-based programming interface. Due to > this, the Broadcom SBA RAID driver (mailbox client) implements > DMA device having one DMA channel using a set of mailbox channels > provided by Broadcom SoC specific ring manager driver (mailbox > controller). > > The Broadcom SBA RAID hardware requires PQ disk position instead > of PQ disk coefficient. To address this, we have added raid_gflog > table which will help driver to convert PQ disk coefficient to PQ > disk position. > > This patchset is based on Linux-4.11-rc1 and depends on patchset > "[PATCH v5 0/2] Broadcom FlexRM ring manager support" > > It is also available at sba-raid-v6 branch of > https://github.com/Broadcom/arm64-linux.git > [..] > > Anup Patel (4): > lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position > async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() > dmaengine: Add Broadcom SBA RAID driver > dt-bindings: Add DT bindings document for Broadcom SBA RAID driver For the dmaengine and async_tx changes: Acked-by: Dan Williams The raid change should get an ack from Shaohua.
[PATCH v6 0/4] Broadcom SBA RAID support
The Broadcom SBA RAID is a stream-based device which provides RAID5/6 offload. It requires a SoC specific ring manager (such as Broadcom FlexRM ring manager) to provide ring-based programming interface. Due to this, the Broadcom SBA RAID driver (mailbox client) implements DMA device having one DMA channel using a set of mailbox channels provided by Broadcom SoC specific ring manager driver (mailbox controller). The Broadcom SBA RAID hardware requires PQ disk position instead of PQ disk coefficient. To address this, we have added raid_gflog table which will help driver to convert PQ disk coefficient to PQ disk position. This patchset is based on Linux-4.11-rc1 and depends on patchset "[PATCH v5 0/2] Broadcom FlexRM ring manager support" It is also available at sba-raid-v6 branch of https://github.com/Broadcom/arm64-linux.git Changes since v5: - Rebased patches for Linux-4.11-rc1 Changes since v4: - Removed dependency of bcm-sba-raid driver on kconfig opton ASYNC_TX_ENABLE_CHANNEL_SWITCH - Select kconfig options ASYNC_TX_DISABLE_XOR_VAL_DMA and ASYNC_TX_DISABLE_PQ_VAL_DMA for bcm-sba-raid driver - Implemented device_prep_dma_interrupt() using dummy 8-byte copy operation so that the dma_async_device_register() can set DMA_ASYNC_TX capability for the DMA device provided by bcm-sba-raid driver Changes since v3: - Replaced SBA_ENC() with sba_cmd_enc() inline function - Use list_first_entry_or_null() wherever possible - Remove unwanted brances around loops wherever possible - Use lockdep_assert_held() where required Changes since v2: - Droped patch to handle DMA devices having support for fewer PQ coefficients in Linux Async Tx - Added work-around in bcm-sba-raid driver to handle unsupported PQ coefficients using multiple SBA requests Changes since v1: - Droped patch to add mbox_channel_device() API - Used GENMASK and BIT macros wherever possible in bcm-sba-raid driver - Replaced C_MDATA macros with static inline functions in bcm-sba-raid driver - Removed sba_alloc_chan_resources() callback in bcm-sba-raid driver - Used dev_err() instead of dev_info() wherever applicable - Removed call to sba_issue_pending() from sba_tx_submit() in bcm-sba-raid driver - Implemented SBA request chaning for handling (len > sba->req_size) in bcm-sba-raid driver - Implemented device_terminate_all() callback in bcm-sba-raid driver Anup Patel (4): lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() dmaengine: Add Broadcom SBA RAID driver dt-bindings: Add DT bindings document for Broadcom SBA RAID driver .../devicetree/bindings/dma/brcm,iproc-sba.txt | 29 + crypto/async_tx/async_pq.c |5 +- drivers/dma/Kconfig| 14 + drivers/dma/Makefile |1 + drivers/dma/bcm-sba-raid.c | 1785 include/linux/raid/pq.h|1 + lib/raid6/mktables.c | 20 + 7 files changed, 1852 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/brcm,iproc-sba.txt create mode 100644 drivers/dma/bcm-sba-raid.c -- 2.7.4