Re: [RFC 0/7] crypto: caam - add Queue Interface (QI) support

2017-03-16 Thread Scott Wood 
On Thu, 2017-03-16 at 14:13 +, Horia Geantă wrote:
> On 3/16/2017 10:43 AM, Herbert Xu wrote:
> > 
> > On Fri, Mar 03, 2017 at 04:52:06PM +0200, Horia Geantă wrote:
> > > 
> > > The patchset adds support for CAAM Queue Interface (QI), the additional
> > > interface (besides job ring) available for submitting jobs to the engine
> > > on platforms having DPAA (Datapath Acceleration Architecture).
> > > 
> > > Patches 1-4 are QMan dependencies.
> > > I would prefer to take them through the crypto tree,
> > > but I am open to suggestions.
> > > 
> > > Patch 5 adds a missing double inclusion guard in desc_constr.h.
> > > 
> > > Patch 6 adds the caam/qi job submission backend.
> > > 
> > > Patch 7 adds algorithms (ablkcipher and authenc) that run on top
> > > of caam/qi. For now, their priority is set lower than caam/jr.
> > I'm fine with the crypto bits.
> > 
> Herbert,
> 
> Thanks for the review.
> Should I submit formally, i.e. without the [RFC] prefix?
> 
> Scott, Roy,
> 
> Do you have any comments wrt. soc/qman patches or with them going
> through the crypto tree?

Going through the crypto tree is fine.

-Scott

Re: [RFC 0/7] crypto: caam - add Queue Interface (QI) support

2017-03-16 Thread Horia Geantă 
On 3/16/2017 10:43 AM, Herbert Xu wrote:
> On Fri, Mar 03, 2017 at 04:52:06PM +0200, Horia Geantă wrote:
>> The patchset adds support for CAAM Queue Interface (QI), the additional
>> interface (besides job ring) available for submitting jobs to the engine
>> on platforms having DPAA (Datapath Acceleration Architecture).
>>
>> Patches 1-4 are QMan dependencies.
>> I would prefer to take them through the crypto tree,
>> but I am open to suggestions.
>>
>> Patch 5 adds a missing double inclusion guard in desc_constr.h.
>>
>> Patch 6 adds the caam/qi job submission backend.
>>
>> Patch 7 adds algorithms (ablkcipher and authenc) that run on top
>> of caam/qi. For now, their priority is set lower than caam/jr.
> 
> I'm fine with the crypto bits.
> 
Herbert,

Thanks for the review.
Should I submit formally, i.e. without the [RFC] prefix?

Scott, Roy,

Do you have any comments wrt. soc/qman patches or with them going
through the crypto tree?

Thanks,
Horia

Re: [RFC 0/7] crypto: caam - add Queue Interface (QI) support

2017-03-16 Thread Herbert Xu 
On Fri, Mar 03, 2017 at 04:52:06PM +0200, Horia Geantă wrote:
> The patchset adds support for CAAM Queue Interface (QI), the additional
> interface (besides job ring) available for submitting jobs to the engine
> on platforms having DPAA (Datapath Acceleration Architecture).
> 
> Patches 1-4 are QMan dependencies.
> I would prefer to take them through the crypto tree,
> but I am open to suggestions.
> 
> Patch 5 adds a missing double inclusion guard in desc_constr.h.
> 
> Patch 6 adds the caam/qi job submission backend.
> 
> Patch 7 adds algorithms (ablkcipher and authenc) that run on top
> of caam/qi. For now, their priority is set lower than caam/jr.

I'm fine with the crypto bits.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[RFC 0/7] crypto: caam - add Queue Interface (QI) support

2017-03-03 Thread Horia Geantă 
The patchset adds support for CAAM Queue Interface (QI), the additional
interface (besides job ring) available for submitting jobs to the engine
on platforms having DPAA (Datapath Acceleration Architecture).

Patches 1-4 are QMan dependencies.
I would prefer to take them through the crypto tree,
but I am open to suggestions.

Patch 5 adds a missing double inclusion guard in desc_constr.h.

Patch 6 adds the caam/qi job submission backend.

Patch 7 adds algorithms (ablkcipher and authenc) that run on top
of caam/qi. For now, their priority is set lower than caam/jr.

Thanks,
Horia

Horia Geantă (7):
  soc/qman: export volatile dequeue related structs
  soc/qman: add dedicated channel ID for CAAM
  soc/qman: export non-programmable FQD fields query
  soc/qman: add helper functions needed by caam/qi driver
  crypto: caam - avoid double inclusion in desc_constr.h
  crypto: caam - add Queue Interface (QI) backend support
  crypto: caam/qi - add ablkcipher and authenc algorithms

 drivers/crypto/caam/Kconfig |   20 +-
 drivers/crypto/caam/Makefile|5 +
 drivers/crypto/caam/caamalg.c   |9 +-
 drivers/crypto/caam/caamalg_desc.c  |   77 +-
 drivers/crypto/caam/caamalg_desc.h  |   15 +-
 drivers/crypto/caam/caamalg_qi.c| 2387 +++
 drivers/crypto/caam/ctrl.c  |   58 +-
 drivers/crypto/caam/desc_constr.h   |5 +
 drivers/crypto/caam/intern.h|   24 +
 drivers/crypto/caam/qi.c|  805 +++
 drivers/crypto/caam/qi.h|  201 +++
 drivers/crypto/caam/sg_sw_qm.h  |  107 ++
 drivers/soc/fsl/qbman/qman.c|   20 +-
 drivers/soc/fsl/qbman/qman_ccsr.c   |6 +-
 drivers/soc/fsl/qbman/qman_priv.h   |   97 --
 drivers/soc/fsl/qbman/qman_test_stash.c |5 +-
 include/soc/fsl/qman.h  |  154 ++
 17 files changed, 3839 insertions(+), 156 deletions(-)
 create mode 100644 drivers/crypto/caam/caamalg_qi.c
 create mode 100644 drivers/crypto/caam/qi.c
 create mode 100644 drivers/crypto/caam/qi.h
 create mode 100644 drivers/crypto/caam/sg_sw_qm.h

-- 
2.4.4