Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

[Herbert Xu]

On Mon, Jul 10, 2017 at 11:51:42AM -0700, Linus Torvalds wrote:
> Heh, I already did this in commit b4b8cbf679c4.
> 
> I complained because I want maintainers to be aware of this issue -
> adding Kconfig options with defaults that don't make sense should be
> caught earlier than when I do a test built..

OK, I will be more vigilant next time.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

[Linus Torvalds]

Heh, I already did this in commit b4b8cbf679c4.

I complained because I want maintainers to be aware of this issue -
adding Kconfig options with defaults that don't make sense should be
caught earlier than when I do a test built..

  Linus

On Mon, Jul 10, 2017 at 3:15 AM, Herbert Xu  wrote:
> Drivers should not enable themselves by default, unless they're
> an integral part of the platform.
>
> Reported-by: Linus Torvalds 
> Signed-off-by: Herbert Xu 
>
> diff --git a/drivers/crypto/cavium/nitrox/Kconfig 
> b/drivers/crypto/cavium/nitrox/Kconfig
> index 731e6a5..181a1df 100644
> --- a/drivers/crypto/cavium/nitrox/Kconfig
> +++ b/drivers/crypto/cavium/nitrox/Kconfig
> @@ -12,7 +12,6 @@ config CRYPTO_DEV_NITROX_CNN55XX
> tristate "Support for Cavium CNN55XX driver"
> depends on PCI_MSI && 64BIT
> select CRYPTO_DEV_NITROX
> -   default m
> help
>   Support for Cavium NITROX family CNN55XX driver
>   for accelerating crypto workloads.
> --
> Email: Herbert Xu 
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt