Re: [PATCH 0/5] staging: ccree: fix checkpatch errors

[Gilad Ben-Yossef]

Tyler,


On Tue, Jul 11, 2017 at 4:38 PM, Gilad Ben-Yossef  wrote:
> On Mon, Jul 10, 2017 at 12:10 AM,   wrote:
>> From: Tyler Olivieri 
>>
>> This patchset fixes several checkpatch errors and warnings in /staging/ccree:

You've messed Greg's email address, so my ACK bounced.

The content is good, but I don't know if Greg saw the patch set.
You might want to resend it.

Gilad.




-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Re: [PATCH 0/5] staging: ccree: fix checkpatch errors

[Gilad Ben-Yossef]

On Mon, Jul 10, 2017 at 12:10 AM,   wrote:
> From: Tyler Olivieri 
>
> This patchset fixes several checkpatch errors and warnings in /staging/ccree:
>
> ERROR: that open brace { should be on the previous line
> ERROR: open brace '{' following function declarations go on the next line
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> ERROR: do not use assignment in if condition
> ERROR: switch and case should be at the same indent
> WARNING: Statements terminations use 1 semicolon
>
> This is also a submission for the eudyptula challenge.
>
> Tyler Olivieri (5):
>   staging: ccree: remove redudant semicolons
>   staging: ccree: fix placement of curly braces
>   staging: ccree: remove assignement in conditional
>   staging: ccree: export symbol immediately following function
>   staging: ccree: fix switch case indentation
>
>  drivers/staging/ccree/ssi_buffer_mgr.c | 14 ++
>  drivers/staging/ccree/ssi_cipher.c |  6 ++-
>  drivers/staging/ccree/ssi_driver.c |  5 +-
>  drivers/staging/ccree/ssi_fips.c   |  2 -
>  drivers/staging/ccree/ssi_fips_ll.c| 85 
> +++---
>  drivers/staging/ccree/ssi_hash.c   | 33 +++--
>  drivers/staging/ccree/ssi_sysfs.c  |  3 +-
>  7 files changed, 57 insertions(+), 91 deletions(-)
>
> --
> 2.9.4
>


Looks good to me.

Acked-by: Gilad Ben-Yossef 

Thanks!

Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru