Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote: > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 19 Apr 2017 10:50:04 +0200 > > > > The script "checkpatch.pl" pointed information out like the following. > > > > WARNING: quoted string split across lines > > > > Thus fix the affected source code places. > > > > Signed-off-by: Markus Elfring > > This patch doesn't seem to add any value so I'm not taking it. Your choice. The general reason to merge strings is in CodingStyle 2) Breaking long lines and strings [] never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
From: Herbert Xu Date: Fri, 21 Apr 2017 19:36:41 +0800 > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Wed, 19 Apr 2017 10:50:04 +0200 >> >> The script "checkpatch.pl" pointed information out like the following. >> >> WARNING: quoted string split across lines >> >> Thus fix the affected source code places. >> >> Signed-off-by: Markus Elfring > > This patch doesn't seem to add any value so I'm not taking it. > > Please don't send patches based purely on a checkpatch complaint. Thank you Herbert.
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Apr 2017 10:50:04 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: quoted string split across lines > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring This patch doesn't seem to add any value so I'm not taking it. Please don't send patches based purely on a checkpatch complaint. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
On 4/19/2017 2:11 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 19 Apr 2017 10:50:04 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring Thanks Markus. Acked-by: Shannon Nelson --- drivers/char/hw_random/n2-drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c index 92dd4e925315..f3e67c768101 100644 --- a/drivers/char/hw_random/n2-drv.c +++ b/drivers/char/hw_random/n2-drv.c @@ -723,16 +723,16 @@ static int n2rng_probe(struct platform_device *op) if (sun4v_hvapi_register(HV_GRP_RNG, np->hvapi_major, &np->hvapi_minor)) { - dev_err(&op->dev, "Cannot register suitable " - "HVAPI version.\n"); + dev_err(&op->dev, + "Cannot register suitable HVAPI version.\n"); goto out; } } if (np->flags & N2RNG_FLAG_MULTI) { if (np->hvapi_major < 2) { - dev_err(&op->dev, "multi-unit-capable RNG requires " - "HVAPI major version 2 or later, got %lu\n", + dev_err(&op->dev, + "multi-unit-capable RNG requires HVAPI major version 2 or later, got %lu\n", np->hvapi_major); goto out_hvapi_unregister; }