Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-21 Thread Mauro Carvalho Chehab
On Sun, 20 Jan 2008 15:26:20 -0800 (PST) Trent Piepho [EMAIL PROTECTED] wrote: On Sun, 20 Jan 2008, Mauro Carvalho Chehab wrote: On Sat, 19 Jan 2008 05:28:49 -0800 (PST) Trent Piepho [EMAIL PROTECTED] wrote: I wish people would use the patch creating system from Hg, since it would

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-20 Thread Mauro Carvalho Chehab
On Sat, 19 Jan 2008 05:28:49 -0800 (PST) Trent Piepho [EMAIL PROTECTED] wrote: I wish people would use the patch creating system from Hg, since it would the format mistakes evident in this patch. 1. no patch title 2. s-o-b's in wrong order 3. diffstat included 4. patch against git source

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-20 Thread Trent Piepho
On Sun, 20 Jan 2008, Mauro Carvalho Chehab wrote: On Sat, 19 Jan 2008 05:28:49 -0800 (PST) Trent Piepho [EMAIL PROTECTED] wrote: I wish people would use the patch creating system from Hg, since it would the format mistakes evident in this patch. 1. no patch title 2. s-o-b's in wrong

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-20 Thread Manu Abraham
Trent Piepho wrote: On Sun, 20 Jan 2008, Mauro Carvalho Chehab wrote: On Sat, 19 Jan 2008 05:28:49 -0800 (PST) Trent Piepho [EMAIL PROTECTED] wrote: I wish people would use the patch creating system from Hg, since it would the format mistakes evident in this patch. 1. no patch title 2.

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-20 Thread Trent Piepho
On Mon, 21 Jan 2008, Manu Abraham wrote: Trent Piepho wrote: The DVB driver used to load for cards with sub-vendor/device 0x,0x, but a previous patch changed that. An effect that that _should_ have been mentioned in the description of the patch responsible, but was not. This

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-19 Thread Trent Piepho
I wish people would use the patch creating system from Hg, since it would the format mistakes evident in this patch. 1. no patch title 2. s-o-b's in wrong order 3. diffstat included 4. patch against git source and not hg On Sat, 19 Jan 2008, Akinobu Mita wrote: From: Akinobu Mita [EMAIL

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-19 Thread Trent Piepho
On Sun, 20 Jan 2008, Akinobu Mita wrote: +static const char * __devinit card_name(const struct pci_device_id *id) +{ + if (id = bt878_pci_tbl + id bt878_pci_tbl + ARRAY_SIZE(bt878_pci_tbl) - 1) + return (const char *)id-driver_data; Are you sure this is

Re: [linux-dvb] [v4l-dvb-maintainer] [PATCH 1/2] bt878: remove handcrafted PCI subsystem ID check

2008-01-19 Thread Manu Abraham
Trent Piepho wrote: On Sun, 20 Jan 2008, Akinobu Mita wrote: +static const char * __devinit card_name(const struct pci_device_id *id) +{ + if (id = bt878_pci_tbl + id bt878_pci_tbl + ARRAY_SIZE(bt878_pci_tbl) - 1) + return (const char *)id-driver_data; Are you sure