Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-22 Thread Oliver Endriss
Oliver Endriss wrote:
 e9hack wrote:
  Janne Grunau wrote:
   On Thursday 12 April 2007 00:01:43 e9hack wrote:
   I've split the patch like the description above.
   
   Thanks. Patched v4l-dvb hg still works for my Cinergy DVB-C (with 
   tda10021) and KNC One V1.0.
  
  Hi,
  
  how is the status for integrating this patch into the v4l-dvb repository?
 
 If nobody objects, I'll commit the patchset to HG next weekend.

Applied (with whitespace fixes).

Thanks,

Oliver

-- 

VDR Remote Plugin 0.3.9 available at
http://www.escape-edv.de/endriss/vdr/



___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-16 Thread e9hack
Janne Grunau wrote:
 On Thursday 12 April 2007 00:01:43 e9hack wrote:
 I've split the patch like the description above.
 
 Thanks. Patched v4l-dvb hg still works for my Cinergy DVB-C (with 
 tda10021) and KNC One V1.0.

Hi,

how is the status for integrating this patch into the v4l-dvb repository?

- Hartmut

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-16 Thread Oliver Endriss
e9hack wrote:
 Janne Grunau wrote:
  On Thursday 12 April 2007 00:01:43 e9hack wrote:
  I've split the patch like the description above.
  
  Thanks. Patched v4l-dvb hg still works for my Cinergy DVB-C (with 
  tda10021) and KNC One V1.0.
 
 Hi,
 
 how is the status for integrating this patch into the v4l-dvb repository?

If nobody objects, I'll commit the patchset to HG next weekend.

Oliver

-- 

VDR Remote Plugin 0.3.9 available at
http://www.escape-edv.de/endriss/vdr/



___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-13 Thread Janne Grunau
On Thursday 12 April 2007 00:01:43 e9hack wrote:

 I've split the patch like the description above.

Thanks. Patched v4l-dvb hg still works for my Cinergy DVB-C (with 
tda10021) and KNC One V1.0.


Janne

___
linux-dvb mailing list
[EMAIL PROTECTED]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-11 Thread e9hack
Janne Grunau wrote:
 That would work.

 Better patch splitting would be 

 1. Remove the polarity switching of the clock for the DVB-C cards in
budget-av.c. This hack is no longer necessary because the saa7146 can
do the job to remove the additional FEC bytes from the TS.

 2. Add support for the frontend TDA10023 and add cards that need the
tda10023.

 3. Make the inversion setting configurable. The KNC ONE V1.0 uses
non inverted setting for the inversion and add the KNC ONE V1.0 card.
   

I've split the patch like the description above. The split patches
aren't completely independent from each other. They should be attached
in the sequence of their last number.

- Hartmut




tda1002x.010-1.diff.bz2
Description: Binary data


tda1002x.010-2.diff.bz2
Description: Binary data


tda1002x.010-3.diff.bz2
Description: Binary data
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-10 Thread Janne Grunau
On Monday 12 February 2007 23:54:28 e9hack wrote:

 it exist some new DVB-C budget cards, which are based on the KNC ONE
 (Terratec, Setalco) design. They are using a new tuner with the
 TDA10023 as demodulator. The main work to support this chip was done
 by Georg Auer.

The patch is unfortunately not yet applied. This has different reasons. 
1. We need your and for the TDA10023 part Georg Acher's sign-off 
message.

 The Patch changes the following things:
 - Added support for the frontend TDA10023
 - Added the KNC ONE DVB-C V1.0 card, which uses the alternative i2c
 address of 0xd - Added the Satelco Easywatch DVB-C card with the id
 1894:002c - Added the KNC ONE Plus DVB-C card with the id 1894:0022
 - Added the Terratec Cinergy 1200 DVB-C card with the id 153b:1176
 - Removed the polarity switching of the clock for the DVB-C cards in
 budget-av.c. This hack is no longer necessary because the saa7146 can
 do the job to remove the additional FEC bytes from the TS.

2. Multiple independent changes in one patch are greatly disliked since 
the complicate debugging.

I can work on 2. but the signatures are requirred. Please provide them.

kind regards
Janne

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-10 Thread e9hack
Janne Grunau wrote:
 On Monday 12 February 2007 23:54:28 e9hack wrote:
   
 it exist some new DVB-C budget cards, which are based on the KNC ONE
 (Terratec, Setalco) design. They are using a new tuner with the
 TDA10023 as demodulator. The main work to support this chip was done
 by Georg Auer.
 

 The patch is unfortunately not yet applied. This has different reasons. 
 1. We need your and for the TDA10023 part Georg Acher's sign-off 
 message.

   
Signed off by: Hartmut Birr [EMAIL PROTECTED]
 The Patch changes the following things:
 - Added support for the frontend TDA10023
 - Added the KNC ONE DVB-C V1.0 card, which uses the alternative i2c
 address of 0xd - Added the Satelco Easywatch DVB-C card with the id
 1894:002c - Added the KNC ONE Plus DVB-C card with the id 1894:0022
 - Added the Terratec Cinergy 1200 DVB-C card with the id 153b:1176
 - Removed the polarity switching of the clock for the DVB-C cards in
 budget-av.c. This hack is no longer necessary because the saa7146 can
 do the job to remove the additional FEC bytes from the TS.
 

 2. Multiple independent changes in one patch are greatly disliked since 
 the complicate debugging.

 I can work on 2. but the signatures are requirred. Please provide them.
   
I can split the patch into four steps:

1.) Remove the polarity switching of the clock for the DVB-C cards in
budget-av.c. This hack is no longer necessary because the saa7146 can do
the job to remove the additional FEC bytes from the TS.
2.) Add support for the frontend TDA10023.
3.) Make the inversion setting configurable. The KNC ONE V1.0 uses non
inverted setting for the inversion.
4.) Add the the new cards (Satelco Easywatch DVB-C with id 1894:002c,
KNC ONE DVB-C with id 1894:0022, KNC ONE PLUS DVB-C with id 1894:0023,
Terratec Cinergy 1200 DVB-C with id 153b:1176, KNC ONE DVB-C V1.0)

 I'm not sure if this make sense. One card needs step 1 and 3. All other
cards need step 1 and 2.

- Hartmut



___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-10 Thread Janne Grunau
On Wednesday 11 April 2007 00:18:22 e9hack wrote:
 Janne Grunau wrote:
 
  The patch is unfortunately not yet applied. This has different
  reasons. 1. We need your and for the TDA10023 part Georg Acher's
  sign-off message.

 Signed off by: Hartmut Birr [EMAIL PROTECTED]

Thanks.

 I can split the patch into four steps:

 1.) Remove the polarity switching of the clock for the DVB-C cards in
 budget-av.c. This hack is no longer necessary because the saa7146 can
 do the job to remove the additional FEC bytes from the TS.
 2.) Add support for the frontend TDA10023.
 3.) Make the inversion setting configurable. The KNC ONE V1.0 uses
 non inverted setting for the inversion.
 4.) Add the the new cards (Satelco Easywatch DVB-C with id 1894:002c,
 KNC ONE DVB-C with id 1894:0022, KNC ONE PLUS DVB-C with id
 1894:0023, Terratec Cinergy 1200 DVB-C with id 153b:1176, KNC ONE
 DVB-C V1.0)

  I'm not sure if this make sense. One card needs step 1 and 3. All
 other cards need step 1 and 2.

That would work.

Better patch splitting would be 

1. Remove the polarity switching of the clock for the DVB-C cards in
   budget-av.c. This hack is no longer necessary because the saa7146 can
   do the job to remove the additional FEC bytes from the TS.stays

2. Add support for the frontend TDA10023 and add cards that need the
   tda10023.

3. Make the inversion setting configurable. The KNC ONE V1.0 uses
   non inverted setting for the inversion and add the KNC ONE V1.0 card.

thanks

Janne

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-04-10 Thread Georg Acher
On Tue, Apr 10, 2007 at 10:48:19PM +0200, Janne Grunau wrote:
 
 The patch is unfortunately not yet applied. This has different reasons. 
 1. We need your and for the TDA10023 part Georg Acher's sign-off 
 message.

If that's all ;-)

Signed off by: Georg Acher ([EMAIL PROTECTED])

-- 
 Georg Acher, [EMAIL PROTECTED] 
 http://www.lrr.in.tum.de/~acher
 Oh no, not again ! The bowl of petunias  

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-02-23 Thread Janne Grunau
On Tuesday 13 February 2007 21:54:49 Janne Grunau wrote:

  I would like it, if the owners of such new cards do test the patch.
  The patch may also affect all cards which are supported by the
  modules budget-av and budget.

 The patched hg version works with following two cards:

 saa7146: found saa7146 @ mem c2058000 (revision 1, irq 17)
 (0x1894,0x0020). DVB: registering new adapter (KNC1 DVB-C).
 TDA10021: i2c-addr = 0x0d, id = 0x7c

This card stops delivering data as soon as a CAM is inserted. 
gnutv -cammenu works fine though.

 saa7146: found saa7146 @ mem c2078000 (revision 1, irq 19)
 (0x153b,0x1156). DVB: registering new adapter (Terratec Cinergy 1200
 DVB-C).
 TDA10021: i2c-addr = 0x0c, id = 0x7c

My Cinergy works flawlessly with the same CI and CAM.

Janne

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-02-13 Thread e9hack
Mattias Bergsten wrote:

 However:

 The Patch changes the following things:
 - Added the KNC ONE Plus DVB-C card with the id 1894:0022

 The KNC1 DVB-C Plus card I'm thinking of buying has the Windows ID
 PCI\VEN_1131DEV_7146SUBSYS_00231894, that is 1894:0023 - not
 1894:0022.

 Are there _two_ new versions of the Plus (with analogue inputs) card?

I got this information from a member of www.vdr-portal.de. He posted a
part of the syslog. I think that the id 1894:0022 is correct.

- Hartmut

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-02-13 Thread Janne Grunau
On Monday 12 February 2007 23:54:28 e9hack wrote:
 Hi,

 it exist some new DVB-C budget cards, which are based on the KNC ONE
 (Terratec, Setalco) design. They are using a new tuner with the
 TDA10023 as demodulator. The main work to support this chip was done
 by Georg Auer. He has implemented the frontend (tda10023.c) for the
 ReelBox.

 The attached archive contains the following files: - 
 tda1002x.diff, diff against the current hg-tree
 - tda10023.c, the frontend which should go to 
 ./linux/drivers/media/dvb/frontends
 - tda1002x.h, which should replace 
 ./linux/drivers/media/dvb/frontend/tda10021.h 

You can use hg add and hg remove to add and remove files. hg diff will
display the changes. I hope you don't mind if I a attach the whole patch.

 I would like it, if the owners of such new cards do test the patch.
 The patch may also affect all cards which are supported by the
 modules budget-av and budget.

The patched hg version works with following two cards:

saa7146: found saa7146 @ mem c2058000 (revision 1, irq 17) 
(0x1894,0x0020).
DVB: registering new adapter (KNC1 DVB-C).
TDA10021: i2c-addr = 0x0d, id = 0x7c
saa7146: found saa7146 @ mem c2078000 (revision 1, irq 19) 
(0x153b,0x1156).
DVB: registering new adapter (Terratec Cinergy 1200 DVB-C).
TDA10021: i2c-addr = 0x0c, id = 0x7c
diff -r 667e84e2e762 linux/drivers/media/dvb/frontends/Kconfig
--- a/linux/drivers/media/dvb/frontends/Kconfig	Tue Feb 13 07:00:55 2007 -0200
+++ b/linux/drivers/media/dvb/frontends/Kconfig	Tue Feb 13 13:51:09 2007 +0100
@@ -200,6 +200,13 @@ config DVB_VES1820
 
 config DVB_TDA10021
 	tristate Philips TDA10021 based
+	depends on DVB_CORE  I2C
+	default m if DVB_FE_CUSTOMISE
+	help
+	  A DVB-C tuner module. Say Y when you want to support this frontend.
+
+config DVB_TDA10023
+	tristate Philips TDA10023 based
 	depends on DVB_CORE  I2C
 	default m if DVB_FE_CUSTOMISE
 	help
diff -r 667e84e2e762 linux/drivers/media/dvb/frontends/Makefile
--- a/linux/drivers/media/dvb/frontends/Makefile	Tue Feb 13 07:00:55 2007 -0200
+++ b/linux/drivers/media/dvb/frontends/Makefile	Tue Feb 13 13:51:09 2007 +0100
@@ -25,6 +25,7 @@ obj-$(CONFIG_DVB_ZL10353) += zl10353.o
 obj-$(CONFIG_DVB_ZL10353) += zl10353.o
 obj-$(CONFIG_DVB_CX22702) += cx22702.o
 obj-$(CONFIG_DVB_TDA10021) += tda10021.o
+obj-$(CONFIG_DVB_TDA10023) += tda10023.o
 obj-$(CONFIG_DVB_STV0297) += stv0297.o
 obj-$(CONFIG_DVB_NXT200X) += nxt200x.o
 obj-$(CONFIG_DVB_OR51211) += or51211.o
diff -r 667e84e2e762 linux/drivers/media/dvb/frontends/tda10021.c
--- a/linux/drivers/media/dvb/frontends/tda10021.c	Tue Feb 13 07:00:55 2007 -0200
+++ b/linux/drivers/media/dvb/frontends/tda10021.c	Tue Feb 13 13:51:09 2007 +0100
@@ -30,13 +30,13 @@
 #include linux/slab.h
 
 #include dvb_frontend.h
-#include tda10021.h
+#include tda1002x.h
 
 
 struct tda10021_state {
 	struct i2c_adapter* i2c;
 	/* configuration settings */
-	const struct tda10021_config* config;
+	const struct tda1002x_config* config;
 	struct dvb_frontend frontend;
 
 	u8 pwm;
@@ -64,7 +64,7 @@ static u8 tda10021_inittab[0x40]=
 {
 	0x73, 0x6a, 0x23, 0x0a, 0x02, 0x37, 0x77, 0x1a,
 	0x37, 0x6a, 0x17, 0x8a, 0x1e, 0x86, 0x43, 0x40,
-	0xb8, 0x3f, 0xa0, 0x00, 0xcd, 0x01, 0x00, 0xff,
+	0xb8, 0x3f, 0xa1, 0x00, 0xcd, 0x01, 0x00, 0xff,
 	0x11, 0x00, 0x7c, 0x31, 0x30, 0x20, 0x00, 0x00,
 	0x02, 0x00, 0x00, 0x7d, 0x00, 0x00, 0x00, 0x00,
 	0x07, 0x00, 0x33, 0x11, 0x0d, 0x95, 0x08, 0x58,
@@ -97,9 +97,12 @@ static u8 tda10021_readreg (struct tda10
 	int ret;
 
 	ret = i2c_transfer (state-i2c, msg, 2);
-	if (ret != 2)
+	
+	// Don't print an error message if the id is read.
+	if (ret != 2  reg != 0x1a)
 		printk(DVB: TDA10021: %s: readreg error (ret == %i)\n,
 __FUNCTION__, ret);
+
 	return b1[0];
 }
 
@@ -199,16 +202,6 @@ static int tda10021_set_symbolrate (stru
 	_tda10021_writereg (state, 0x0e, SFIL);
 
 	return 0;
-}
-
-static int tda10021_write(struct dvb_frontend* fe, u8 *buf, int len)
-{
-	struct tda10021_state* state = fe-demodulator_priv;
-
-	if (len != 2)
-		return -EINVAL;
-
-	return _tda10021_writereg(state, buf[0], buf[1]);
 }
 
 static int tda10021_init (struct dvb_frontend *fe)
@@ -408,11 +401,12 @@ static void tda10021_release(struct dvb_
 
 static struct dvb_frontend_ops tda10021_ops;
 
-struct dvb_frontend* tda10021_attach(const struct tda10021_config* config,
+struct dvb_frontend* tda10021_attach(const struct tda1002x_config* config,
  struct i2c_adapter* i2c,
  u8 pwm)
 {
 	struct tda10021_state* state = NULL;
+	u8 id;
 
 	/* allocate memory for the internal state */
 	state = kmalloc(sizeof(struct tda10021_state), GFP_KERNEL);
@@ -425,7 +419,10 @@ struct dvb_frontend* tda10021_attach(con
 	state-reg0 = tda10021_inittab[0];
 
 	/* check if the demod is there */
-	if ((tda10021_readreg(state, 0x1a)  0xf0) != 0x70) goto error;
+	id = tda10021_readreg(state, 0x1a);
+	if ((id  0xf0) != 0x70) goto error;
+	
+	printk(TDA10021: i2c-addr = 0x%02x, id = 0x%02x\n, state-config-demod_address, id);
 

Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-02-13 Thread Gunther Mayer

e9hack wrote:

Mattias Bergsten wrote:
  

However:



The Patch changes the following things:
- Added the KNC ONE Plus DVB-C card with the id 1894:0022
  

The KNC1 DVB-C Plus card I'm thinking of buying has the Windows ID
PCI\VEN_1131DEV_7146SUBSYS_00231894, that is 1894:0023 - not
1894:0022.

Are there _two_ new versions of the Plus (with analogue inputs) card?



I got this information from a member of www.vdr-portal.de. He posted a
part of the syslog. I think that the id 1894:0022 is correct.

  

From INF file, 1894:0022 is non-Plus model:

%DESC_DVBC_NO%=DVBLLC_DDI,PCI\VEN_1131DEV_7146SUBSYS_00221894 ;DVBC
%DESC_DVBC_PN%=DVBLLC_DDI,PCI\VEN_1131DEV_7146SUBSYS_00231894 ;DVBC+

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] patch, which supports some new DVB-C budget cards

2007-02-12 Thread Mattias Bergsten

e9hack wrote:

it exist some new DVB-C budget cards, which are based on the KNC ONE (Terratec, 
Setalco) design. They are using a new
tuner with the TDA10023 as demodulator. The main work to support this chip was 
done by Georg Auer. He has implemented
the frontend (tda10023.c) for the ReelBox. The attached archive contains the 
following files:


Fantastic! Thanks so much!

However:


The Patch changes the following things:
- Added the KNC ONE Plus DVB-C card with the id 1894:0022


The KNC1 DVB-C Plus card I'm thinking of buying has the Windows ID 
PCI\VEN_1131DEV_7146SUBSYS_00231894, that is 1894:0023 - not 1894:0022.


Are there _two_ new versions of the Plus (with analogue inputs) card?

/fnord

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb