[PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Hugh Dickins
grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- fs/ext2/balloc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the window [12cff,12d0e], ext2_try_to_allocate repeatedly failing to find the free

Re: [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:41 +, Hugh Dickins wrote: rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Thanks, Acked. This is not a problem for now, as the

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Hugh Dickins
On Tue, 28 Nov 2006, Mingming Cao wrote: On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the window [12cff,12d0e],

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Andrew Morton
On Tue, 28 Nov 2006 13:04:53 -0800 Mingming Cao [EMAIL PROTECTED] wrote: Thanks, I have acked most of them, and will port them to ext3/4 soon. You've acked #2 and #3. #4, #5 and #6 remain un-commented-upon and #1 is unclear? - To unsubscribe from this list: send the line unsubscribe linux-ext4

Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:42 +, Hugh Dickins wrote: grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Acked. Thanks, Mingming --- fs/ext2/balloc.c |4 ++-- 1 file changed, 2

Re: [PATCH 6/6] ext2 balloc: use io_error label

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:44 +, Hugh Dickins wrote: ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Acked, Mingming fs/ext2/balloc.c |7 +++ 1 file

Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:43 +, Hugh Dickins wrote: The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Acked. Thanks, Mingming

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 14:33 -0800, Andrew Morton wrote: On Tue, 28 Nov 2006 13:04:53 -0800 Mingming Cao [EMAIL PROTECTED] wrote: Thanks, I have acked most of them, and will port them to ext3/4 soon. You've acked #2 and #3. #4, #5 and #6 remain un-commented-upon and #1 is unclear?

Re: a question about ext4_fsblk_t

2006-11-28 Thread Mingming Cao
On Sun, 2006-10-22 at 16:50 +0800, guomingyang wrote: I also find many places where the block number type is not changed in namei.c and dir.c. Why? They are all file logical blocks, ext4_fsblk_t is for on disk blocks. Takashi Sato has a patch to define all file logical blocks as

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 20:07 +, Hugh Dickins wrote: On Tue, 28 Nov 2006, Mingming Cao wrote: On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly

[PATCH 1/12] ext3 balloc: reset windowsz when full

2006-11-28 Thread Mingming Cao
Port a series ext2 balloc patches from Hugh to ext3/4. The first 6 patches are against ext3, and the rest are aginst ext4. -- Subject: ext2 balloc: reset windowsz when full From: Hugh Dickins [EMAIL PROTECTED] ext2_new_blocks should reset the

[PATCH 12/12] ext3 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix _with_rsv freeze From: Hugh Dickins [EMAIL PROTECTED] After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the

[PATCH 2/12] ext3 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix off-by-one against grp_goal From: Hugh Dickins [EMAIL PROTECTED] grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such.