Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-07-02 Thread Amit K. Arora
On Mon, Jul 02, 2007 at 08:55:43AM +1000, David Chinner wrote: On Sat, Jun 30, 2007 at 11:21:11AM +0100, Christoph Hellwig wrote: On Tue, Jun 26, 2007 at 04:02:47PM +0530, Amit K. Arora wrote: Can you clarify - what is the current behaviour when ENOSPC (or some other error) is hit?

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-07-02 Thread Jose R. Santos
On Sun, 1 Jul 2007 12:31:53 -0400 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 30, 2007 23:40 -0500, Jose R. Santos wrote: Yes, I think bigger block groups will benefit extents a great deal since not only can we have larger extents, but I believe that as the filesystem ages the chances

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-07-02 Thread Theodore Tso
On Sun, Jul 01, 2007 at 09:48:33AM -0500, Jose R. Santos wrote: Is your concern due to being unable to find contiguous block in the case that a bad disk area is in one of the bitmap blocks? One thing we can do is try to search for another set of contiguous blocks and if we fail to find one,

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-07-02 Thread Mingming Cao
On Mon, 2007-07-02 at 11:49 -0400, Theodore Tso wrote: On Sun, Jul 01, 2007 at 09:48:33AM -0500, Jose R. Santos wrote: Is your concern due to being unable to find contiguous block in the case that a bad disk area is in one of the bitmap blocks? One thing we can do is try to search for

Re: fallocate support for bitmap-based files

2007-07-02 Thread Badari Pulavarty
On Sat, 2007-06-30 at 10:13 -0400, Mingming Cao wrote: On Fri, 2007-06-29 at 13:01 -0700, Andrew Morton wrote: Guys, Mike and Sreenivasa at google are looking into implementing fallocate() on ext2. Of course, any such implementation could and should also be portable to ext3 and ext4

Re: fallocate support for bitmap-based files

2007-07-02 Thread Mingming Cao
On Sat, 2007-06-30 at 13:29 -0400, Andreas Dilger wrote: On Jun 30, 2007 10:13 -0400, Mingming Cao wrote: Another approach we have been thinking is using a backing inode(per-inode-with-preallocation) to store the preallocated blocks. When user asked for preallocation on the base inode,