Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
fs/ext4/dir.c |2 +-
fs/ext4/inode.c |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux/fs/ext4/dir.c
===
--- linux.orig/fs/ext4/dir.c
+++
None of the callers of this function does actually take the BKL
as far as I can see. So remove the comment refering to the BKL.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
fs/jbd/recovery.c |2 +-
fs/jbd2/recovery.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index:
There is no BKL held on entry in -fsync nor in the low level ext3_sync_file.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
fs/ext3/dir.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/fs/ext3/dir.c
===
No BKL used anywhere, so don't mention it.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
fs/ext2/inode.c |1 -
1 file changed, 1 deletion(-)
Index: linux/fs/ext2/inode.c
===
--- linux.orig/fs/ext2/inode.c
+++
I checked ext2_ioctl and could not find anything in there that would
need the BKL. So convert it over to use unlocked_ioctl
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
fs/ext2/dir.c |2 +-
fs/ext2/ext2.h |3 +--
fs/ext2/file.c |4 ++--
fs/ext2/ioctl.c | 12 +++-
4
Remove the BKL from the ext* ioctls.
This is a slightly updated version of the ext[2-4] patches that hit
linux-fsdevel earlier.
-Andi
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
I checked ext3_ioctl and it looked largely safe to not be used
without BKL. So convert it over to unlocked_ioctl.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
v1-v2: drop lock kernel for online growth. resize.c seems to do enough
locking
---
fs/ext3/dir.c |2 +-
fs/ext3/file.c
I checked ext4_ioctl and it looked largely safe to not be used
without BKL. So convert it over to unlocked_ioctl.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
v1-v2: drop BKL for online grow. resize.c seems to do enough locking
---
fs/ext4/dir.c |2 +-
fs/ext4/file.c |
On Fri 25-01-08 03:50:04, Andreas Dilger wrote:
On Jan 25, 2008 11:05 +0100, Jan Kara wrote:
For example ext2 on fsync() just sync's a single inode
(and has to use private_list to track metadata buffers associated with
the inode) while ext3 flushes the whole journal.
As for fsync(), we
Hi Andrew,
here's the patch I wrote you about.
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
---
Commit block was intended to have several copies of the header. But
due to a bug it never had them and actually, nobody checks that.
On Sat 26-01-08 22:02:07, Andrew Morton wrote:
On Wed, 23 Jan 2008 20:09:43 +0100 Jan Kara [EMAIL PROTECTED] wrote:
Commit block is expected to have several copies of the header. Fix the
bug Andrew has spotted ages ago.
ages indeed.
diff --git a/fs/jbd/commit.c
Hi,
What you *could* do is to start putting processes to sleep if they
attempt to write to the frozen filesystem, and then detect the
deadlock case where the process holding the file descriptor used to
freeze the filesystem gets frozen because it attempted to write to the
filesystem --- at
Hi,
Thank you for your comments.
That's inherently unsafe - you can have multiple unfreezes
running in parallel which seriously screws with the bdev semaphore
count that is used to lock the device due to doing multiple up()s
for every down.
Your timeout thingy guarantee that at some point you
Theodore Tso [EMAIL PROTECTED] writes:
Wow. You have a lot of patches in the SLES 10 e2fsprogs. I'm not
sure why of them are there, though. For example:
Patch0: elf.diff
I'm not sure what this one is for.
Patch1: e2fsprogs-1.35-libdir.diff
This one does two
On Fri, Jan 25, 2008 at 05:32:59PM +0100, Valerie Clement wrote:
Hi Ted,
Here are the problems I found when testing e2fsprogs built in the pu
branch. I've checked that they haven't been fixed in the latest version.
(git describe = v1.40.3-98-gb6fea68)
1- Corrupt extent header report from
Hi!
It's been discussed before, but I suspect the main reason why it was
never done is no one submitted a patch. Also, the problem is actually
a pretty complex one. There are a couple of different stages where
you might want to send an alert to processes:
* Data is starting to get
Thierry Vignaud [EMAIL PROTECTED] writes:
In any case, I've just released e2fsprogs 1.40.6.
which prompts me to note that it's neither on
ftp://ftp.kernel.org/pub/linux/utils/util-linux-ng/v2.13 nor on
http://e2fsprogs.sourceforge.net/
What is supposed to be the current primary source?
Theodore Tso wrote:
On Mon, Jan 28, 2008 at 04:26:53PM +0100, Matthias Koenig wrote:
Patch6: e2fsprogs-mdraid.patch
This apparently adds a new environment variable,
BLKID_SKIP_CHECK_MDRAID, which forces blkid to not detect mdraid
devices. I'm not sure why.
Workaround for people
Theodore Tso [EMAIL PROTECTED] writes:
In any case, I've just released e2fsprogs 1.40.6.
which prompts me to note that it's neither on
ftp://ftp.kernel.org/pub/linux/utils/util-linux-ng/v2.13 nor on
http://e2fsprogs.sourceforge.net/
What is supposed to be the current primary source?
It
Hi,
I screwed up, and incorrectly tagged v1.40.5 in the e2fsprogs git
repository. I accidentally tagged the next branch instead of the
maint branch, so the the wrong commit was tagged as v1.40.5. Argh...
This has been fixed on git.kernel.org, but it's still busted on
repo.or.cz.
If you've
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
I screwed up, and incorrectly tagged v1.40.5 in the e2fsprogs git
repository. I accidentally tagged the next branch instead of the
maint branch, so the the wrong commit was tagged as v1.40.5. Argh...
This has been fixed on git.kernel.org, but
On Mon 2008-01-28 14:56:33, Theodore Tso wrote:
On Mon, Jan 28, 2008 at 07:30:05PM +, Pavel Machek wrote:
As user pages are always in highmem, this should be easy to decide:
only send SIGDANGER when highmem is full. (Yes, there are
inodes/dentries/file descriptors in lowmem, but I
Hi Andrew,
the patch below fixes a lock inversion which someone reported recently.
More details below in the changelog. Can you merge the patch please? I'll
also write a similar patch for ext4 once we agree this is the way to go...
On Tue, Jan 29, 2008 at 01:43:31AM +0100, Petr Baudis wrote:
Done, though it should be doable from your side as well by something
like
git push reporepo :refs/tags/v1.40.5
Wow, I thought that only worked on branches, but you're right, that
works. Thanks!!!
Hi,
On Mon, Jan 28, 2008 at 01:19:23PM -0500, Theodore Tso wrote:
I screwed up, and incorrectly tagged v1.40.5 in the e2fsprogs git
repository. I accidentally tagged the next branch instead of the
maint branch, so the the wrong commit was tagged as v1.40.5. Argh...
This has been fixed
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus
This is the major set of updates meant for 2.6.24 from the ext4 team;
these patches have been baking in -mm for a while. The two major
features included here is the multi-block allocator
I've just released 2.6.24-ext4-1. It's basically just a clean up of the
stable patch series, in response to LKML review comments, in preparation
for Linus to pull them into mainline.
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git 2.6.24-ext4-1
On Mon, 28 Jan 2008, Theodore Tso wrote:
On Mon, Jan 28, 2008 at 07:30:05PM +, Pavel Machek wrote:
As user pages are always in highmem, this should be easy to decide:
only send SIGDANGER when highmem is full. (Yes, there are
inodes/dentries/file descriptors in lowmem, but I doubt apps
28 matches
Mail list logo
