Re: [RFC] ext3 freeze feature ver 0.2

2008-02-26 Thread Andreas Dilger
On Feb 26, 2008 08:39 -0800, Eric Sandeen wrote: Takashi Sato wrote: o Elevate XFS ioctl numbers (XFS_IOC_FREEZE and XFS_IOC_THAW) to the VFS As Andreas Dilger and Christoph Hellwig advised me, I have elevated them to include/linux/fs.h as below. #define FIFREEZE_IOWR

Re: What's cooking in e2fsprogs.git (topics)

2008-02-24 Thread Andreas Dilger
be enabled by default. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: What's cooking in e2fsprogs.git (topics)

2008-02-22 Thread Andreas Dilger
? How do we decide that it's cooked enough? :) I'd say when e2fsprogs has an official release with extents support, and there are no show-stopping bugs in the existing code... I don't think that is too far off anymore. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun

Re: [E2FSPROGS, RFC] New mke2fs types parsing

2008-02-21 Thread Andreas Dilger
inode_size = 256 } Presumably the ext4 feature should also have features = has_journal? If this is the default for ext4, why would it need to be given for ext3? We should also add dir_nlink,flexbg while we are in there. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer

Re: [PATCH] blkid detection for ZFS

2008-02-21 Thread Andreas Dilger
On Feb 20, 2008 07:57 -0500, Theodore Ts'o wrote: On Thu, Feb 14, 2008 at 06:07:40PM -0700, Andreas Dilger wrote: Some input is welcome here also... There is a UUID (GUID) for the whole pool (aggregation of devices that ZFS filesystems might live on), a UUID for the virtual device (vdev

Re: How were some of the lustre e2fsprogs test cases generated?

2008-02-19 Thread Andreas Dilger
of the patch, but the regression tests still passed. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: How were some of the lustre e2fsprogs test cases generated?

2008-02-19 Thread Andreas Dilger
On Feb 19, 2008 07:29 -0500, Theodore Ts'o wrote: On Tue, Feb 19, 2008 at 04:40:32AM -0700, Andreas Dilger wrote: No, it hasn't always been true that we cleared the _hi fields in the kernel code. But, it has been a year or more since we found this bug, and all CFS e2fsprogs releases since

Re: [PATCH][7/28] e2fsprogs-extents.patch

2008-02-18 Thread Andreas Dilger
that are being propogated to child inodes. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH RESEND] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-14 Thread Andreas Dilger
think the original patch was correct. Sorry about the confusion. I thought at first glance this was for freeing the blocks from releasing an extent, but that is incorrect. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from

[PATCH] blkid detection for ZFS

2008-02-14 Thread Andreas Dilger
, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. Index: e2fsprogs-cfs/lib/blkid/probe.c === --- e2fsprogs-cfs.orig/lib/blkid/probe.c +++ e2fsprogs-cfs/lib/blkid/probe.c @@ -647,6 +647,21

Re: [PATCH] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-13 Thread Andreas Dilger
); - BUG_ON(size = 0 || size = EXT4_BLOCKS_PER_GROUP(ac-ac_sb)); + BUG_ON(size = 0 || size EXT4_BLOCKS_PER_GROUP(ac-ac_sb)); Please separate this into two BUG_ON() statements, so it is clear which one is being hit. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun

Re: What's in e2fsprogs.git (stable)

2008-02-11 Thread Andreas Dilger
On Feb 10, 2008 23:41 -0500, Theodore Ts'o wrote: Most of the maint branch went into the e2fsprogs 1.40.6 release that happened this weekend. Including the URL of the GIT repo in these messages would be useful. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun

Re: [PATCH][0/28] Lustre e2fsprogs patch series

2008-02-11 Thread Andreas Dilger
On Feb 10, 2008 23:19 -0500, Theodore Ts'o wrote: On Sat, Feb 02, 2008 at 12:59:43AM -0700, Andreas Dilger wrote: The following series of emails will contain the large part of the e2fsprogs patch series that is used for Lustre. It will not contain the regression tests for EXTENTS nor

Re: [RFC] ext3 freeze feature

2008-02-08 Thread Andreas Dilger
cord for unfreeze You may as well make the common ioctl the same as the XFS version, both by number and parameters, so that applications which already understand the XFS ioctl will work on other filesystems. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada

[PATCH] extra checking for in-inode EAs

2008-02-05 Thread Andreas Dilger
cases. A more complete check (not implemented here) would be to ensure that the EAs don't overlap as is done with the external EAs. Some extra whitespace is removed in the first hunk. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] --- e2fsck/pass1.c.orig 2008-02-04 10:41:50.0 -0700

Re: [Bug 9855] ext3 ACL corruption

2008-02-04 Thread Andreas Dilger
On Jan 31, 2008 22:44 +1030, Kevin Shanahan wrote: On Thu, 2008-01-31 at 03:05 -0700, Andreas Dilger wrote: ... To get the interesting bits you need: debugfs: stat 95 # prints decoded inode, File ACL: is a block number debugfs: imap 95 # prints inode block number, offset

[PATCH][1/28] e2fsprogs-specdotin.patch

2008-02-02 Thread Andreas Dilger
split the RPM built by this spec file, but this is complicated by the fact that SLES and RHEL have different splits. Signed-off-by: Girish Shilamkar [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.5/e2fsprogs.spec.in

[PATCH] [2/28] e2fsprogs-eacheck.patch

2008-02-02 Thread Andreas Dilger
Verify in-inode EA structure. Allow in-inode EAs to have a checksum. Connect zero-length inodes that have an EA to lost+found. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.5/e2fsck/e2fsck.h === --- e2fsprogs

Re: [PATCH][4/28] e2fsprogs-tests-f_unsorted_EAs.patch

2008-02-02 Thread Andreas Dilger
Attached binary patch. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. e2fsprogs-tests-f_unsorted_EAs.patch Description: Binary data

Re: [PATCH][6/28] e2fsprogs-nlinks.patch

2008-02-02 Thread Andreas Dilger
. In pass4 if counted links are 2 and if existing nlink count = 1, e2fsck corrects the nlink count without displaying any errors. The file hard link count is also increased to 65000, but this cannot be exceeded. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Kalpak Shah [EMAIL

Re: [PATCH][8/28] e2fsprogs-config-before-cmdline.patch

2008-02-02 Thread Andreas Dilger
The patch changes the order that the config file and command line are parsed so that command line has precedence. It also allows multiple -E options to be specified on the command line. Signed-off-by: Jim Garlick [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index

Re: [PATCH][9/28] e2fsprogs-SLES10--m-support.patch

2008-02-02 Thread Andreas Dilger
, interactive); if (serialize || (max_running (num_running = max_running))) { Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body

Re: [PATCH][11/28] e2fsprogs-nlinks-flag.patch

2008-02-02 Thread Andreas Dilger
or + data loss may result.\n), stderr); + } + if (!flex_bg old_flex_bg) { if (ext2fs_check_desc(fs)) { fputs(_(Clearing the flex_bg flag would Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc

Re: [PATCH][12/28] e2fsprogs-expand-extra-isize.patch

2008-02-02 Thread Andreas Dilger
nanosecond timestamps or 64-bit inode version fields are required for all inodes in the filesystem. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Index: e2fsprogs-1.40.5/lib/ext2fs/ext_attr.c

Re: [PATCH][15/28] e2fsprogs-ibadness-counter.patch

2008-02-02 Thread Andreas Dilger
-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Girish Shilamkar [EMAIL PROTECTED] Index: e2fsprogs-1.40.4/e2fsck/e2fsck.h === --- e2fsprogs-1.40.4.orig/e2fsck/e2fsck.h +++ e2fsprogs-1.40.4/e2fsck/e2fsck.h @@ -11,6 +11,7

Re: [PATCH][19/28] e2fsprogs-stride_option.patch

2008-02-02 Thread Andreas Dilger
-by: Rupesh Thakare [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.5/lib/ext2fs/initialize.c === --- e2fsprogs-1.40.5.orig/lib/ext2fs/initialize.c +++ e2fsprogs-1.40.5/lib/ext2fs/initialize.c @@ -156,6

Re: [PATCH][20/28] e2fsprogs-mmp.patch

2008-02-02 Thread Andreas Dilger
Shah [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.5/lib/e2p/feature.c === --- e2fsprogs-1.40.5.orig/lib/e2p/feature.c +++ e2fsprogs-1.40.5/lib/e2p/feature.c @@ -67,6 +67,8 @@ static struct

Re: [PATCH][25/28] e2fsprogs-i_size-corruption.patch

2008-02-02 Thread Andreas Dilger
Fix handling of block preallocation support in cases where the kernel PAGE_SIZE is larger than the filesystem blocksize. Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.2/e2fsck/pass1.c

Re: [PATCH][26/28] e2fsprogs-fiemap.patch

2008-02-02 Thread Andreas Dilger
Add support for ioctl(FIEMAP) to filefrag. If the kernel supports FIEMAP the filefrag program prefers this more efficient mechanism to get extent information instead of repeated FIBMAP calls. Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index

Re: [PATCH][27/28] e2fsprogs-debugfs-supported_features.patch

2008-02-02 Thread Andreas Dilger
Print out the currently supported features of e2fsprogs/libext2fs via a new debugfs supported_features command. Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.2/debugfs/debug_cmds.ct

Re: [PATCH][28/28] e2fsprogs-lts-make_rpms.patch

2008-02-02 Thread Andreas Dilger
Allow make rpm to take some extra configure options from the build environment without having to patch the code. Build the tarball in a temporary directory instead of the e2fsprogs source directory. Signed-off-by: Michael MacDonald [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL

[PATCH][0/28] Lustre e2fsprogs patch series

2008-02-01 Thread Andreas Dilger
e2fsprogs-i_size-corruption.patch e2fsprogs-fiemap.patch e2fsprogs-debugfs-supported_features.patch e2fsprogs-lts-make_rpms.patch Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-01-31 Thread Andreas Dilger
-- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: e2fsck ext4 with extents possible?

2008-01-30 Thread Andreas Dilger
into the upstream e2fsprogs in the interim while Ted is reimplementing the extents support. Note the above RPMs contain patches which are NOT related just to ext4 and should not become part of a distro. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc

Re: RFC: file magic for ext4

2008-01-30 Thread Andreas Dilger
something like: # file -C -m magic; file -m ./magic -s /dev/sda1 -Eric # ext2/ext3 filesystems - Andreas Dilger [EMAIL PROTECTED] Lol, you may as well fix up the email [EMAIL PROTECTED] will probably be the least transient. 0x438 leshort 0xEF53 Linux 0x44c lelong

Re: [Bugme-new] [Bug 9855] New: ext3 ACL corruption

2008-01-30 Thread Andreas Dilger
LVs for the filesystem. If you are able to reproduce this, could you please dump the inode and EA block before fixing the problem. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux

Re: Integrating patches in SLES10 e2fsprogs

2008-01-29 Thread Andreas Dilger
8 (4kB) and not further into the disk to catch e.g. reiserfs superblocks. Usually it will overwrite this anyways (GDT, bitmaps, inode table), but in some rare cases it might not. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc

Re: [RFC] Parallelize IO for e2fsck

2008-01-25 Thread Andreas Dilger
of process (and not just those that are event loop driven) can register a callback at some arbitrary point in the code and be notified. I don't object to the poll() interface, but it would be good to have a signal mechanism also. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun

Re: Patch queue update

2008-01-24 Thread Andreas Dilger
)); } - There don't actually need to be braces here either. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Integrating patches in SLES10 e2fsprogs

2008-01-24 Thread Andreas Dilger
? Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Parallelize IO for e2fsck

2008-01-24 Thread Andreas Dilger
an issue. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RFC] Add new development flag to the ext4 filesystem

2008-01-23 Thread Andreas Dilger
for a Google Summer-of-Code project. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 41/49] ext4: Add multi block allocator for ext4

2008-01-23 Thread Andreas Dilger
EXT3: 4.82 4 10896284672 EXT4: 1.61 5 11065364632 REISERFS: 3.15 8 2762768236 JFS : 33.90 7 16814400 33048 XFS : 20.03 8 296663286160 Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread Andreas Dilger
-- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Parallelize IO for e2fsck

2008-01-21 Thread Andreas Dilger
On Jan 22, 2008 14:38 +1100, David Chinner wrote: On Mon, Jan 21, 2008 at 04:00:41PM -0700, Andreas Dilger wrote: I discussed this with Ted at one point also. This is a generic problem, not just for readahead, because fsck can run multiple e2fsck in parallel and in case of many large

Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch]

2008-01-17 Thread Andreas Dilger
. Figuring out how to back that up would probably have landed firmly in my lap. Ouch. ;) Charge them for 2PB of storage, and use rsync :-). Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] e2fsprogs: New bitmap and inode table allocation for FLEX_BG

2008-01-11 Thread Andreas Dilger
if . + shift = 0; + tmp = flex_bg_size; + while ((tmp = 1UL) != 0UL) + shift++; There isn't a log2 function? Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list

Re: [PATCH] New inode allocation for FLEX_BG meta-data groups.

2008-01-11 Thread Andreas Dilger
)? Otherwise this renders the filesystem unusable. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] ext4: Use superblock s_raid_stripe_width as stripe size during block allocation.

2008-01-10 Thread Andreas Dilger
that is fine... For 1kB block filesystem that is only 8MB in size. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH] set s_raid_stride and s_raid_stripe_width

2008-01-09 Thread Andreas Dilger
-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.4/lib/ext2fs/initialize.c === --- e2fsprogs-1.40.4.orig/lib/ext2fs/initialize.c +++ e2fsprogs-1.40.4/lib/ext2fs/initialize.c @@ -156,6 +156,8 @@ errcode_t ext2fs_initialize

Re: [PATCH] set s_raid_stride and s_raid_stripe_width

2008-01-09 Thread Andreas Dilger
), + param-s_raid_stripe_width, param-s_raid_stride); We also want to validate that s_raid_stripe_width is not = blocks_per_group. And probably that s_raid_stripe_width = s_raid_stride. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc

Re: [PATCH] ext4: Use superblock s_raid_stripe_width as stripe size during block allocation.

2008-01-09 Thread Andreas Dilger
alignment to be just after '(' on previous line. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] e2fsprogs: play with 8TB to 16TB fs's better

2008-01-09 Thread Andreas Dilger
-- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] e2fsprogs: play with 8TB to 16TB fs's better

2008-01-08 Thread Andreas Dilger
0x blocks we should do the same so it may as well be a simple helper function. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED

Re: [PATCH] UPDATED3: types fixup for mballoc

2008-01-08 Thread Andreas Dilger
it returns fe_len. changes anything that does groupno * EXT4_BLOCKS_PER_GROUP or pa-pa_pstart + whatever to an ext4_fsblk_t avoids 64-bit divides modulos, and... fixes up any related formats Signed-off-by: Eric Sandeen [EMAIL PROTECTED] You can add a Signed-off-by: Andreas Dilger [EMAIL

Re: [Bug 9692] New: journal_data mount option causes filesystem

2008-01-07 Thread Andreas Dilger
-by: Andreas Dilger [EMAIL PROTECTED] From 654f24814e7b80d3b16bec2a67c13c43cb20eb2f Mon Sep 17 00:00:00 2001 From: Jayson R. King [EMAIL PROTECTED] Date: Sun, 6 Jan 2008 18:14:18 -0600 Subject: e2fsck: Fix off-by-one error in check_blocks() e2fsck allows extra blocks to be allocated to an inode up

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-04 Thread Andreas Dilger
); +ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); return err; } What about changing the __FUNCTION__ to __func__, while you are at it? What's wrong with __FUNCTION__? I thought that was ANSI C? Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun

Re: [PATCH] UPDATED: types fixup for mballoc

2008-01-03 Thread Andreas Dilger
other changes in the patch related to this fix: https://bugzilla.lustre.org/attachment.cgi?id=13275 Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message

Re: [PATCH] UPDATED2: types fixup for mballoc

2008-01-03 Thread Andreas Dilger
-s_stripe - 1; do_div(a, sbi-s_stripe); a = (a * sbi-s_stripe) - group_start; Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

2008-01-02 Thread Andreas Dilger
on EXPERIMENTAL + depends on BROKEN select JBD2 select CRC16 help Isn't CONFIG_EXPERIMENTAL enough? Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body

Re: [PATCH] ext4: Fix the soft lockup with multi block allocator.

2007-12-24 Thread Andreas Dilger
On Dec 24, 2007 21:18 +0300, Alex Tomas wrote: Andreas Dilger wrote: On Dec 21, 2007 16:39 +0530, Aneesh Kumar K.V wrote: @@ -3790,7 +3782,9 @@ repeat: /* if we still need more blocks and some PAs were used, try again */ if (free needed busy) { + busy = 0

Re: What's cooking in e2fsprogs.git (topics)

2007-12-17 Thread Andreas Dilger
then. Otherwise, it may be that undo manager should be reserved for e2fsck right now, or possibly reworked to just do IO to a sparse file similar to doing an e2image before the mke2fs. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc

Re: What's cooking in e2fsprogs.git (topics)

2007-12-17 Thread Andreas Dilger
On Dec 17, 2007 17:59 -0500, Theodore Tso wrote: On Mon, Dec 17, 2007 at 03:34:55PM -0700, Andreas Dilger wrote: We had also wanted to move from using db4 to tdb for the Lustre lfsck data (collection of EA information for distributed fsck) but even at 1 files the tdb performance

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-14 Thread Andreas Dilger
checksums). Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-13 Thread Andreas Dilger
a power of two (it is) then they will always be even multiples. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-11 Thread Andreas Dilger
On Dec 07, 2007 09:52 -0600, Jose R. Santos wrote: Andreas Dilger [EMAIL PROTECTED] wrote: There is no particular reason that this ratio needs to be *100, it could just as easily be a fraction of 256 and make the multiply into a shift. The free_block_ratio would be 26 in that case

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-11 Thread Andreas Dilger
incorrectly (maybe by a version of mke2fs that doesn't verify this) and the code will not do the right thing. Storing it in bits (as is done with e.g. s_log_block_size and s_log_frag_size) ensures there is no possibility of a value that isn't a power-of-two. Cheers, Andreas -- Andreas Dilger Sr. Staff

Re: [RFC][PATCH] 64 bit blocks support for e2fsprogs

2007-12-10 Thread Andreas Dilger
the difference to (unsigned). The difference will never need to be a 64-bit value, but the returned type will be blk64_t. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body

Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.

2007-12-07 Thread Andreas Dilger
the flex_bg option to the list of possible feature combinations to test. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/3] ext4: different maxbytes functions for bitmap extent files

2007-12-05 Thread Andreas Dilger
to do this, maybe: upper_limit = (1LL (32 + 9) - 1) ~((1 blkbits) - 1); Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL

Re: Understanding mballoc

2007-12-03 Thread Andreas Dilger
for mballoc+extents. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Flex_BG ialloc awareness.

2007-12-03 Thread Andreas Dilger
s_groups_per_meta to be a power-of-two so that this can become a shift instead of a divide. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL

Re: [PATCH] ext4: add block bitmap validation

2007-11-21 Thread Andreas Dilger
of the bitmap/itable offsets are within the bitmap being read, like: offset = ... if (offset EXT4_BLOCKS_PER_GROUP(sb) ext4_test_bit(offset, bh-b_data)) /* bad block bitmap */ goto err_out; Cheers, Andreas -- Andreas Dilger Sr. Software

Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Andreas Dilger
. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: test for EA validity checking

2007-11-15 Thread Andreas Dilger
On Nov 10, 2007 05:10 -0700, Andreas Dilger wrote: Attached is a test image for extended attribute block checking. This small image contains a number of different kinds of corruptions (bad magic, bad checksum, empty block, bad EA block number), as well as an old-format (v1) EA, and a valid v2

test for EA validity checking

2007-11-10 Thread Andreas Dilger
Attached is a test image for extended attribute block checking. This small image contains a number of different kinds of corruptions (bad magic, bad checksum, empty block, bad EA block number), as well as an old-format (v1) EA, and a valid v2 EA. Cheers, Andreas -- Andreas Dilger Sr. Software

Re: ext3 metaclustering performance numbers and updated patch

2007-11-09 Thread Andreas Dilger
breaking up the group in the middle if you are creating large files. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH] fix check_mntent_file() to pass mode for open(O_CREAT)

2007-11-08 Thread Andreas Dilger
On my FC8 install, ismounted.c fails to build because open(O_CREAT) is used without passing a mode. The following trivial patch fixes it. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Index: e2fsprogs-1.40.2/lib/ext2fs/ismounted.c

Re: [PATCH] allow tune2fs to set/clear resize_inode

2007-11-07 Thread Andreas Dilger
On Nov 06, 2007 13:51 -0500, Theodore Tso wrote: On Tue, Nov 06, 2007 at 09:12:55AM +0800, Andreas Dilger wrote: What is needed is an ext2prepare-like step that involves resize2fs code to move the file/dir blocks and then the move inode table, as if the filesystem were going to be resized

Re: delalloc fragmenting files?

2007-11-07 Thread Andreas Dilger
the performance in any meaningful way. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: More testing: 4x parallel 2G writes, sequential reads

2007-11-07 Thread Andreas Dilger
slower in the read case. What happens if you have 4 parallel readers? Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More

Re: What's cooking in e2fsprogs.git (topics)

2007-11-05 Thread Andreas Dilger
On Nov 04, 2007 23:32 -0500, Theodore Tso wrote: On Mon, Nov 05, 2007 at 10:15:33AM +0800, Andreas Dilger wrote: On Nov 04, 2007 17:42 -0500, Theodore Ts'o wrote: * js/uninit (Sun Oct 21 21:04:24 2007 -0500) 14 commits - Add m_uninit test case. - Add new mm_lazy test case

Re: delalloc fragmenting files?

2007-11-05 Thread Andreas Dilger
..121855]: 790536..916484: 125948: 0 : Hopefully Kalpak will be able to post the updated patches here soon. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4

Re: [PATCH] allow tune2fs to set/clear resize_inode

2007-11-05 Thread Andreas Dilger
but do not actually add new blocks/groups at the end of the filesystem. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More

Re: What's cooking in e2fsprogs.git (topics)

2007-11-04 Thread Andreas Dilger
. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RFC]JBD2: Fix journal checksum kernel oops on NUMA

2007-11-02 Thread Andreas Dilger
On Nov 02, 2007 08:31 -0800, Badari Pulavarty wrote: On Fri, 2007-11-02 at 13:20 +0800, Andreas Dilger wrote: On Nov 01, 2007 17:40 -0700, Mingming Cao wrote: Current journal checksumming patch failed fsstress test on NUMA. The bh-b_data passed to the crc32_be () function could be NULL

Re: [PATCH][RFC]Ext4: Use get_cpu()/put_cpu() in preemptible context

2007-11-02 Thread Andreas Dilger
(); /* we're going to use group allocation */ ac-ac_flags |= EXT4_MB_HINT_GROUP_ALLOC; Shouldn't the put_cpu() be after ac-ac_lg is no longer being used? I guess there would otherwise be a danger of other processes using the same s_locality_groups[] struct? Cheers, Andreas -- Andreas Dilger Sr

[EMAIL PROTECTED]: [RFC PATCH ext3/ext4] orphan list corruption due bad inode]

2007-11-01 Thread Andreas Dilger
)) { + iput(inode); + return ERR_PTR(-ENOENT); + } + parent = d_alloc_anon(inode); if (!parent) { iput(inode); - End forwarded message - Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun

Re: [PATCH][RFC]JBD2: Fix journal checksum kernel oops on NUMA

2007-11-01 Thread Andreas Dilger
... Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-10-29 Thread Andreas Dilger
to use FIEMAP. FIEMAP_1.0.txt == File Mapping Interface 18 June 2007 Andreas Dilger, Kalpak Shah Introduction This document covers the user interface and internal implementation of an efficient fragmentation reporting tool

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-10-29 Thread Andreas Dilger
On Oct 29, 2007 16:13 -0600, Andreas Dilger wrote: On Oct 29, 2007 13:57 -0700, Mark Fasheh wrote: I'm a little bit confused by fe_offset. Is it a physical offset, or a logical offset? The reason I ask is that your description above says FIEMAP ioctl will return the logical to physical

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-10-29 Thread Andreas Dilger
, Andreas Dilger wrote: The FIEMAP ioctl (FIle Extent MAP) is similar to the existing FIBMAP ioctl block device ioctl used for mapping an individual logical block address in a file to a physical block address in the block device. The FIEMAP ioctl will return the logical to physical mapping

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-10-29 Thread Andreas Dilger
On Oct 29, 2007 17:11 -0700, Mark Fasheh wrote: On Mon, Oct 29, 2007 at 04:13:02PM -0600, Andreas Dilger wrote: Btrfs, Ocfs2, and Gfs2 pack small amounts of user data directly in inode blocks. Hmm, but part of the issue would be how to request the extra data, and what offset

Re: delalloc fragmenting files?

2007-10-26 Thread Andreas Dilger
be caused by the fact the patches were changed at one point from delalloc-atop-mballoc to mballoc-atop-delalloc, and something was missed in that conversion. Have you tried O_DIRECT? That is another way to access mballoc w/o using delalloc. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer

Re: [PATCH] Clustering indirect blocks in Ext2

2007-10-25 Thread Andreas Dilger
ext3 for most of these features against older vendor kernels (SLES10 2.6.16, RHEL5 2.6.18) if that is of interest to you (only delalloc isn't included in the existing Lustre patch set, but I believe Alex had delalloc patches for 2.6.18 kernels in the past). Cheers, Andreas -- Andreas Dilger Sr

Re: [PATCH] Clustering indirect blocks in Ext2

2007-10-25 Thread Andreas Dilger
-- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Andreas Dilger
of the ext4 features (large inodes, etc) for ext4 filesystems. Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Andreas Dilger
On Oct 24, 2007 16:15 -0500, Eric Sandeen wrote: Andreas Dilger wrote: It is useful to be able to mount w/o extents/delalloc/mballoc for perf testing and functional testing of the block-mapped file path in ext4. Also, some users might want the ability to use features of ext4 w/o

Re: ext3 warnings from LTP rename14

2007-10-18 Thread Andreas Dilger
is a sparc32 (big endian). I'd suspect you can reproduce this on a PPC system also. You might also consider running sparse on it ext3/ext4 in case you missed an le32_to_cpu() or something. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe

Re: [GIT PULL] ext4 update

2007-10-18 Thread Andreas Dilger
in the pipe, however). (c) The actual speedup depends on how full the filesystem is, but since ext* usually has way too many inodes, it is generally pretty good. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line

  1   2   3   4   >