Re: (un)lock_kernel() ?

2007-04-10 Thread Ming Zhang
On Wed, 2007-04-04 at 12:52 -0400, John Anthony Kazos Jr. wrote: According to Documentation/filesystems/Locking, -get_sb() is called with the BKL held, but looking through the code, I'm not able to find where it is being taken. I noticed that too. Unless I'm just dumb and can't see it,

Re: (un)lock_kernel() ?

2007-04-10 Thread Dave Kleikamp
On Tue, 2007-04-10 at 12:03 -0400, Ming Zhang wrote: On Wed, 2007-04-04 at 12:52 -0400, John Anthony Kazos Jr. wrote: According to Documentation/filesystems/Locking, -get_sb() is called with the BKL held, but looking through the code, I'm not able to find where it is being taken. I

(un)lock_kernel() ?

2007-04-04 Thread John Anthony Kazos Jr.
Why does ext4_fill_super release the BKL on entry and take it on both normal and abnormal exit? As far as I can see, ext4_fill_super is called by get_sb_bdev, which calls the -get_sb method without the BKL, and ext4_get_sb calls get_sb_bdev without the BKL. And the ext2 code does not touch the

Re: (un)lock_kernel() ?

2007-04-04 Thread Dave Kleikamp
On Wed, 2007-04-04 at 08:57 -0400, John Anthony Kazos Jr. wrote: Why does ext4_fill_super release the BKL on entry and take it on both normal and abnormal exit? As far as I can see, ext4_fill_super is called by get_sb_bdev, which calls the -get_sb method without the BKL, and ext4_get_sb

Re: (un)lock_kernel() ?

2007-04-04 Thread John Anthony Kazos Jr.
According to Documentation/filesystems/Locking, -get_sb() is called with the BKL held, but looking through the code, I'm not able to find where it is being taken. I noticed that too. Unless I'm just dumb and can't see it, I'm not able to find any BKL references during filesystem mounting