Re: delayed allocatiou result in Oops

2007-06-20 Thread Mingming Cao
On Wed, 2007-06-20 at 12:15 +0400, Alex Tomas wrote: Mingming Cao wrote: Hmm, PageMappedToDisk is probably not sufficient enough for pagesize! =blocksize. Is that the reason we need page-private to pass the request? PageMappedToDisk isn't enough in that case, definitely. bh is the way

Re: delayed allocatiou result in Oops

2007-06-19 Thread Alex Tomas
Mingming Cao wrote: From the comments it says the page-private is set to 1 to letting commit_write know that it needs block reservation, but I don't see the page-private value being checked in ext4_wb_commit_write(). Instead, the PageMappedToDisk(page) flag is being checked. Alex, can you

Re: delayed allocatiou result in Oops

2007-06-19 Thread Dmitry Monakhov
On 11:11 Втр 19 Июн , Alex Tomas wrote: Mingming Cao wrote: From the comments it says the page-private is set to 1 to letting commit_write know that it needs block reservation, but I don't see the page-private value being checked in ext4_wb_commit_write(). Instead, the

Re: delayed allocatiou result in Oops

2007-06-19 Thread Alex Tomas
Dmitry Monakhov wrote: But whole approach based on using PagePrivate bit and page-private ptr for special purposes is realy dengerous, and imho wrong, because avery fs-related code assume that page-private points to page_buffers. Especially this approach not work for blksize pgsize. The best

Re: delayed allocatiou result in Oops

2007-06-19 Thread Mingming Cao
On Tue, 2007-06-19 at 11:11 +0400, Alex Tomas wrote: Mingming Cao wrote: From the comments it says the page-private is set to 1 to letting commit_write know that it needs block reservation, but I don't see the page-private value being checked in ext4_wb_commit_write(). Instead, the

Re: delayed allocatiou result in Oops

2007-06-19 Thread Aneesh Kumar K.V
Mingming Cao wrote: O BTW, can you point me your latest and greatest mballoc patch? I am trying to forward port and merge that patch to ext4 patch queue I am looking at the one found at. ftp://ftp.clusterfs.com/pub/people/alex/2.6.19-rc6 -aneesh - To unsubscribe from this list:

Re: delayed allocatiou result in Oops

2007-06-18 Thread Mingming Cao
On Sat, 2007-06-16 at 12:14 +0400, Dmitriy Monakhov wrote: On 16:16 Птн 15 Июн , Mingming Cao wrote: I hit almost the same issue today also, but with different error #, and one more kernel oops, when run fsstress on x86_64. EXT4-fs: writeback error = -2 EXT4-fs: writeback error =

Re: delayed allocatiou result in Oops

2007-06-16 Thread Dmitriy Monakhov
On 16:16 Птн 15 Июн , Mingming Cao wrote: I hit almost the same issue today also, but with different error #, and one more kernel oops, when run fsstress on x86_64. EXT4-fs: writeback error = -2 EXT4-fs: writeback error = -2 This error never happens in writeback in my case, only ENOSPC.

Re: delayed allocatiou result in Oops

2007-06-14 Thread Alex Tomas
looks like an error in error handling path (notice -28 (ENOSPC) before) thanks for the report, Alex Dmitriy Monakhov wrote: ) Simple test failed on ext4 when delayed allocation was used. #mkfs.ext3 -b4096 /dev/vzvg/test2 #mount -text4dev /dev/vzvg/test2 /mnt/test -odelalloc #fsstress -d