[PATCH] Add i_version_hi for 64-bit version

2007-03-18 Thread Kalpak Shah
Hi, This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version. Signed-off-by: Andreas Dilger

Re: e2fsprogs coverity patch cid-1.diff

2007-03-18 Thread Theodore Tso
On Fri, Feb 09, 2007 at 06:08:16PM -0800, Brian D. Behlendorf wrote: Coverity ID: 2: Checked Return Would I be right in assuming this should be Coverity ID 1, and not 2? (cid-2.diff is also labelled as Coverity ID 1). What is Coverity ID's, anyway? I assume they are something you locally

Re: e2fsprogs coverity patch cid-01.diff

2007-03-18 Thread Theodore Tso
On Fri, Feb 09, 2007 at 06:08:16PM -0800, Brian D. Behlendorf wrote: Found 2 of the three places where a return code for ext2fs_write_inode() was not being checked. Index: e2fsprogs+chaos/resize/resize2fs.c === ---

Re: e2fsprogs coverity patch cid-03.diff

2007-03-18 Thread Theodore Tso
On Fri, Feb 09, 2007 at 06:11:26PM -0800, Brian D. Behlendorf wrote: blkid_dev_has_tag() will immediately return -1 (an error if value is NULL. Thus at the test later on value cannot be NULL. There are two possible ways to go about fixing this. The first would be to remove the first NULL

Re: e2fsprogs coverity patch cid-1.diff

2007-03-18 Thread Andreas Dilger
On Mar 18, 2007 09:40 -0400, Theodore Tso wrote: On Fri, Feb 09, 2007 at 06:08:16PM -0800, Brian D. Behlendorf wrote: Coverity ID: 2: Checked Return Would I be right in assuming this should be Coverity ID 1, and not 2? (cid-2.diff is also labelled as Coverity ID 1). What is Coverity